From: Laszlo Ersek <lersek@redhat.com>
To: Igor Druzhinin <igor.druzhinin@citrix.com>, edk2-devel@lists.01.org
Cc: anthony.perard@citrix.com, jordan.l.justen@intel.com,
julien.grall@arm.com, xen-devel@lists.xenproject.org,
ard.biesheuvel@linaro.org
Subject: Re: [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing
Date: Wed, 6 Mar 2019 14:22:49 +0100 [thread overview]
Message-ID: <e8cdf4a2-b02b-daa7-4301-803fb1e0086d__3872.08164190582$1551878633$gmane$org@redhat.com> (raw)
In-Reply-To: <1551876056-28223-4-git-send-email-igor.druzhinin@citrix.com>
On 03/06/19 13:40, Igor Druzhinin wrote:
> On Xen, hvmloader firmware leaves address decoding enabled for
> enumerated PCI device before jumping into OVMF. OVMF seems to
> expect it to be disabled and tries to size PCI BARs in several places
> without disabling it which causes BAR64, for example, being
> incorrectly placed by QEMU.
>
> Fix it by disabling PCI address decoding explicitly before the
> first attempt to size BARs on Xen.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Igor Druzhinin <igor.druzhinin@citrix.com>
> ---
> OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 34 +++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> index 408fb24..9940335 100644
> --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> @@ -55,6 +55,33 @@ PcatPciRootBridgeBarExisted (
> EnableInterrupts ();
> }
>
> +#define EFI_PCI_COMMAND_DECODE ((UINT16)(EFI_PCI_COMMAND_IO_SPACE | \
> + EFI_PCI_COMMAND_MEMORY_SPACE))
I thought I asked you not to define a macro here that started with the
"EFI_" prefix :/
http://mid.mail-archive.com/dd8e3c9e-cb76-d3fe-6a10-c0a41c714b56@redhat.com
Laszlo
> +STATIC
> +VOID
> +PcatPciRootBridgeDecoding (
> + IN UINTN Address,
> + IN BOOLEAN Enabled,
> + OUT UINT16 *OriginalValue
> + )
> +{
> + UINT16 Value;
> +
> + //
> + // Preserve the original value
> + //
> + Value = *OriginalValue;
> + *OriginalValue = PciRead16 (Address);
> +
> + if (!Enabled) {
> + if (*OriginalValue & EFI_PCI_COMMAND_DECODE)
> + PciWrite16 (Address, *OriginalValue & ~EFI_PCI_COMMAND_DECODE);
> + } else {
> + if (Value & EFI_PCI_COMMAND_DECODE)
> + PciWrite16 (Address, Value);
> + }
> +}
> +
> STATIC
> VOID
> PcatPciRootBridgeParseBars (
> @@ -76,6 +103,7 @@ PcatPciRootBridgeParseBars (
> UINT32 Value;
> UINT32 OriginalUpperValue;
> UINT32 UpperValue;
> + UINT16 OriginalCommand;
> UINT64 Mask;
> UINTN Offset;
> UINT64 Base;
> @@ -83,6 +111,12 @@ PcatPciRootBridgeParseBars (
> UINT64 Limit;
> PCI_ROOT_BRIDGE_APERTURE *MemAperture;
>
> + // Disable address decoding for every device before OVMF starts sizing it
> + PcatPciRootBridgeDecoding (
> + PCI_LIB_ADDRESS (Bus, Device, Function, PCI_COMMAND_OFFSET),
> + FALSE, &OriginalCommand
> + );
> +
> for (Offset = BarOffsetBase; Offset < BarOffsetEnd; Offset += sizeof (UINT32)) {
> PcatPciRootBridgeBarExisted (
> PCI_LIB_ADDRESS (Bus, Device, Function, Offset),
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-03-06 13:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 12:40 [PATCH RESEND 0/3] Xen PCI passthrough fixes Igor Druzhinin
2019-03-06 12:40 ` [PATCH RESEND 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture Igor Druzhinin
2019-03-14 17:41 ` Anthony PERARD
2019-03-14 19:45 ` Igor Druzhinin
2019-03-19 14:03 ` Anthony PERARD
2019-03-20 11:15 ` Laszlo Ersek
2019-03-22 8:33 ` Roger Pau Monné
2019-03-22 9:06 ` Laszlo Ersek
[not found] ` <7b8b9559-6479-9ee0-5b5a-300b43606669@redhat.com>
2019-03-24 3:50 ` Roger Pau Monné
2019-03-25 14:32 ` Igor Druzhinin
2019-03-06 12:40 ` [PATCH RESEND 2/3] OvmfPkg/XenSupport: use a correct PCI host bridge aperture for BAR64 Igor Druzhinin
2019-03-14 17:44 ` Anthony PERARD
2019-03-06 12:40 ` [PATCH RESEND 3/3] OvmfPkg/XenSupport: turn off address decoding before BAR sizing Igor Druzhinin
2019-03-06 13:22 ` Laszlo Ersek [this message]
[not found] ` <e8cdf4a2-b02b-daa7-4301-803fb1e0086d@redhat.com>
2019-03-06 14:26 ` Igor Druzhinin
2019-03-06 17:39 ` Laszlo Ersek
2019-03-14 17:55 ` Anthony PERARD
2019-03-14 20:09 ` Igor Druzhinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e8cdf4a2-b02b-daa7-4301-803fb1e0086d__3872.08164190582$1551878633$gmane$org@redhat.com' \
--to=lersek@redhat.com \
--cc=anthony.perard@citrix.com \
--cc=ard.biesheuvel@linaro.org \
--cc=edk2-devel@lists.01.org \
--cc=igor.druzhinin@citrix.com \
--cc=jordan.l.justen@intel.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.