From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD99AC43381 for ; Sat, 16 Mar 2019 08:28:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CE17218D0 for ; Sat, 16 Mar 2019 08:28:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=AQUANTIA1COM.onmicrosoft.com header.i=@AQUANTIA1COM.onmicrosoft.com header.b="kLkt2uyk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726663AbfCPI2Y (ORCPT ); Sat, 16 Mar 2019 04:28:24 -0400 Received: from mail-eopbgr780041.outbound.protection.outlook.com ([40.107.78.41]:43296 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725970AbfCPI2X (ORCPT ); Sat, 16 Mar 2019 04:28:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E6/gOEzBqEH/l/rdNtQhQw+V4EaDnoN10CseXdewXyI=; b=kLkt2uyk1qL9JI3/jI683HAJywIMFuzmmAKyF+F8Dh0XXzUpIqxOD48GXQ1NOEYxF0Ug9RdVjODqeAtn1BfDwpmauW94Ma2RVCNmC+GvTOBiKZnuV9u0ELzMHtvXtJX5Jcxkzb0lSB6ikaF82QePJ5xkzAUeNu3mxhsDiM2v7Wo= Received: from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by DM6PR11MB3148.namprd11.prod.outlook.com (20.177.219.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Sat, 16 Mar 2019 08:28:19 +0000 Received: from DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b]) by DM6PR11MB3625.namprd11.prod.outlook.com ([fe80::d145:a1f4:ed34:e31b%3]) with mapi id 15.20.1709.011; Sat, 16 Mar 2019 08:28:19 +0000 From: Igor Russkikh To: "David S . Miller" CC: "netdev@vger.kernel.org" , Igor Russkikh , Nikita Danilov , Dmitry Bogdanov Subject: [PATCH net] net: aquantia: fix rx checksum offload for UDP/TCP over IPv6 Thread-Topic: [PATCH net] net: aquantia: fix rx checksum offload for UDP/TCP over IPv6 Thread-Index: AQHU29I1uCHXu9V0+U2ntQn+7v8qwA== Date: Sat, 16 Mar 2019 08:28:18 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HE1PR0101CA0016.eurprd01.prod.exchangelabs.com (2603:10a6:3:77::26) To DM6PR11MB3625.namprd11.prod.outlook.com (2603:10b6:5:13a::21) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [95.79.108.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5b8be373-e821-4919-0374-08d6a9e957e8 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);SRVR:DM6PR11MB3148; x-ms-traffictypediagnostic: DM6PR11MB3148: x-microsoft-antispam-prvs: x-forefront-prvs: 09781D4C35 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(346002)(396003)(376002)(136003)(366004)(39850400004)(199004)(189003)(5660300002)(107886003)(4326008)(2616005)(52116002)(99286004)(316002)(54906003)(71200400001)(66066001)(71190400001)(486006)(476003)(256004)(50226002)(3846002)(68736007)(118296001)(8936002)(6116002)(6436002)(44832011)(106356001)(36756003)(81166006)(2906002)(7736002)(81156014)(72206003)(25786009)(97736004)(53936002)(105586002)(6486002)(478600001)(8676002)(102836004)(6506007)(386003)(6346003)(14454004)(305945005)(186003)(86362001)(6512007)(6916009)(26005);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR11MB3148;H:DM6PR11MB3625.namprd11.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: aquantia.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Igor.Russkikh@aquantia.com; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: yE1lXoXoravHFqPiBrUxV/LwjDk6wNq0IzCG2SRK+awjyfoPXkWvXxyF8NOBn0riFbiTHslYoOzNdNE9tHSc1cKKQ9Uz3OYuBUYZ5Cgvbg4nTO+K+oblSHsWrMxcB5UP+jmZDI/1/qKAbFn0MSEGDrZf60YfmUWNoF+7hv8yx7CTMQqbjc8m/ao6Ngdahmr2vDFmtNuTNH0yv325TcmN2ST+JvVM0nVyr1DNC9vrka4v6oM9oxCEow5g7ZvFSzv0w8XLjMTX8/foRVBI3aP09p25pXOM9gckJ0EeYyrgVUXt6uafB+EMLmXtMy076lbbX9h5NyXFZEvOw1MFySr3bjrR935kK8h6sVq12TNBHE0Dp8FJ0xPXu+ZoxCi1AS/nSV3lzB+qz5reZjiercFXyAD8OcdidNN5lrmaWRcDTkc= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: aquantia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b8be373-e821-4919-0374-08d6a9e957e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Mar 2019 08:28:18.9943 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 83e2e134-991c-4ede-8ced-34d47e38e6b1 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3148 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dmitry Bogdanov TCP/UDP checksum validity was propagated to skb only if IP checksum is valid. But for IPv6 there is no validity as there is no checksum in IPv6. This patch propagates TCP/UDP checksum validity regardless of IP checksum. Fixes: 018423e90bee ("net: ethernet: aquantia: Add ring support code") Signed-off-by: Igor Russkikh Signed-off-by: Nikita Danilov Signed-off-by: Dmitry Bogdanov --- drivers/net/ethernet/aquantia/atlantic/aq_ring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c b/drivers/net= /ethernet/aquantia/atlantic/aq_ring.c index 74550ccc7a20..e2ffb159cbe2 100644 --- a/drivers/net/ethernet/aquantia/atlantic/aq_ring.c +++ b/drivers/net/ethernet/aquantia/atlantic/aq_ring.c @@ -186,11 +186,12 @@ static void aq_rx_checksum(struct aq_ring_s *self, } if (buff->is_ip_cso) { __skb_incr_checksum_unnecessary(skb); - if (buff->is_udp_cso || buff->is_tcp_cso) - __skb_incr_checksum_unnecessary(skb); } else { skb->ip_summed =3D CHECKSUM_NONE; } + + if (buff->is_udp_cso || buff->is_tcp_cso) + __skb_incr_checksum_unnecessary(skb); } =20 #define AQ_SKB_ALIGN SKB_DATA_ALIGN(sizeof(struct skb_shared_info)) --=20 2.17.1