All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Christoph Hellwig <hch@lst.de>, Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: David Sterba <dsterba@suse.com>,
	Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
	linux-btrfs@vger.kernel.org
Subject: Re: cleanup btrfs bio handling, part 2 v3
Date: Thu, 12 May 2022 12:00:52 +0530	[thread overview]
Message-ID: <eb6a263a-0b5a-e5f1-04a1-4448d536e7a5@oracle.com> (raw)
In-Reply-To: <dfdec676-66fb-c746-7fbb-d9133cb29377@oracle.com>



On 5/12/22 11:52, Anand Jain wrote:
> On 5/5/22 20:41, Christoph Hellwig wrote:
>> On Thu, May 05, 2022 at 02:56:49PM +0800, Qu Wenruo wrote:
>>> So do you mind to do some basic benchmark for read and write and see how
>>> the throughput and latency changed?
> 
> 
>> I'm not actually seeing any meaningful differences at all.  I think this
>> will help btrfs to better behave under memory pressure, though.
> This patch got me curious a couple of days back while I was tracing a
> dio read performance issue on nvme.
> 
> Yep. No meaningful difference. I am sharing the results as below. [1].
> 
> [1]
> Before:
>   4971MB/s 4474GB iocounts: nvme3n1 545220968 nvme0n1 547007640 
> single_d2/5.18.0-rc5+_misc-next_1
> 
> After:
>   4968MB/s 4471GB iocounts: nvme3n1 544207371 nvme1n1 547458037 
> single_d2/5.18.0-rc5+_dio_cleanup_hch_1
> 
>   readstat /btrfs fio --eta=auto --output=$CMDLOG \
> --name fiotest --directory=/btrfs --rw=randread \
> --bs=4k --size=4G --ioengine=libaio --iodepth=16 --direct=1 \
> --time_based=1 --runtime=900 --randrepeat=1 --gtod_reduce=1 \
> --group_reporting=1 --numjobs=64

  Oops wrong thread pls ignore.


  reply	other threads:[~2022-05-12  6:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 12:25 cleanup btrfs bio handling, part 2 v3 Christoph Hellwig
2022-05-04 12:25 ` [PATCH 01/10] btrfs: don't double-defer bio completions for compressed reads Christoph Hellwig
2022-05-04 12:25 ` [PATCH 02/10] btrfs: move more work into btrfs_end_bioc Christoph Hellwig
2022-05-04 12:25 ` [PATCH 03/10] btrfs: cleanup btrfs_submit_dio_bio Christoph Hellwig
2022-05-04 12:25 ` [PATCH 04/10] btrfs: split btrfs_submit_data_bio Christoph Hellwig
2022-05-04 12:38   ` Qu Wenruo
2022-05-04 14:08     ` Christoph Hellwig
2022-05-04 22:41       ` Qu Wenruo
2022-05-04 22:44         ` Qu Wenruo
2022-05-05 15:08         ` Christoph Hellwig
2022-05-04 12:25 ` [PATCH 05/10] btrfs: defer I/O completion based on the btrfs_raid_bio Christoph Hellwig
2022-05-04 12:25 ` [PATCH 06/10] btrfs: don't use btrfs_bio_wq_end_io for compressed writes Christoph Hellwig
2022-05-11 19:20   ` Nikolay Borisov
2022-05-11 19:28     ` Nikolay Borisov
2022-05-12  5:56       ` Christoph Hellwig
2022-05-04 12:25 ` [PATCH 07/10] btrfs: centralize setting REQ_META Christoph Hellwig
2022-05-04 12:25 ` [PATCH 08/10] btrfs: remove btrfs_end_io_wq Christoph Hellwig
2022-05-05  2:34   ` Qu Wenruo
2022-05-05 15:09     ` Christoph Hellwig
2022-05-04 12:25 ` [PATCH 09/10] btrfs: refactor btrfs_map_bio Christoph Hellwig
2022-05-04 12:46   ` Qu Wenruo
2022-05-04 12:25 ` [PATCH 10/10] btrfs: do not allocate a btrfs_bio for low-level bios Christoph Hellwig
2022-05-05 11:23   ` Qu Wenruo
2022-05-05  6:56 ` cleanup btrfs bio handling, part 2 v3 Qu Wenruo
2022-05-05 15:11   ` Christoph Hellwig
2022-05-12  6:22     ` Anand Jain
2022-05-12  6:30       ` Anand Jain [this message]
2022-05-05 15:34   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb6a263a-0b5a-e5f1-04a1-4448d536e7a5@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.com \
    --cc=hch@lst.de \
    --cc=josef@toxicpanda.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.