All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Stefan Riedmüller" <s.riedmueller@phytec.de>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: s.christ@phytec.de, chf.fritz@googlemail.com, robh+dt@kernel.org,
	linux-imx@nxp.com, kernel@pengutronix.de, c.hemp@phytec.de,
	shawnguo@kernel.org, festevam@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage
Date: Mon, 2 Dec 2019 11:09:57 +0100	[thread overview]
Message-ID: <ec29daf9-d87f-276f-2927-da66b153840f@phytec.de> (raw)
In-Reply-To: <20191129164859.15632-1-m.felsch@pengutronix.de>

Hi Marco,

your proposed setting is only valid for the LDO enabled case but not for the 
case where the LDO's are in bypass mode. Is that intended? In bypass mode it 
actually needs to be 0.925 V min for ARM and 1.15 V min for SOC.

Did you experience an issue with the current settings or is this just a 
cosmetic change?

Regards,
Stefan


On 29.11.19 17:48, Marco Felsch wrote:
> The current set minimum voltage of 730000mV seems to be wrong. I don't
> know the document which specifies that but the imx6qdl datasheets says
> that the minimum voltage should be 1.05V for VDD_ARM (LDO enabled, lowest
> opp) and 1.275V for VDD_SOC (LDO enabled, lowest opp).
> 
> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>   arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> index 6486df3e2942..46d4953c5588 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi
> @@ -107,14 +107,14 @@
>   		regulators {
>   			vdd_arm: buck1 {
>   				regulator-name = "vdd_arm";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <1050000>;
>   				regulator-max-microvolt = <1380000>;
>   				regulator-always-on;
>   			};
>   
>   			vdd_soc: buck2 {
>   				regulator-name = "vdd_soc";
> -				regulator-min-microvolt = <730000>;
> +				regulator-min-microvolt = <1275000>;
>   				regulator-max-microvolt = <1380000>;
>   				regulator-always-on;
>   			};
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-02 10:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 16:48 [PATCH 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2019-11-29 16:48 ` [PATCH 2/3] ARM: dts: imx6: phycore-som: fix emmc supply Marco Felsch
2019-12-05 12:00   ` Stefan Riedmüller
2019-12-10  9:09     ` Marco Felsch
2019-12-12  9:00       ` Stefan Riedmüller
2019-11-29 16:48 ` [PATCH 3/3] ARM: dts: imx6: phycore-som: add pmic onkey device Marco Felsch
2020-01-07 13:48   ` Marco Felsch
2020-01-09  6:46   ` Shawn Guo
2019-12-02 10:09 ` Stefan Riedmüller [this message]
2019-12-02 12:42   ` [PATCH 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Marco Felsch
2019-12-02 13:55     ` Stefan Riedmüller
2019-12-02 14:14       ` Marco Felsch
2019-12-02 14:30         ` Stefan Riedmüller
2019-12-02 14:53           ` Marco Felsch
2019-12-03  8:11             ` Stefan Riedmüller
2019-12-03  8:33               ` Marco Felsch
2019-12-03  9:07                 ` Stefan Riedmüller
2019-12-03 11:44                 ` Lucas Stach
2019-12-03 12:37                   ` Stefan Riedmüller
2019-12-05  7:19                     ` Marco Felsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec29daf9-d87f-276f-2927-da66b153840f@phytec.de \
    --to=s.riedmueller@phytec.de \
    --cc=c.hemp@phytec.de \
    --cc=chf.fritz@googlemail.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=m.felsch@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.christ@phytec.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.