Re: [cocci] Searching for special function implementations with SmPL

[Luca Coelho <luca@coelho.fi>]

On Sat, 2023-01-28 at 14:43 +0100, Markus Elfring wrote:
> > @@
> > identifier nested_macros.nm;
> > identifier dev_priv, f;
> > expression e;
> > @@
> > f(...) {
> > 	...
> > -	struct drm_i915_private *dev_priv = e;
> > +	struct drm_i915_private *i915 = e;
> > 
> > 	<+...
> > 	nm(...)
> > 	...+>
> > }
> 
> 
> You would like to rename a local variable.
> How do you think about to check if the chosen variable name will
> actually be used?
> 
> 
> 
> > +++ b/intel_display.c
> > @@ -3943,7 +3943,7 @@ static bool bxt_get_dsi_transcoder_state
> >  					 struct
> > intel_display_power_domain_set *power_domain_set)
> >  {
> >  	struct drm_device *dev = crtc->base.dev;
> > -	struct drm_i915_private *dev_priv = to_i915(dev);
> > +	struct drm_i915_private *i915 = to_i915(dev);
> >  	enum transcoder cpu_transcoder;
> >  	enum port port;
> >  	u32 tmp;
> 
> Which function-like macros should be found in such an implementation?
> https://elixir.bootlin.com/linux/v6.2-
> rc5/source/drivers/gpu/drm/i915/display/intel_display.c#L3991
> 
> 
> 
> > Many other files are handled, but there are no matches, though I
> > believe there should be.
> 
> Would you like to split the SmPL search patterns for another test
> so that your expectations can be clarified better?

Hi Markus,

Thanks for all the input.  I explained what I want to do (hopefully) a
bit more clearly in reply to Julia's latest email.

--
Cheers,
Luca.