From: Hans de Goede <hdegoede@redhat.com>
To: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Bard Liao <bardliao@realtek.com>,
Oder Chiou <oder_chiou@realtek.com>
Cc: Tanu Kaskinen <tanuk@iki.fi>,
alsa-devel@alsa-project.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH 0/6] ASoC: rt5651: Various fixes and quirks
Date: Mon, 24 Dec 2018 15:15:00 +0100 [thread overview]
Message-ID: <ed06b29d-5677-5044-2e0a-d7f3a50d2498@redhat.com> (raw)
In-Reply-To: <20180718205542.12364-1-hdegoede@redhat.com>
Hi all,
On 18-07-18 22:55, Hans de Goede wrote:
<snip>
> Note that unfortunately my previous round of cleanup patches removed
> 1 input mapping (of the 3 mappings in total it removed) which is
> actually necessary. So this series re-introduces that 1 mapping. I did
> not notice this before because UCM input profile switching does not work
> reliably for some reason, something which I still need to investigate.
While doing some bytcr_rt5651 work this weekend (the x86 ASoC work I
do is a spare time project for me) I hit this again, so this time
I've spend some time getting to the bottom of this. The cause is a
pulseaudio bug, where pulseaudio uses a strncmp without first
checking the lengths of the 2 strings match, causing it to see
selecting the "InternalMic-IN1" UCM device as selecting both the
"InternalMic-IN1" and the "InternalMic-IN12" device.
A pull-req fixing this is here:
https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/40
Regards,
Hans
prev parent reply other threads:[~2018-12-24 14:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 20:55 [PATCH 0/6] ASoC: rt5651: Various fixes and quirks Hans de Goede
2018-07-18 20:55 ` [PATCH 1/6] ASoC: rt5651: Add IN3 Boost volume control Hans de Goede
2018-07-19 15:02 ` Mark Brown
2018-07-20 1:31 ` Bard Liao
2018-07-20 1:40 ` Pierre-Louis Bossart
2018-07-20 2:53 ` Bard Liao
2018-07-27 12:01 ` Hans de Goede
2018-07-30 1:58 ` Bard Liao
2018-07-30 8:28 ` Mark Brown
2018-07-19 16:57 ` Applied "ASoC: rt5651: Add IN3 Boost volume control" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 2/6] ASoC: Intel: bytcr_rt5651: Fix using the wrong GPIO for the ext-amp on some boards Hans de Goede
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Fix using the wrong GPIO for the ext-amp on some boards" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 3/6] ASoC: Intel: bytcr_rt5651: Set OVCD limit for VIOS LTH17 to 2000uA Hans de Goede
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Set OVCD limit for VIOS LTH17 to 2000uA" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 4/6] ASoC: Intel: bytcr_rt5651: Add IN2 input mapping Hans de Goede
2018-07-18 21:20 ` Pierre-Louis Bossart
2018-07-19 11:37 ` Hans de Goede
2018-07-19 13:08 ` Pierre-Louis Bossart
2018-07-19 16:57 ` Applied "ASoC: Intel: bytcr_rt5651: Add IN2 input mapping" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 5/6] ASoC: Intel: bytcr_rt5651: Add mono speaker quirk Hans de Goede
2018-07-19 16:56 ` Applied "ASoC: Intel: bytcr_rt5651: Add mono speaker quirk" to the asoc tree Mark Brown
2018-07-18 20:55 ` [PATCH 6/6] ASoC: Intel: bytcr_rt5651: Add quirk table entries for various devices Hans de Goede
2018-07-19 16:56 ` Applied "ASoC: Intel: bytcr_rt5651: Add quirk table entries for various devices" to the asoc tree Mark Brown
2018-12-24 14:15 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed06b29d-5677-5044-2e0a-d7f3a50d2498@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=carlo@endlessm.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=oder_chiou@realtek.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tanuk@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.