From: Corneliu ZUZU <czuzu@bitdefender.com>
To: Julien Grall <julien.grall@arm.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v4 1/7] asm-arm/atomic.h: fix arm32|arm64 macros duplication
Date: Fri, 15 Jul 2016 13:17:55 +0300 [thread overview]
Message-ID: <ee2c7a1f-9abf-a463-6299-b2001d20cdc1@bitdefender.com> (raw)
In-Reply-To: <5788B5A8.1050701@arm.com>
On 7/15/2016 1:06 PM, Julien Grall wrote:
>
>
> On 15/07/16 10:55, Corneliu ZUZU wrote:
>> On 7/15/2016 12:28 PM, Julien Grall wrote:
>>> Hi Corneliu,
>>>
>>> On 15/07/16 07:48, Corneliu ZUZU wrote:
>>>> Move duplicate macros between asm-arm/arm32/atomic.h and
>>>> asm-arm/arm64/atomic.h
>>>> to asm-arm/atomic.h. Adjust README.LinuxPrimitives in the process.
>>>> Also empty line fixes.
>>>
>>> Why do you add empty lines?
>>
>> A little picky today, aren't we? :-)
>
> Same as usual ;).
>
> [...]
>
>>> They are not necessary nor coding style requirement nor in Linux
>>> headers. Please don't introduce changes without a valid reason.
>>
>> I just peeked in the Linux source tree and I noticed there are also
>> headers there with an empty line between the file-comment and #ifndef.
>> Plus, this is the Xen code-base and I don't see why I'd look in the
>> Linux source tree to determine rules that apply to the Xen source-tree.
>
> Because files taken from Linux respect Linux coding style.
>
> I did the mistake on other files to diverge (such as the SMMU code)
> and it was a pain to re-sync it later. So I prefer to have a strict
> rule on it, even for cosmetic changes.
>
> Regards,
Makes sense and much better than "Please don't introduce changes without
a valid reason". ;-)
Corneliu.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-15 10:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 6:47 [PATCH v4 0/7] <asm/atomic.h> adjustments Corneliu ZUZU
2016-07-15 6:48 ` [PATCH v4 1/7] asm-arm/atomic.h: fix arm32|arm64 macros duplication Corneliu ZUZU
2016-07-15 9:28 ` Julien Grall
2016-07-15 9:55 ` Corneliu ZUZU
2016-07-15 10:06 ` Julien Grall
2016-07-15 10:17 ` Corneliu ZUZU [this message]
2016-07-15 6:48 ` [PATCH v4 2/7] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement Corneliu ZUZU
2016-07-15 6:49 ` [PATCH v4 3/7] asm-arm/atomic.h: reorder macros to match x86-side Corneliu ZUZU
2016-07-15 9:28 ` Julien Grall
2016-07-15 6:50 ` [PATCH v4 4/7] asm/atomic.h: common prototyping (add xen/atomic.h) Corneliu ZUZU
2016-07-15 9:30 ` Julien Grall
2016-07-15 9:59 ` Corneliu ZUZU
2016-07-15 6:50 ` [PATCH v4 5/7] xen/atomic.h: fix: make atomic_read() param const Corneliu ZUZU
2016-07-15 9:31 ` Julien Grall
2016-07-15 6:51 ` [PATCH v4 6/7] asm-arm/atomic.h: atomic_{inc, dec}_return: macros to inline functions Corneliu ZUZU
2016-07-15 6:59 ` Corneliu ZUZU
2016-07-15 6:52 ` [PATCH v4 7/7] asm/atomic.h: implement missing and add common prototypes Corneliu ZUZU
2016-07-15 9:34 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2c7a1f-9abf-a463-6299-b2001d20cdc1@bitdefender.com \
--to=czuzu@bitdefender.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.