From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF713C433FE for ; Thu, 31 Mar 2022 07:20:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbiCaHW3 (ORCPT ); Thu, 31 Mar 2022 03:22:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231246AbiCaHW2 (ORCPT ); Thu, 31 Mar 2022 03:22:28 -0400 Received: from mail-m176237.qiye.163.com (mail-m176237.qiye.163.com [59.111.176.237]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87CCF1E31A7 for ; Thu, 31 Mar 2022 00:20:40 -0700 (PDT) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id B1807C402A9; Thu, 31 Mar 2022 15:20:37 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 15:20:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220331070614.GD4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDHxlWQxlITUpDTk kfT0odVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OBA6ITo5CD4BIw4SGEo*OjQp Dk5PChJVSlVKTU9DTEpKSUhDTUhJVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTkhITzcG X-HM-Tid: 0a7fded902bbd9afkuwsb1807c402a9 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Sascha: On 3/31/22 15:06, Sascha Hauer wrote: > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: >> Hi Sascha: >> >> On 3/30/22 14:39, Sascha Hauer wrote: >>> Hi Andy, >>> >>> On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: >>>> Hi Sascha: >>>> >>>> On 3/28/22 23:11, Sascha Hauer wrote: >>>>> With upcoming VOP2 support VOP won't be the only choice anymore, so make >>>>> the VOP driver optional. >>>>> >>>>> Signed-off-by: Sascha Hauer >>>>> --- >>>>> drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ >>>>> drivers/gpu/drm/rockchip/Makefile | 3 ++- >>>>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- >>>>> 3 files changed, 11 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig >>>>> index fa5cfda4e90e3..7d22e2997a571 100644 >>>>> --- a/drivers/gpu/drm/rockchip/Kconfig >>>>> +++ b/drivers/gpu/drm/rockchip/Kconfig >>>>> @@ -23,8 +23,16 @@ config DRM_ROCKCHIP >>>>> if DRM_ROCKCHIP >>>>> +config ROCKCHIP_VOP >>>>> + bool "Rockchip VOP driver" >>>>> + default y >>>>> + help >>>>> + This selects support for the VOP driver. You should enable it >>>>> + on all older SoCs up to RK3399. >>> That reminds me that I wanted to rephrase this. Will change in next >>> round. >>> >>>>> + >>>>> config ROCKCHIP_ANALOGIX_DP >>>>> bool "Rockchip specific extensions for Analogix DP driver" >>>>> + depends on ROCKCHIP_VOP >>>> Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. > BTW I just looked at the downstream driver. Here we have the same > situation that the analogix dp driver calls rockchip_drm_wait_vact_end() > which is implemented in the VOP driver, so when the analogix dp driver > is actually used on a VOP2 SoC then it is either used in a way that > rockchip_drm_wait_vact_end() will never be called or it explodes in all > colours. > >>> I added the dependency because analogix_dp-rockchip.c calls >>> rockchip_drm_wait_vact_end() which is implemented in the VOP driver, >>> so this driver currenty can't work with the VOP2 driver and can't >>> be linked without the VOP driver being present. >>> I'll add a few words to the commit message. >> >> Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP >> driver to rockchip_drm_drv.c > I am not sure if that's really worth it. Yes, the direction might be the > right one, but I would really prefer when somebody does the change who > can test and confirm that the analogix dp really works with VOP2 in the > end. If follow this point, the current DW_MIPI also has not been tested for confirm that it can really work with VOP2, so you should also make it depends on ROCKCHIP_VOP. I think the current solution is just a workaround to make your patch pass the kernel compile but not reflect the real situation. > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 286F2C433F5 for ; Thu, 31 Mar 2022 07:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6GenjLQTkaQIp4Jzb6jtXYmgtZf5Bord5ZNypMbwayY=; b=BdvUfMShix336G hTEgNBYy3XFESSCwgAVQOCzKw6X0ybl2nU5YUJXvw/5sHj/7WPUsg6DE1c3zFT2hYkiRANP06fRAF MOUYRHBLxGDSTmg7Ob+kcAOtzcznEK6uc546dT0W7q9qkF9LkeoFlRB7+KJhuK5Y1u2hYnG07x9XP xoZ8FKDDMX578dps7jc5oPHkT1zI4ZzJBreBO53csvtp5d903MmbrQ8Sf67P/6VaJ3hI1/jmYG+AW rYwhu5R4VMMOy5712zgSpX1d130OrunBFFB3nxAvaMOnArbG/DDPnC2eL1bOMZN5+RkYEuyoG1pCu AeKatD+cY06LQPSrPtPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZp75-0013MJ-UK; Thu, 31 Mar 2022 07:20:59 +0000 Received: from mail-m176237.qiye.163.com ([59.111.176.237]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZp6o-0013Fb-Oi; Thu, 31 Mar 2022 07:20:44 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id B1807C402A9; Thu, 31 Mar 2022 15:20:37 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 15:20:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220331070614.GD4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDHxlWQxlITUpDTk kfT0odVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OBA6ITo5CD4BIw4SGEo*OjQp Dk5PChJVSlVKTU9DTEpKSUhDTUhJVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTkhITzcG X-HM-Tid: 0a7fded902bbd9afkuwsb1807c402a9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_002043_002320_CD4B9A41 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhOgoKT24gMy8zMS8yMiAxNTowNiwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+IE9uIFdl ZCwgTWFyIDMwLCAyMDIyIGF0IDA4OjUwOjA5UE0gKzA4MDAsIEFuZHkgWWFuIHdyb3RlOgo+PiBI aSBTYXNjaGE6Cj4+Cj4+IE9uIDMvMzAvMjIgMTQ6MzksIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+ IEhpIEFuZHksCj4+Pgo+Pj4gT24gVHVlLCBNYXIgMjksIDIwMjIgYXQgMDc6NTY6MjdQTSArMDgw MCwgQW5keSBZYW4gd3JvdGU6Cj4+Pj4gSGkgU2FzY2hhOgo+Pj4+Cj4+Pj4gT24gMy8yOC8yMiAy MzoxMSwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4+PiBXaXRoIHVwY29taW5nIFZPUDIgc3VwcG9y dCBWT1Agd29uJ3QgYmUgdGhlIG9ubHkgY2hvaWNlIGFueW1vcmUsIHNvIG1ha2UKPj4+Pj4gdGhl IFZPUCBkcml2ZXIgb3B0aW9uYWwuCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFNhc2NoYSBI YXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4KPj4+Pj4gLS0tCj4+Pj4+ICAgICBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvS2NvbmZpZyAgICAgICAgICAgIHwgOCArKysrKysrKwo+Pj4+PiAg ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL01ha2VmaWxlICAgICAgICAgICB8IDMgKystCj4+ Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIHwgMiAr LQo+Pj4+PiAgICAgMyBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tj b25maWcgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvS2NvbmZpZwo+Pj4+PiBpbmRleCBmYTVj ZmRhNGU5MGUzLi43ZDIyZTI5OTdhNTcxIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvS2NvbmZpZwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv S2NvbmZpZwo+Pj4+PiBAQCAtMjMsOCArMjMsMTYgQEAgY29uZmlnIERSTV9ST0NLQ0hJUAo+Pj4+ PiAgICAgaWYgRFJNX1JPQ0tDSElQCj4+Pj4+ICtjb25maWcgUk9DS0NISVBfVk9QCj4+Pj4+ICsJ Ym9vbCAiUm9ja2NoaXAgVk9QIGRyaXZlciIKPj4+Pj4gKwlkZWZhdWx0IHkKPj4+Pj4gKwloZWxw Cj4+Pj4+ICsJICBUaGlzIHNlbGVjdHMgc3VwcG9ydCBmb3IgdGhlIFZPUCBkcml2ZXIuIFlvdSBz aG91bGQgZW5hYmxlIGl0Cj4+Pj4+ICsJICBvbiBhbGwgb2xkZXIgU29DcyB1cCB0byBSSzMzOTku Cj4+PiBUaGF0IHJlbWluZHMgbWUgdGhhdCBJIHdhbnRlZCB0byByZXBocmFzZSB0aGlzLiBXaWxs IGNoYW5nZSBpbiBuZXh0Cj4+PiByb3VuZC4KPj4+Cj4+Pj4+ICsKPj4+Pj4gICAgIGNvbmZpZyBS T0NLQ0hJUF9BTkFMT0dJWF9EUAo+Pj4+PiAgICAgCWJvb2wgIlJvY2tjaGlwIHNwZWNpZmljIGV4 dGVuc2lvbnMgZm9yIEFuYWxvZ2l4IERQIGRyaXZlciIKPj4+Pj4gKwlkZXBlbmRzIG9uIFJPQ0tD SElQX1ZPUAo+Pj4+IEFhbmxvZ2l4IGRwIGlzIGFsc28gb24gdm9wMiBiYXNlIHNvYyBzdWNoIGFz wqAgcmszNTZ4IGFuZCByazM1ODguCj4gQlRXIEkganVzdCBsb29rZWQgYXQgdGhlIGRvd25zdHJl YW0gZHJpdmVyLiBIZXJlIHdlIGhhdmUgdGhlIHNhbWUKPiBzaXR1YXRpb24gdGhhdCB0aGUgYW5h bG9naXggZHAgZHJpdmVyIGNhbGxzIHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkKPiB3aGlj aCBpcyBpbXBsZW1lbnRlZCBpbiB0aGUgVk9QIGRyaXZlciwgc28gd2hlbiB0aGUgYW5hbG9naXgg ZHAgZHJpdmVyCj4gaXMgYWN0dWFsbHkgdXNlZCBvbiBhIFZPUDIgU29DIHRoZW4gaXQgaXMgZWl0 aGVyIHVzZWQgaW4gYSB3YXkgdGhhdAo+IHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkgd2ls bCBuZXZlciBiZSBjYWxsZWQgb3IgaXQgZXhwbG9kZXMgaW4gYWxsCj4gY29sb3Vycy4KPgo+Pj4g SSBhZGRlZCB0aGUgZGVwZW5kZW5jeSBiZWNhdXNlIGFuYWxvZ2l4X2RwLXJvY2tjaGlwLmMgY2Fs bHMKPj4+IHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkgd2hpY2ggaXMgaW1wbGVtZW50ZWQg aW4gdGhlIFZPUCBkcml2ZXIsCj4+PiBzbyB0aGlzIGRyaXZlciBjdXJyZW50eSBjYW4ndCB3b3Jr IHdpdGggdGhlIFZPUDIgZHJpdmVyIGFuZCBjYW4ndAo+Pj4gYmUgbGlua2VkIHdpdGhvdXQgdGhl IFZPUCBkcml2ZXIgYmVpbmcgcHJlc2VudC4KPj4+IEknbGwgYWRkIGEgZmV3IHdvcmRzIHRvIHRo ZSBjb21taXQgbWVzc2FnZS4KPj4KPj4gTWF5YmUgYSBiZXR0ZXIgZGlyZWN0aW9uIGlzIG1vdmUg cm9ja2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQgZnJvbSB0aGUgVk9QCj4+IGRyaXZlciB0byByb2Nr Y2hpcF9kcm1fZHJ2LmMKPiBJIGFtIG5vdCBzdXJlIGlmIHRoYXQncyByZWFsbHkgd29ydGggaXQu IFllcywgdGhlIGRpcmVjdGlvbiBtaWdodCBiZSB0aGUKPiByaWdodCBvbmUsIGJ1dCBJIHdvdWxk IHJlYWxseSBwcmVmZXIgd2hlbiBzb21lYm9keSBkb2VzIHRoZSBjaGFuZ2Ugd2hvCj4gY2FuIHRl c3QgYW5kIGNvbmZpcm0gdGhhdCB0aGUgYW5hbG9naXggZHAgcmVhbGx5IHdvcmtzIHdpdGggVk9Q MiBpbiB0aGUKPiBlbmQuCgpJZiBmb2xsb3cgdGhpcyBwb2ludCwgdGhlIGN1cnJlbnQgRFdfTUlQ SSBhbHNvIGhhcyBub3QgYmVlbiB0ZXN0ZWQgZm9yIApjb25maXJtIHRoYXQgaXQKCmNhbiByZWFs bHkgd29yayB3aXRoIFZPUDIsIHNvIHlvdSBzaG91bGQgYWxzbyBtYWtlIGl0IGRlcGVuZHMgb24g ClJPQ0tDSElQX1ZPUC4KCkkgdGhpbmsgdGhlIGN1cnJlbnQgc29sdXRpb24gaXMganVzdCBhIHdv cmthcm91bmQgdG8gbWFrZSB5b3VyIHBhdGNoIApwYXNzIHRoZSBrZXJuZWwgY29tcGlsZQoKYnV0 IG5vdCByZWZsZWN0IHRoZSByZWFsIHNpdHVhdGlvbi4KCj4gU2FzY2hhCj4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52C24C433F5 for ; Thu, 31 Mar 2022 07:20:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 820CA10F4F3; Thu, 31 Mar 2022 07:20:42 +0000 (UTC) Received: from mail-m176237.qiye.163.com (mail-m176237.qiye.163.com [59.111.176.237]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55BD410F4F3 for ; Thu, 31 Mar 2022 07:20:41 +0000 (UTC) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id B1807C402A9; Thu, 31 Mar 2022 15:20:37 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 15:20:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220331070614.GD4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDHxlWQxlITUpDTk kfT0odVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OBA6ITo5CD4BIw4SGEo*OjQp Dk5PChJVSlVKTU9DTEpKSUhDTUhJVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTkhITzcG X-HM-Tid: 0a7fded902bbd9afkuwsb1807c402a9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, Kever Yang , linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sascha: On 3/31/22 15:06, Sascha Hauer wrote: > On Wed, Mar 30, 2022 at 08:50:09PM +0800, Andy Yan wrote: >> Hi Sascha: >> >> On 3/30/22 14:39, Sascha Hauer wrote: >>> Hi Andy, >>> >>> On Tue, Mar 29, 2022 at 07:56:27PM +0800, Andy Yan wrote: >>>> Hi Sascha: >>>> >>>> On 3/28/22 23:11, Sascha Hauer wrote: >>>>> With upcoming VOP2 support VOP won't be the only choice anymore, so make >>>>> the VOP driver optional. >>>>> >>>>> Signed-off-by: Sascha Hauer >>>>> --- >>>>> drivers/gpu/drm/rockchip/Kconfig | 8 ++++++++ >>>>> drivers/gpu/drm/rockchip/Makefile | 3 ++- >>>>> drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 2 +- >>>>> 3 files changed, 11 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig >>>>> index fa5cfda4e90e3..7d22e2997a571 100644 >>>>> --- a/drivers/gpu/drm/rockchip/Kconfig >>>>> +++ b/drivers/gpu/drm/rockchip/Kconfig >>>>> @@ -23,8 +23,16 @@ config DRM_ROCKCHIP >>>>> if DRM_ROCKCHIP >>>>> +config ROCKCHIP_VOP >>>>> + bool "Rockchip VOP driver" >>>>> + default y >>>>> + help >>>>> + This selects support for the VOP driver. You should enable it >>>>> + on all older SoCs up to RK3399. >>> That reminds me that I wanted to rephrase this. Will change in next >>> round. >>> >>>>> + >>>>> config ROCKCHIP_ANALOGIX_DP >>>>> bool "Rockchip specific extensions for Analogix DP driver" >>>>> + depends on ROCKCHIP_VOP >>>> Aanlogix dp is also on vop2 base soc such as  rk356x and rk3588. > BTW I just looked at the downstream driver. Here we have the same > situation that the analogix dp driver calls rockchip_drm_wait_vact_end() > which is implemented in the VOP driver, so when the analogix dp driver > is actually used on a VOP2 SoC then it is either used in a way that > rockchip_drm_wait_vact_end() will never be called or it explodes in all > colours. > >>> I added the dependency because analogix_dp-rockchip.c calls >>> rockchip_drm_wait_vact_end() which is implemented in the VOP driver, >>> so this driver currenty can't work with the VOP2 driver and can't >>> be linked without the VOP driver being present. >>> I'll add a few words to the commit message. >> >> Maybe a better direction is move rockchip_drm_wait_vact_end from the VOP >> driver to rockchip_drm_drv.c > I am not sure if that's really worth it. Yes, the direction might be the > right one, but I would really prefer when somebody does the change who > can test and confirm that the analogix dp really works with VOP2 in the > end. If follow this point, the current DW_MIPI also has not been tested for confirm that it can really work with VOP2, so you should also make it depends on ROCKCHIP_VOP. I think the current solution is just a workaround to make your patch pass the kernel compile but not reflect the real situation. > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3B19C433EF for ; Thu, 31 Mar 2022 07:22:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Do42Wmr/qhfPtG7rTKB/1iDn6/DQg2DZ/B8R77PfM9s=; b=O75VB3sfQHhJfj EfigR4GcKRPcUSXRLP1nm0aWguFCCC9Zwr90VoCigXuFrokvBIfE0TvZWVtjjaX0mSIZar27tq5UB 2IifmCx6LzJsfu0lQNiwCT9uuNWiBBs/MINDA5L68ICsDXdaK6SeU0FfPSSV79oC+u4/WAT8MMaCr nr2IDDnUe2kDwhjWOmkGsHfpKk6Ffyi/aUXZfAkcEEy/QCbCV95dg0FTeGom0LdOIRDg4tKHG3EXa eduZ4q+NHVRUy1ChExqJCS30wSdtfN1lgKX+0qp9u/fkz3MLktWL9mVy8YHvvT2gQTA71mGXiwMym jqoGFiWCJLd6ikDMqoFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZp6t-0013Hw-O6; Thu, 31 Mar 2022 07:20:47 +0000 Received: from mail-m176237.qiye.163.com ([59.111.176.237]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZp6o-0013Fb-Oi; Thu, 31 Mar 2022 07:20:44 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m176237.qiye.163.com (Hmail) with ESMTPA id B1807C402A9; Thu, 31 Mar 2022 15:20:37 +0800 (CST) Message-ID: Date: Thu, 31 Mar 2022 15:20:37 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v9 20/23] drm/rockchip: Make VOP driver optional Content-Language: en-US To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis , Kever Yang References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220328151116.2034635-21-s.hauer@pengutronix.de> <274a12a9-61f1-7d6a-e89c-52237621930b@rock-chips.com> <20220330063913.GW12181@pengutronix.de> <9619ce71-db59-d6cd-c254-2b67122fa245@rock-chips.com> <20220331070614.GD4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220331070614.GD4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlDHxlWQxlITUpDTk kfT0odVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktITUpVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OBA6ITo5CD4BIw4SGEo*OjQp Dk5PChJVSlVKTU9DTEpKSUhDTUhJVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTkhITzcG X-HM-Tid: 0a7fded902bbd9afkuwsb1807c402a9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_002043_002320_CD4B9A41 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2FzY2hhOgoKT24gMy8zMS8yMiAxNTowNiwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+IE9uIFdl ZCwgTWFyIDMwLCAyMDIyIGF0IDA4OjUwOjA5UE0gKzA4MDAsIEFuZHkgWWFuIHdyb3RlOgo+PiBI aSBTYXNjaGE6Cj4+Cj4+IE9uIDMvMzAvMjIgMTQ6MzksIFNhc2NoYSBIYXVlciB3cm90ZToKPj4+ IEhpIEFuZHksCj4+Pgo+Pj4gT24gVHVlLCBNYXIgMjksIDIwMjIgYXQgMDc6NTY6MjdQTSArMDgw MCwgQW5keSBZYW4gd3JvdGU6Cj4+Pj4gSGkgU2FzY2hhOgo+Pj4+Cj4+Pj4gT24gMy8yOC8yMiAy MzoxMSwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4+PiBXaXRoIHVwY29taW5nIFZPUDIgc3VwcG9y dCBWT1Agd29uJ3QgYmUgdGhlIG9ubHkgY2hvaWNlIGFueW1vcmUsIHNvIG1ha2UKPj4+Pj4gdGhl IFZPUCBkcml2ZXIgb3B0aW9uYWwuCj4+Pj4+Cj4+Pj4+IFNpZ25lZC1vZmYtYnk6IFNhc2NoYSBI YXVlciA8cy5oYXVlckBwZW5ndXRyb25peC5kZT4KPj4+Pj4gLS0tCj4+Pj4+ICAgICBkcml2ZXJz L2dwdS9kcm0vcm9ja2NoaXAvS2NvbmZpZyAgICAgICAgICAgIHwgOCArKysrKysrKwo+Pj4+PiAg ICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL01ha2VmaWxlICAgICAgICAgICB8IDMgKystCj4+ Pj4+ICAgICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2Rydi5jIHwgMiAr LQo+Pj4+PiAgICAgMyBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9u cygtKQo+Pj4+Pgo+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL0tj b25maWcgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvS2NvbmZpZwo+Pj4+PiBpbmRleCBmYTVj ZmRhNGU5MGUzLi43ZDIyZTI5OTdhNTcxIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vcm9ja2NoaXAvS2NvbmZpZwo+Pj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv S2NvbmZpZwo+Pj4+PiBAQCAtMjMsOCArMjMsMTYgQEAgY29uZmlnIERSTV9ST0NLQ0hJUAo+Pj4+ PiAgICAgaWYgRFJNX1JPQ0tDSElQCj4+Pj4+ICtjb25maWcgUk9DS0NISVBfVk9QCj4+Pj4+ICsJ Ym9vbCAiUm9ja2NoaXAgVk9QIGRyaXZlciIKPj4+Pj4gKwlkZWZhdWx0IHkKPj4+Pj4gKwloZWxw Cj4+Pj4+ICsJICBUaGlzIHNlbGVjdHMgc3VwcG9ydCBmb3IgdGhlIFZPUCBkcml2ZXIuIFlvdSBz aG91bGQgZW5hYmxlIGl0Cj4+Pj4+ICsJICBvbiBhbGwgb2xkZXIgU29DcyB1cCB0byBSSzMzOTku Cj4+PiBUaGF0IHJlbWluZHMgbWUgdGhhdCBJIHdhbnRlZCB0byByZXBocmFzZSB0aGlzLiBXaWxs IGNoYW5nZSBpbiBuZXh0Cj4+PiByb3VuZC4KPj4+Cj4+Pj4+ICsKPj4+Pj4gICAgIGNvbmZpZyBS T0NLQ0hJUF9BTkFMT0dJWF9EUAo+Pj4+PiAgICAgCWJvb2wgIlJvY2tjaGlwIHNwZWNpZmljIGV4 dGVuc2lvbnMgZm9yIEFuYWxvZ2l4IERQIGRyaXZlciIKPj4+Pj4gKwlkZXBlbmRzIG9uIFJPQ0tD SElQX1ZPUAo+Pj4+IEFhbmxvZ2l4IGRwIGlzIGFsc28gb24gdm9wMiBiYXNlIHNvYyBzdWNoIGFz wqAgcmszNTZ4IGFuZCByazM1ODguCj4gQlRXIEkganVzdCBsb29rZWQgYXQgdGhlIGRvd25zdHJl YW0gZHJpdmVyLiBIZXJlIHdlIGhhdmUgdGhlIHNhbWUKPiBzaXR1YXRpb24gdGhhdCB0aGUgYW5h bG9naXggZHAgZHJpdmVyIGNhbGxzIHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkKPiB3aGlj aCBpcyBpbXBsZW1lbnRlZCBpbiB0aGUgVk9QIGRyaXZlciwgc28gd2hlbiB0aGUgYW5hbG9naXgg ZHAgZHJpdmVyCj4gaXMgYWN0dWFsbHkgdXNlZCBvbiBhIFZPUDIgU29DIHRoZW4gaXQgaXMgZWl0 aGVyIHVzZWQgaW4gYSB3YXkgdGhhdAo+IHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkgd2ls bCBuZXZlciBiZSBjYWxsZWQgb3IgaXQgZXhwbG9kZXMgaW4gYWxsCj4gY29sb3Vycy4KPgo+Pj4g SSBhZGRlZCB0aGUgZGVwZW5kZW5jeSBiZWNhdXNlIGFuYWxvZ2l4X2RwLXJvY2tjaGlwLmMgY2Fs bHMKPj4+IHJvY2tjaGlwX2RybV93YWl0X3ZhY3RfZW5kKCkgd2hpY2ggaXMgaW1wbGVtZW50ZWQg aW4gdGhlIFZPUCBkcml2ZXIsCj4+PiBzbyB0aGlzIGRyaXZlciBjdXJyZW50eSBjYW4ndCB3b3Jr IHdpdGggdGhlIFZPUDIgZHJpdmVyIGFuZCBjYW4ndAo+Pj4gYmUgbGlua2VkIHdpdGhvdXQgdGhl IFZPUCBkcml2ZXIgYmVpbmcgcHJlc2VudC4KPj4+IEknbGwgYWRkIGEgZmV3IHdvcmRzIHRvIHRo ZSBjb21taXQgbWVzc2FnZS4KPj4KPj4gTWF5YmUgYSBiZXR0ZXIgZGlyZWN0aW9uIGlzIG1vdmUg cm9ja2NoaXBfZHJtX3dhaXRfdmFjdF9lbmQgZnJvbSB0aGUgVk9QCj4+IGRyaXZlciB0byByb2Nr Y2hpcF9kcm1fZHJ2LmMKPiBJIGFtIG5vdCBzdXJlIGlmIHRoYXQncyByZWFsbHkgd29ydGggaXQu IFllcywgdGhlIGRpcmVjdGlvbiBtaWdodCBiZSB0aGUKPiByaWdodCBvbmUsIGJ1dCBJIHdvdWxk IHJlYWxseSBwcmVmZXIgd2hlbiBzb21lYm9keSBkb2VzIHRoZSBjaGFuZ2Ugd2hvCj4gY2FuIHRl c3QgYW5kIGNvbmZpcm0gdGhhdCB0aGUgYW5hbG9naXggZHAgcmVhbGx5IHdvcmtzIHdpdGggVk9Q MiBpbiB0aGUKPiBlbmQuCgpJZiBmb2xsb3cgdGhpcyBwb2ludCwgdGhlIGN1cnJlbnQgRFdfTUlQ SSBhbHNvIGhhcyBub3QgYmVlbiB0ZXN0ZWQgZm9yIApjb25maXJtIHRoYXQgaXQKCmNhbiByZWFs bHkgd29yayB3aXRoIFZPUDIsIHNvIHlvdSBzaG91bGQgYWxzbyBtYWtlIGl0IGRlcGVuZHMgb24g ClJPQ0tDSElQX1ZPUC4KCkkgdGhpbmsgdGhlIGN1cnJlbnQgc29sdXRpb24gaXMganVzdCBhIHdv cmthcm91bmQgdG8gbWFrZSB5b3VyIHBhdGNoIApwYXNzIHRoZSBrZXJuZWwgY29tcGlsZQoKYnV0 IG5vdCByZWZsZWN0IHRoZSByZWFsIHNpdHVhdGlvbi4KCj4gU2FzY2hhCj4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK