From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A222C636CB for ; Mon, 19 Jul 2021 06:31:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6209961165 for ; Mon, 19 Jul 2021 06:31:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234441AbhGSGev (ORCPT ); Mon, 19 Jul 2021 02:34:51 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46910 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233689AbhGSGev (ORCPT ); Mon, 19 Jul 2021 02:34:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626676312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=jDB2KKBoU/XoTVQsQGXZxnceyw4AszMc3RxVq9HJzRRbUkWw0a/jll/nXNpGtQniT/dUdt uSaVDTAEgMMWqHAP2BtxrIqURmiTKjEfGXhv5lWMgZTrKJqeMzrY09C6+aaJz148NCUP8Y wkY+WWC1vr/U3TVe5pafh3vgIDjlz/A= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-DVHCHmFpMOmEypfKSYsFsQ-1; Mon, 19 Jul 2021 02:31:48 -0400 X-MC-Unique: DVHCHmFpMOmEypfKSYsFsQ-1 Received: by mail-ej1-f70.google.com with SMTP id nc15-20020a1709071c0fb029052883e9de3eso4847368ejc.19 for ; Sun, 18 Jul 2021 23:31:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=MkkmSsLandcP0He05fywO+TTq2HcYZwQDgXGiYg9Nq0aPytEUpSpisWr2SFYvdgzQm PsV1vujXZE09kqef1m/42BYc9zieY4yF3cB0pOvIHFMCc4//jUsiauBzmbR8DWS4MRlU JbQrJfFHKvBZg4OtdHoFh1l6dYEo4SXXfschHcSVPZ+7DfAWDjIvmOTVKuxe+1aTQ4vq XVpmR7GLs8h2+yyktZtCwl4EifPUpdP9i8EHyTSKknQZ/PMaY6LTxK2GQRVTJZK9eWDE VV48GkhF70yqwegDzLe4vHQ9v8sTDt/Rw0uEZHPSFDWzabyQXxoQ8xF/ntWs6F+hvZ6Q vzVQ== X-Gm-Message-State: AOAM53085ud3Kfi3XygrGoVZXSwTs/cGqyXGlPYrhEGbKpQrIT4s0z8a jubCo+HrPYGEmIoqhP1CgxqvRxDqViOxlthfrvk8Yx4kz1/eF6Jrc7mKJNZNi2GTBPz0FhH++T1 5UQN3fw7DlSf0 X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130816ejp.443.1626676307274; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwKAXQ0jz8kg1aBiPUIh7/qkMfflW9/UFkvvWaaFSOpzP+F0zQJJOF6m/qps2butenIEa5BQ== X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130798ejp.443.1626676307142; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id f24sm4761419edv.93.2021.07.18.23.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jul 2021 23:31:46 -0700 (PDT) Subject: Re: [PATCH 5/5] KVM: Get rid of kvm_get_pfn() To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-mm@kvack.org Cc: Sean Christopherson , Matthew Wilcox , Will Deacon , Quentin Perret , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com References: <20210717095541.1486210-1-maz@kernel.org> <20210717095541.1486210-6-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Mon, 19 Jul 2021 08:31:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210717095541.1486210-6-maz@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 17/07/21 11:55, Marc Zyngier wrote: > Nobody is using kvm_get_pfn() anymore. Get rid of it. > > Signed-off-by: Marc Zyngier > --- > include/linux/kvm_host.h | 1 - > virt/kvm/kvm_main.c | 9 +-------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index ae7735b490b4..9818d271c2a1 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -824,7 +824,6 @@ void kvm_release_pfn_clean(kvm_pfn_t pfn); > void kvm_release_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_accessed(kvm_pfn_t pfn); > -void kvm_get_pfn(kvm_pfn_t pfn); > > void kvm_release_pfn(kvm_pfn_t pfn, bool dirty, struct gfn_to_pfn_cache *cache); > int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2e410a8a6a67..0284418c4400 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2215,7 +2215,7 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, > * Get a reference here because callers of *hva_to_pfn* and > * *gfn_to_pfn* ultimately call kvm_release_pfn_clean on the > * returned pfn. This is only needed if the VMA has VM_MIXEDMAP > - * set, but the kvm_get_pfn/kvm_release_pfn_clean pair will > + * set, but the kvm_try_get_pfn/kvm_release_pfn_clean pair will > * simply do nothing for reserved pfns. > * > * Whoever called remap_pfn_range is also going to call e.g. > @@ -2612,13 +2612,6 @@ void kvm_set_pfn_accessed(kvm_pfn_t pfn) > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_accessed); > > -void kvm_get_pfn(kvm_pfn_t pfn) > -{ > - if (!kvm_is_reserved_pfn(pfn)) > - get_page(pfn_to_page(pfn)); > -} > -EXPORT_SYMBOL_GPL(kvm_get_pfn); > - > static int next_segment(unsigned long len, int offset) > { > if (len > PAGE_SIZE - offset) > Acked-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91EF4C12002 for ; Mon, 19 Jul 2021 06:31:55 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 350D261165 for ; Mon, 19 Jul 2021 06:31:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 350D261165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DCC634B087; Mon, 19 Jul 2021 02:31:54 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9-VMOKzacx4G; Mon, 19 Jul 2021 02:31:53 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EA6CD4A500; Mon, 19 Jul 2021 02:31:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DACC740856 for ; Mon, 19 Jul 2021 02:31:52 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KWL+GcHUWZbo for ; Mon, 19 Jul 2021 02:31:52 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 100BE4A3A5 for ; Mon, 19 Jul 2021 02:31:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626676311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=VyL8LrzoP8cupK4fD6/DLdTVXUk17NBDDFrnzUmb2HxDjCS6D2Uo5Opm5URyEc1KvkaDnS 7tcSEyzDLnlPIIJzmG0aBmPAfyOZhCnUOBj3KvIocQYqFTYnrp4sLB6uswXMIWSRKcuRRG X2zulMuBCpdNCSbkiihBCU1PytfkmRE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-FtN3UmEgPYSalBd_e5_uAg-1; Mon, 19 Jul 2021 02:31:48 -0400 X-MC-Unique: FtN3UmEgPYSalBd_e5_uAg-1 Received: by mail-ej1-f72.google.com with SMTP id jx16-20020a1709077610b02904e0a2912b46so4866553ejc.7 for ; Sun, 18 Jul 2021 23:31:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=XOqsvBZ85teA+r/vljly0G/tdKAvqwGt8+BxFB1FHmrRJNFDSZaN8uS1+Peg8x0KYA D65bc0VIC0Jn0rNfX1CsF9btfn4MVeHSLR6/O3o34lPyvSkYbErgjfVIjqkGSxp+p+5p 5GBFi0j5CqrCMhzVBsDpbBWnVwKa2Z8gf+wvl9KXbqgYAhKSLze4h/lew/wQ8ra9/78W Fupi4kE4FR1+Tet/B0nLqUUa1lKu12jQJ6Ev36V5H9U9M4b/WzIv9PbJ9gZFdO/Mir21 H/DLXzKd4lqt+kGjR9SbzWuqqfQK6U7pV+lb4u1QE5juLkVjnD1+7/gbB5jyPt+edp6H 3LUw== X-Gm-Message-State: AOAM532ikwRUpy44kpOGlExMIGmtmNh/QliwY7U1EHyknnWsZETtjNs0 6mAsRCGAyBPwiHOQ2ZsMPpxRszrYkN2Tswp2edYQ8RSoeCz8NdbvkHQZqN0ZZqA2pX+C0md5ZRx WAWgfBFXmefXalU09cEJa8L40 X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130818ejp.443.1626676307274; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwKAXQ0jz8kg1aBiPUIh7/qkMfflW9/UFkvvWaaFSOpzP+F0zQJJOF6m/qps2butenIEa5BQ== X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130798ejp.443.1626676307142; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id f24sm4761419edv.93.2021.07.18.23.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jul 2021 23:31:46 -0700 (PDT) Subject: Re: [PATCH 5/5] KVM: Get rid of kvm_get_pfn() To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-mm@kvack.org References: <20210717095541.1486210-1-maz@kernel.org> <20210717095541.1486210-6-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Mon, 19 Jul 2021 08:31:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210717095541.1486210-6-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: kernel-team@android.com, Sean Christopherson , Matthew Wilcox , Will Deacon X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On 17/07/21 11:55, Marc Zyngier wrote: > Nobody is using kvm_get_pfn() anymore. Get rid of it. > > Signed-off-by: Marc Zyngier > --- > include/linux/kvm_host.h | 1 - > virt/kvm/kvm_main.c | 9 +-------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index ae7735b490b4..9818d271c2a1 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -824,7 +824,6 @@ void kvm_release_pfn_clean(kvm_pfn_t pfn); > void kvm_release_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_accessed(kvm_pfn_t pfn); > -void kvm_get_pfn(kvm_pfn_t pfn); > > void kvm_release_pfn(kvm_pfn_t pfn, bool dirty, struct gfn_to_pfn_cache *cache); > int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2e410a8a6a67..0284418c4400 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2215,7 +2215,7 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, > * Get a reference here because callers of *hva_to_pfn* and > * *gfn_to_pfn* ultimately call kvm_release_pfn_clean on the > * returned pfn. This is only needed if the VMA has VM_MIXEDMAP > - * set, but the kvm_get_pfn/kvm_release_pfn_clean pair will > + * set, but the kvm_try_get_pfn/kvm_release_pfn_clean pair will > * simply do nothing for reserved pfns. > * > * Whoever called remap_pfn_range is also going to call e.g. > @@ -2612,13 +2612,6 @@ void kvm_set_pfn_accessed(kvm_pfn_t pfn) > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_accessed); > > -void kvm_get_pfn(kvm_pfn_t pfn) > -{ > - if (!kvm_is_reserved_pfn(pfn)) > - get_page(pfn_to_page(pfn)); > -} > -EXPORT_SYMBOL_GPL(kvm_get_pfn); > - > static int next_segment(unsigned long len, int offset) > { > if (len > PAGE_SIZE - offset) > Acked-by: Paolo Bonzini _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D4CC12002 for ; Mon, 19 Jul 2021 06:33:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4FA360BD3 for ; Mon, 19 Jul 2021 06:33:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4FA360BD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ASsVuJ022QEAjen5oypwrGCCeDnk/Snb3cl9EA1u7R8=; b=Z3ejaCSUF4L0rWktdS88OMI8Cn //olyWxpN/yud+HfiZ5CDA6/IuYWL9jkm22NckEBFhMNvwJNchGC3lBG5r0UTJDE+2O/Lpe3x1Xwl kX2ZiTy3Ar2mYBNzPU5H3Y5L6JV/28A7FUKsvH1KRRIbRSapC7qGFcjPtGqV9EpOe2lFuMUNdxP8i SS9hAuKrAQQBcNG6cuLSfwUVXdO1MN88+X3/WuUd0aS22OjtVmPpkThyphn1odCF6AORhNPRJGHOs FyxvMt/Pt9Bd4cO6YGGqapPIXDkT3Ln6gjIFDcKtpmeXXGCgvcxFQHFzRjXYhf3RSOo2YHYazRSkI hQVQuidg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5Mou-008Tz7-Fd; Mon, 19 Jul 2021 06:32:04 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5Moh-008TwS-1J for linux-arm-kernel@lists.infradead.org; Mon, 19 Jul 2021 06:31:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626676310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=S1lMYqFh7D5Dc4wAFBXiChoD39z8wAceQLw1h/OKvIABxNrbPhy1zloX3orT4xcK7Y9g/r rnQ2GJOJzxu7gl4eaJcWCKR+9r1wqL9Zuf6LroF+mz5HcgQ/+vfyAJCjhUX/OizoyUEAla is1KUxhuVRSCCBui6dkiyV1Z5l20+8o= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-117-6AyMQJJxP3-PVX6xAIYPgQ-1; Mon, 19 Jul 2021 02:31:48 -0400 X-MC-Unique: 6AyMQJJxP3-PVX6xAIYPgQ-1 Received: by mail-ej1-f72.google.com with SMTP id n3-20020a1709061183b029053d0856c4cdso2507574eja.15 for ; Sun, 18 Jul 2021 23:31:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5iBFyoa3ekzBjt+3mHKhKLuzk3TVXqOUxd9HJiVKOWA=; b=gF7Y3HzNJO2oDwEi/C9J9RWj/kxnLuRYs19D0mHKnSw7ll8hm2R5xtz6CGpw5XzBdX 9i6TFRRlEqCiJGD3GnGCUT5tey+GnqNlD3yFaFqry1uzHniMw3WH7GpXcxM83k2ub0RP 4SEyLX3NQfaTRzb57Z3qkSD8g6MxpAOn7jlKevq8F5pyLYNSpqVL3PC83Z/qd/fqu1Sk FcwPNJHakuFifzkalXJm3Cw0VobGP7iVFoUTF8vIgWMw8B1T5ZpsUzUGjL5tJLEVfG14 ELL+qv4Cq830jNs3fNflcO86J9Sgdqb3OiD5zp9sIYN47PZ39NjID585DA7s19gfYE6C HIzg== X-Gm-Message-State: AOAM530PkvrHpxKszqcNNrJFwRZKUEBCYE9CTjbX6cf6bRgNyHCRMDNC GAWiSwUAL374lrpWhtufYQrOKGx5ZhoTu0CNHJ4LE76XfJYk6aj4K6ySH5zCCnDhR7MY4KLeWL9 rJi9bMysFUvu6Clxyo2zTURLhOOuUIczRu18= X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130810ejp.443.1626676307273; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwKAXQ0jz8kg1aBiPUIh7/qkMfflW9/UFkvvWaaFSOpzP+F0zQJJOF6m/qps2butenIEa5BQ== X-Received: by 2002:a17:906:660f:: with SMTP id b15mr26130798ejp.443.1626676307142; Sun, 18 Jul 2021 23:31:47 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id f24sm4761419edv.93.2021.07.18.23.31.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jul 2021 23:31:46 -0700 (PDT) Subject: Re: [PATCH 5/5] KVM: Get rid of kvm_get_pfn() To: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-mm@kvack.org Cc: Sean Christopherson , Matthew Wilcox , Will Deacon , Quentin Perret , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com References: <20210717095541.1486210-1-maz@kernel.org> <20210717095541.1486210-6-maz@kernel.org> From: Paolo Bonzini Message-ID: Date: Mon, 19 Jul 2021 08:31:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210717095541.1486210-6-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210718_233151_274253_A34DC651 X-CRM114-Status: GOOD ( 20.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/07/21 11:55, Marc Zyngier wrote: > Nobody is using kvm_get_pfn() anymore. Get rid of it. > > Signed-off-by: Marc Zyngier > --- > include/linux/kvm_host.h | 1 - > virt/kvm/kvm_main.c | 9 +-------- > 2 files changed, 1 insertion(+), 9 deletions(-) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index ae7735b490b4..9818d271c2a1 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -824,7 +824,6 @@ void kvm_release_pfn_clean(kvm_pfn_t pfn); > void kvm_release_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_dirty(kvm_pfn_t pfn); > void kvm_set_pfn_accessed(kvm_pfn_t pfn); > -void kvm_get_pfn(kvm_pfn_t pfn); > > void kvm_release_pfn(kvm_pfn_t pfn, bool dirty, struct gfn_to_pfn_cache *cache); > int kvm_read_guest_page(struct kvm *kvm, gfn_t gfn, void *data, int offset, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 2e410a8a6a67..0284418c4400 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2215,7 +2215,7 @@ static int hva_to_pfn_remapped(struct vm_area_struct *vma, > * Get a reference here because callers of *hva_to_pfn* and > * *gfn_to_pfn* ultimately call kvm_release_pfn_clean on the > * returned pfn. This is only needed if the VMA has VM_MIXEDMAP > - * set, but the kvm_get_pfn/kvm_release_pfn_clean pair will > + * set, but the kvm_try_get_pfn/kvm_release_pfn_clean pair will > * simply do nothing for reserved pfns. > * > * Whoever called remap_pfn_range is also going to call e.g. > @@ -2612,13 +2612,6 @@ void kvm_set_pfn_accessed(kvm_pfn_t pfn) > } > EXPORT_SYMBOL_GPL(kvm_set_pfn_accessed); > > -void kvm_get_pfn(kvm_pfn_t pfn) > -{ > - if (!kvm_is_reserved_pfn(pfn)) > - get_page(pfn_to_page(pfn)); > -} > -EXPORT_SYMBOL_GPL(kvm_get_pfn); > - > static int next_segment(unsigned long len, int offset) > { > if (len > PAGE_SIZE - offset) > Acked-by: Paolo Bonzini _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel