From: Paolo Abeni <pabeni@redhat.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Alexander Lobakin <alobakin@pm.me>
Subject: Re: [PATCH net-next 2/8] udp: skip fwd/list GRO for tunnel packets
Date: Mon, 22 Mar 2021 17:41:27 +0100 [thread overview]
Message-ID: <efa5f117ad63064f7984655d46eb5140d23b0585.camel@redhat.com> (raw)
In-Reply-To: <CA+FuTSc=V_=behQ0MKX3oYdDzZN=V7_CdeNOFXUAa-4TuU5ztA@mail.gmail.com>
On Mon, 2021-03-22 at 09:24 -0400, Willem de Bruijn wrote:
> On Sun, Mar 21, 2021 at 1:01 PM Paolo Abeni <pabeni@redhat.com> wrote:
> > If UDP GRO forwarding (or list) is enabled,
>
> Please explicitly mention the gso type SKB_GSO_FRAGLIST. I, at least,
> didn't immediately grasp that gro forwarding is an alias for that.
I see the commit message was not clear at all, I'm sorry.
The above means:
gso_type & (NETIF_F_GSO_UDP_L4 | NETIF_F_GSO_FRAGLIST)
:)
> > and there are
> > udp tunnel available in the system, we could end-up doing L4
> > aggregation for packets targeting the UDP tunnel.
>
> Is this specific to UDP tunnels, or can this also occur with others,
> such as GRE? (not implying that this patchset needs to address those
> at the same time)
I did not look at that before your suggestion. Thanks for pointing out.
I think the problem is specific to UDP: when processing the outer UDP
header that is potentially eligible for both NETIF_F_GSO_UDP_L4 and
gro_receive aggregation and that is the root cause of the problem
addressed here.
> > Just skip the fwd GRO if this packet could land in an UDP
> > tunnel.
>
> Could you make more clear that this does not skip UDP GRO, only
> switches from fraglist-based to pure SKB_GSO_UDP_L4.
Sure, I'll try to rewrite the commit message.
Thanks!
Paolo
next prev parent reply other threads:[~2021-03-22 16:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 17:01 [PATCH net-next 0/8] udp: GRO L4 improvements Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 1/8] udp: fixup csum for GSO receive slow path Paolo Abeni
2021-03-22 13:18 ` Willem de Bruijn
2021-03-22 16:34 ` Paolo Abeni
2021-03-24 1:45 ` Willem de Bruijn
2021-03-24 1:49 ` Willem de Bruijn
2021-03-24 14:37 ` Paolo Abeni
2021-03-24 22:36 ` Willem de Bruijn
2021-03-25 10:56 ` Paolo Abeni
2021-03-25 13:53 ` Willem de Bruijn
2021-03-25 16:47 ` Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 2/8] udp: skip fwd/list GRO for tunnel packets Paolo Abeni
2021-03-22 13:24 ` Willem de Bruijn
2021-03-22 16:41 ` Paolo Abeni [this message]
2021-03-24 1:54 ` Willem de Bruijn
2021-03-24 14:50 ` ! Paolo Abeni
2021-03-24 22:45 ` ! Willem de Bruijn
2021-03-21 17:01 ` [PATCH net-next 3/8] udp: properly complete L4 GRO over UDP tunnel packet Paolo Abeni
2021-03-22 13:30 ` Willem de Bruijn
2021-03-22 16:59 ` Paolo Abeni
2021-03-24 2:13 ` Willem de Bruijn
2021-03-21 17:01 ` [PATCH net-next 4/8] udp: never accept GSO_FRAGLIST packets Paolo Abeni
2021-03-22 13:42 ` Willem de Bruijn
2021-03-22 17:09 ` Paolo Abeni
2021-03-24 2:21 ` Willem de Bruijn
2021-03-24 18:59 ` Paolo Abeni
2021-03-24 22:12 ` Willem de Bruijn
2021-03-25 11:50 ` Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 5/8] vxlan: allow L4 GRO passthrou Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 6/8] geneve: allow UDP " Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 7/8] bareudp: " Paolo Abeni
2021-03-21 17:01 ` [PATCH net-next 8/8] selftests: net: add UDP GRO forwarding self-tests Paolo Abeni
2021-03-22 13:44 ` Willem de Bruijn
2021-03-22 17:18 ` Paolo Abeni
2021-03-23 17:12 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa5f117ad63064f7984655d46eb5140d23b0585.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=alobakin@pm.me \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.