From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92EAC433F5 for ; Wed, 20 Apr 2022 12:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378605AbiDTMid (ORCPT ); Wed, 20 Apr 2022 08:38:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232153AbiDTMia (ORCPT ); Wed, 20 Apr 2022 08:38:30 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 837911277F for ; Wed, 20 Apr 2022 05:35:43 -0700 (PDT) Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 20 Apr 2022 20:35:41 +0800 Message-ID: Date: Wed, 20 Apr 2022 20:35:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 2/2] dt-bindings: nand: meson: refine Amlogic NAND controller driver Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-3-liang.yang@amlogic.com> <20220420094107.4799f15a@xps13> <20220420141620.4fd68eef@xps13> From: Liang Yang In-Reply-To: <20220420141620.4fd68eef@xps13> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 2022/4/20 20:16, Miquel Raynal wrote: > [ EXTERNAL EMAIL ] > > Hi Liang, > >>>> +maintainers: >>>> + - liang.yang@amlogic.com >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - "amlogic,meson-gxl-nfc" >>>> + - "amlogic,meson-axg-nfc" >>>> + >>>> + reg: >>>> + maxItems: 2 >>>> + >>>> + '#address-cells': >>>> + const: 1 >>> >>> Not sure this property is needed. >> this is for the subnode, such as nand@0. > > Yes but if you refer to nand-controller.yaml you no longer need these. ok, i will try it. > >>> >>>> + >>>> + '#size-cells': >>>> + const: 0 >>> >>> Ditto. Plus, this one looks wrong anyway. >> this is for the subnode, such as nand@0. do you mean s/''/""/? > > Sorry, this is not "wrong anyway", my fault. But still, you don't need > this property for the same reason as above. ok. > >>> >>>> + >>>> + reg-names: >>>> + items: >>>> + - const: nfc >>>> + - const: emmc >>> >>> Why do you need the emmc register map? Do you really need to perform a >>> register access there? >> yes, we have to access the emmc register map. because the NFC clock comes from SDEMMC_CLOCK register. > > But if it's a clock you should get the clock and call > clk_prepare_enable(), you don't need to poke directly in the registers. > Do you? no, it doesn't. it is special and the reason why need to implement a MMC sub clock driver previously. also we don't implement it as a clock provider in drivers/clk/meson/, because the SDEMMC_CLOCK register is internal in MCI controller. > >>>> +examples: >>>> + - | >>>> + #include >>>> + #include >>>> + apb { >>>> + #address-cells = <2>; >>>> + #size-cells = <2>; >>> >>> Not sure you need this upper node in the example. >> use the upper node to indicate the "#address-cells" and "#size-cells". if i do not do that, dt_binding_check will report: >> ".....reg:0: [0, 30720, 0, 256] is too long" and >> ".....reg:1: [0, 28672, 0, 2048] is too long". > > ok, maybe, I'll let bindings maintainer review that. ok. thanks. > >>> >>>> + nand-controller@7800 { >>>> + #address-cells = <1>; >>>> + #size-cells = <0>; >>>> + compatible = "amlogic,meson-axg-nfc"; >>>> + reg = <0x0 0x7800 0x0 0x100>, >>>> + <0x0 0x7000 0x0 0x800>; >>>> + reg-names = "nfc", "emmc"; >>>> + >>>> + interrupts = ; >>>> + clocks = <&clkc CLKID_SD_EMMC_C>, >>>> + <&clkc CLKID_FCLK_DIV2>; >>>> + clock-names = "core", "device"; >>>> + >>>> + }; >>>> + }; >>>> +... > > > Thanks, > Miquèl > > . From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F513C433F5 for ; Wed, 20 Apr 2022 12:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fvBpYWRZp+9UFKrdFAix9/3QXR49w0qBJLZloOjGNeQ=; b=dR7mV23PYdnpiV aKETsHstj+kYzxrrdY7JvGMB6ok1Nn+pPZmcRx0gYbcgF3jR6+UjzL2vYrOv+7OTklYKGxnF4oPBN LOr7kWXz4h+tTv2e7slrApCSstL0eBn7OTJRTSZhmqNBcf85IhA+nzSbz0tv6y33LhN420qNnuTex QoRbdgCDbHCorB5HS3dMeN6YWfWaeYAiINQQ/nnQIojqVV7FszDYz5YLPg6w7+l5AsTSuy06P71fG 2z+n8xwh5HrWN2/BJrBj+8uqsDeH76URe/XLBTV9Wat0tGIRaTNPzPrN3OIpF0EkYONgyBSYapSRo QkLTSWrEtSAA1i7nykzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Yq-00905y-VV; Wed, 20 Apr 2022 12:35:56 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Yd-009026-UT; Wed, 20 Apr 2022 12:35:45 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 20 Apr 2022 20:35:41 +0800 Message-ID: Date: Wed, 20 Apr 2022 20:35:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 2/2] dt-bindings: nand: meson: refine Amlogic NAND controller driver Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-3-liang.yang@amlogic.com> <20220420094107.4799f15a@xps13> <20220420141620.4fd68eef@xps13> From: Liang Yang In-Reply-To: <20220420141620.4fd68eef@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_053544_052324_97935B95 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKT24gMjAyMi80LzIwIDIwOjE2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+IFsg RVhURVJOQUwgRU1BSUwgXQo+IAo+IEhpIExpYW5nLAo+IAo+Pj4+ICttYWludGFpbmVyczoKPj4+ PiArICAtIGxpYW5nLnlhbmdAYW1sb2dpYy5jb20KPj4+PiArCj4+Pj4gK3Byb3BlcnRpZXM6Cj4+ Pj4gKyAgY29tcGF0aWJsZToKPj4+PiArICAgIGVudW06Cj4+Pj4gKyAgICAgIC0gImFtbG9naWMs bWVzb24tZ3hsLW5mYyIKPj4+PiArICAgICAgLSAiYW1sb2dpYyxtZXNvbi1heGctbmZjIgo+Pj4+ ICsKPj4+PiArICByZWc6Cj4+Pj4gKyAgICBtYXhJdGVtczogMgo+Pj4+ICsKPj4+PiArICAnI2Fk ZHJlc3MtY2VsbHMnOgo+Pj4+ICsgICAgY29uc3Q6IDEKPj4+Cj4+PiBOb3Qgc3VyZSB0aGlzIHBy b3BlcnR5IGlzIG5lZWRlZC4KPj4gdGhpcyBpcyBmb3IgdGhlIHN1Ym5vZGUsIHN1Y2ggYXMgbmFu ZEAwLgo+IAo+IFllcyBidXQgaWYgeW91IHJlZmVyIHRvIG5hbmQtY29udHJvbGxlci55YW1sIHlv dSBubyBsb25nZXIgbmVlZCB0aGVzZS4Kb2ssIGkgd2lsbCB0cnkgaXQuCj4gCj4+PiAgICAKPj4+ PiArCj4+Pj4gKyAgJyNzaXplLWNlbGxzJzoKPj4+PiArICAgIGNvbnN0OiAwCj4+Pgo+Pj4gRGl0 dG8uIFBsdXMsIHRoaXMgb25lIGxvb2tzIHdyb25nIGFueXdheS4KPj4gdGhpcyBpcyBmb3IgdGhl IHN1Ym5vZGUsIHN1Y2ggYXMgbmFuZEAwLiBkbyB5b3UgbWVhbiBzLycnLyIiLz8KPiAKPiBTb3Jy eSwgdGhpcyBpcyBub3QgIndyb25nIGFueXdheSIsIG15IGZhdWx0LiBCdXQgc3RpbGwsIHlvdSBk b24ndCBuZWVkCj4gdGhpcyBwcm9wZXJ0eSBmb3IgdGhlIHNhbWUgcmVhc29uIGFzIGFib3ZlLgpv ay4KPiAKPj4+ICAgIAo+Pj4+ICsKPj4+PiArICByZWctbmFtZXM6Cj4+Pj4gKyAgICBpdGVtczoK Pj4+PiArICAgICAgLSBjb25zdDogbmZjCj4+Pj4gKyAgICAgIC0gY29uc3Q6IGVtbWMKPj4+Cj4+ PiBXaHkgZG8geW91IG5lZWQgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwPyBEbyB5b3UgcmVhbGx5IG5l ZWQgdG8gcGVyZm9ybSBhCj4+PiByZWdpc3RlciBhY2Nlc3MgdGhlcmU/Cj4+IHllcywgd2UgaGF2 ZSB0byBhY2Nlc3MgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwLiBiZWNhdXNlIHRoZSBORkMgY2xvY2sg Y29tZXMgZnJvbSBTREVNTUNfQ0xPQ0sgcmVnaXN0ZXIuCj4gCj4gQnV0IGlmIGl0J3MgYSBjbG9j ayB5b3Ugc2hvdWxkIGdldCB0aGUgY2xvY2sgYW5kIGNhbGwKPiBjbGtfcHJlcGFyZV9lbmFibGUo KSwgeW91IGRvbid0IG5lZWQgdG8gcG9rZSBkaXJlY3RseSBpbiB0aGUgcmVnaXN0ZXJzLgo+IERv IHlvdT8KCm5vLCBpdCBkb2Vzbid0LiBpdCBpcyBzcGVjaWFsIGFuZCB0aGUgcmVhc29uIHdoeSBu ZWVkIHRvIGltcGxlbWVudCBhIE1NQyAKc3ViIGNsb2NrIGRyaXZlciBwcmV2aW91c2x5LiBhbHNv IHdlIGRvbid0IGltcGxlbWVudCBpdCBhcyBhIGNsb2NrIApwcm92aWRlciBpbiBkcml2ZXJzL2Ns ay9tZXNvbi8sIGJlY2F1c2UgdGhlIFNERU1NQ19DTE9DSyByZWdpc3RlciBpcyAKaW50ZXJuYWwg aW4gTUNJIGNvbnRyb2xsZXIuCj4gCj4+Pj4gK2V4YW1wbGVzOgo+Pj4+ICsgIC0gfAo+Pj4+ICsg ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2Nsb2NrL2F4Zy1jbGtjLmg+Cj4+Pj4gKyAgICAjaW5j bHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvYXJtLWdpYy5oPgo+Pj4+ICsg ICAgYXBiIHsKPj4+PiArICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cj4+Pj4gKyAgICAgICNz aXplLWNlbGxzID0gPDI+Owo+Pj4KPj4+IE5vdCBzdXJlIHlvdSBuZWVkIHRoaXMgdXBwZXIgbm9k ZSBpbiB0aGUgZXhhbXBsZS4KPj4gdXNlIHRoZSB1cHBlciBub2RlIHRvIGluZGljYXRlIHRoZSAi I2FkZHJlc3MtY2VsbHMiIGFuZCAiI3NpemUtY2VsbHMiLiBpZiBpIGRvIG5vdCBkbyB0aGF0LCBk dF9iaW5kaW5nX2NoZWNrIHdpbGwgcmVwb3J0Ogo+PiAgICAiLi4uLi5yZWc6MDogWzAsIDMwNzIw LCAwLCAyNTZdIGlzIHRvbyBsb25nIiBhbmQKPj4gICAgIi4uLi4ucmVnOjE6IFswLCAyODY3Miwg MCwgMjA0OF0gaXMgdG9vIGxvbmciLgo+IAo+IG9rLCBtYXliZSwgSSdsbCBsZXQgYmluZGluZ3Mg bWFpbnRhaW5lciByZXZpZXcgdGhhdC4KCm9rLiB0aGFua3MuCgo+IAo+Pj4gICAgCj4+Pj4gKyAg ICAgIG5hbmQtY29udHJvbGxlckA3ODAwIHsKPj4+PiArICAgICAgICAjYWRkcmVzcy1jZWxscyA9 IDwxPjsKPj4+PiArICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPj4+PiArICAgICAgICBjb21w YXRpYmxlID0gImFtbG9naWMsbWVzb24tYXhnLW5mYyI7Cj4+Pj4gKyAgICAgICAgcmVnID0gPDB4 MCAweDc4MDAgMHgwIDB4MTAwPiwKPj4+PiArICAgICAgICAgICAgICA8MHgwIDB4NzAwMCAweDAg MHg4MDA+Owo+Pj4+ICsgICAgICAgIHJlZy1uYW1lcyA9ICJuZmMiLCAiZW1tYyI7Cj4+Pj4gKwo+ Pj4+ICsgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAzNCBJUlFfVFlQRV9FREdFX1JJU0lO Rz47Cj4+Pj4gKyAgICAgICAgY2xvY2tzID0gPCZjbGtjIENMS0lEX1NEX0VNTUNfQz4sCj4+Pj4g KyAgICAgICAgICAgICAgICAgPCZjbGtjIENMS0lEX0ZDTEtfRElWMj47Cj4+Pj4gKyAgICAgICAg Y2xvY2stbmFtZXMgPSAiY29yZSIsICJkZXZpY2UiOwo+Pj4+ICsKPj4+PiArICAgICAgfTsKPj4+ PiArICAgIH07Cj4+Pj4gKy4uLgo+IAo+IAo+IFRoYW5rcywKPiBNaXF1w6hsCj4gCj4gLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYW1sb2dp YyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYW1sb2dpYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A439C433EF for ; Wed, 20 Apr 2022 12:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JMnCSl8EjMpXrCgc08Kdfsx9Wo071gzuD3PMzoqEqrw=; b=VxuBNuPcUlesy5 robZfIxG0zcfD6hYR1k/hDQJWatebxrkidx9Txs7HfB8OGoNm0XPUxoFknwbUdsPvPUIJB0gNj6Go zBwitpjZAd/gr+gYPmmfztwqCL2z8AN6qQt/8cfy7NNFsP3JJAJ1Udm4/nhlGTdB/+u5jdT2cTTa2 tO3lm2IDY/cZe7Rdvr2TkJbILsqBGbYxGpQ6qQf7lV4RE3hRtgsU24MIjGLO1mvj3ZKpkJMQ0MLvH 8XCcv0zVhggt2wTAeCmIryWGLaOHhG6EC1FR7F/XjFaHHzr8nQfRC6n8jyloRM/e1kxBnoRT6ZHgq 8jCv9lQ+LTXwjNu2j7TQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Ys-00906P-5l; Wed, 20 Apr 2022 12:35:58 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Yd-009026-UT; Wed, 20 Apr 2022 12:35:45 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 20 Apr 2022 20:35:41 +0800 Message-ID: Date: Wed, 20 Apr 2022 20:35:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 2/2] dt-bindings: nand: meson: refine Amlogic NAND controller driver Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-3-liang.yang@amlogic.com> <20220420094107.4799f15a@xps13> <20220420141620.4fd68eef@xps13> From: Liang Yang In-Reply-To: <20220420141620.4fd68eef@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_053544_052324_97935B95 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKT24gMjAyMi80LzIwIDIwOjE2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+IFsg RVhURVJOQUwgRU1BSUwgXQo+IAo+IEhpIExpYW5nLAo+IAo+Pj4+ICttYWludGFpbmVyczoKPj4+ PiArICAtIGxpYW5nLnlhbmdAYW1sb2dpYy5jb20KPj4+PiArCj4+Pj4gK3Byb3BlcnRpZXM6Cj4+ Pj4gKyAgY29tcGF0aWJsZToKPj4+PiArICAgIGVudW06Cj4+Pj4gKyAgICAgIC0gImFtbG9naWMs bWVzb24tZ3hsLW5mYyIKPj4+PiArICAgICAgLSAiYW1sb2dpYyxtZXNvbi1heGctbmZjIgo+Pj4+ ICsKPj4+PiArICByZWc6Cj4+Pj4gKyAgICBtYXhJdGVtczogMgo+Pj4+ICsKPj4+PiArICAnI2Fk ZHJlc3MtY2VsbHMnOgo+Pj4+ICsgICAgY29uc3Q6IDEKPj4+Cj4+PiBOb3Qgc3VyZSB0aGlzIHBy b3BlcnR5IGlzIG5lZWRlZC4KPj4gdGhpcyBpcyBmb3IgdGhlIHN1Ym5vZGUsIHN1Y2ggYXMgbmFu ZEAwLgo+IAo+IFllcyBidXQgaWYgeW91IHJlZmVyIHRvIG5hbmQtY29udHJvbGxlci55YW1sIHlv dSBubyBsb25nZXIgbmVlZCB0aGVzZS4Kb2ssIGkgd2lsbCB0cnkgaXQuCj4gCj4+PiAgICAKPj4+ PiArCj4+Pj4gKyAgJyNzaXplLWNlbGxzJzoKPj4+PiArICAgIGNvbnN0OiAwCj4+Pgo+Pj4gRGl0 dG8uIFBsdXMsIHRoaXMgb25lIGxvb2tzIHdyb25nIGFueXdheS4KPj4gdGhpcyBpcyBmb3IgdGhl IHN1Ym5vZGUsIHN1Y2ggYXMgbmFuZEAwLiBkbyB5b3UgbWVhbiBzLycnLyIiLz8KPiAKPiBTb3Jy eSwgdGhpcyBpcyBub3QgIndyb25nIGFueXdheSIsIG15IGZhdWx0LiBCdXQgc3RpbGwsIHlvdSBk b24ndCBuZWVkCj4gdGhpcyBwcm9wZXJ0eSBmb3IgdGhlIHNhbWUgcmVhc29uIGFzIGFib3ZlLgpv ay4KPiAKPj4+ICAgIAo+Pj4+ICsKPj4+PiArICByZWctbmFtZXM6Cj4+Pj4gKyAgICBpdGVtczoK Pj4+PiArICAgICAgLSBjb25zdDogbmZjCj4+Pj4gKyAgICAgIC0gY29uc3Q6IGVtbWMKPj4+Cj4+ PiBXaHkgZG8geW91IG5lZWQgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwPyBEbyB5b3UgcmVhbGx5IG5l ZWQgdG8gcGVyZm9ybSBhCj4+PiByZWdpc3RlciBhY2Nlc3MgdGhlcmU/Cj4+IHllcywgd2UgaGF2 ZSB0byBhY2Nlc3MgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwLiBiZWNhdXNlIHRoZSBORkMgY2xvY2sg Y29tZXMgZnJvbSBTREVNTUNfQ0xPQ0sgcmVnaXN0ZXIuCj4gCj4gQnV0IGlmIGl0J3MgYSBjbG9j ayB5b3Ugc2hvdWxkIGdldCB0aGUgY2xvY2sgYW5kIGNhbGwKPiBjbGtfcHJlcGFyZV9lbmFibGUo KSwgeW91IGRvbid0IG5lZWQgdG8gcG9rZSBkaXJlY3RseSBpbiB0aGUgcmVnaXN0ZXJzLgo+IERv IHlvdT8KCm5vLCBpdCBkb2Vzbid0LiBpdCBpcyBzcGVjaWFsIGFuZCB0aGUgcmVhc29uIHdoeSBu ZWVkIHRvIGltcGxlbWVudCBhIE1NQyAKc3ViIGNsb2NrIGRyaXZlciBwcmV2aW91c2x5LiBhbHNv IHdlIGRvbid0IGltcGxlbWVudCBpdCBhcyBhIGNsb2NrIApwcm92aWRlciBpbiBkcml2ZXJzL2Ns ay9tZXNvbi8sIGJlY2F1c2UgdGhlIFNERU1NQ19DTE9DSyByZWdpc3RlciBpcyAKaW50ZXJuYWwg aW4gTUNJIGNvbnRyb2xsZXIuCj4gCj4+Pj4gK2V4YW1wbGVzOgo+Pj4+ICsgIC0gfAo+Pj4+ICsg ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2Nsb2NrL2F4Zy1jbGtjLmg+Cj4+Pj4gKyAgICAjaW5j bHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvYXJtLWdpYy5oPgo+Pj4+ICsg ICAgYXBiIHsKPj4+PiArICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cj4+Pj4gKyAgICAgICNz aXplLWNlbGxzID0gPDI+Owo+Pj4KPj4+IE5vdCBzdXJlIHlvdSBuZWVkIHRoaXMgdXBwZXIgbm9k ZSBpbiB0aGUgZXhhbXBsZS4KPj4gdXNlIHRoZSB1cHBlciBub2RlIHRvIGluZGljYXRlIHRoZSAi I2FkZHJlc3MtY2VsbHMiIGFuZCAiI3NpemUtY2VsbHMiLiBpZiBpIGRvIG5vdCBkbyB0aGF0LCBk dF9iaW5kaW5nX2NoZWNrIHdpbGwgcmVwb3J0Ogo+PiAgICAiLi4uLi5yZWc6MDogWzAsIDMwNzIw LCAwLCAyNTZdIGlzIHRvbyBsb25nIiBhbmQKPj4gICAgIi4uLi4ucmVnOjE6IFswLCAyODY3Miwg MCwgMjA0OF0gaXMgdG9vIGxvbmciLgo+IAo+IG9rLCBtYXliZSwgSSdsbCBsZXQgYmluZGluZ3Mg bWFpbnRhaW5lciByZXZpZXcgdGhhdC4KCm9rLiB0aGFua3MuCgo+IAo+Pj4gICAgCj4+Pj4gKyAg ICAgIG5hbmQtY29udHJvbGxlckA3ODAwIHsKPj4+PiArICAgICAgICAjYWRkcmVzcy1jZWxscyA9 IDwxPjsKPj4+PiArICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPj4+PiArICAgICAgICBjb21w YXRpYmxlID0gImFtbG9naWMsbWVzb24tYXhnLW5mYyI7Cj4+Pj4gKyAgICAgICAgcmVnID0gPDB4 MCAweDc4MDAgMHgwIDB4MTAwPiwKPj4+PiArICAgICAgICAgICAgICA8MHgwIDB4NzAwMCAweDAg MHg4MDA+Owo+Pj4+ICsgICAgICAgIHJlZy1uYW1lcyA9ICJuZmMiLCAiZW1tYyI7Cj4+Pj4gKwo+ Pj4+ICsgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAzNCBJUlFfVFlQRV9FREdFX1JJU0lO Rz47Cj4+Pj4gKyAgICAgICAgY2xvY2tzID0gPCZjbGtjIENMS0lEX1NEX0VNTUNfQz4sCj4+Pj4g KyAgICAgICAgICAgICAgICAgPCZjbGtjIENMS0lEX0ZDTEtfRElWMj47Cj4+Pj4gKyAgICAgICAg Y2xvY2stbmFtZXMgPSAiY29yZSIsICJkZXZpY2UiOwo+Pj4+ICsKPj4+PiArICAgICAgfTsKPj4+ PiArICAgIH07Cj4+Pj4gKy4uLgo+IAo+IAo+IFRoYW5rcywKPiBNaXF1w6hsCj4gCj4gLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4 IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 224CBC433EF for ; Wed, 20 Apr 2022 12:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EIkB9uGhmh1Wwa+7KAXyEfJ4FqaoOqFuUJdfr3wXD7s=; b=N8eeXFjR5zsvRp joIcT/Oh/R0znrBwkC0Wup1q2yhvPtH4bmPBEV3iZ6dHSvfkHbWBKn6DHH1udd2x0vvI/TOp09875 8Rv1CEPsZcA6g1pcbRKxVemN2Au5jp2B+yLtHuwpQsoRNFq4F2kDztwZielQyeD+x9oese55v2+9p TTSC354RJhVRiXAEdn9I94IghPiJ7FjYSbHXcR9b1LTA79WEsVp5x+1qvu0EmnoJad5woI9/Ie7IS JFbaiziBNFM3SX01czYt2hJqEVthlQl0ISlIcit8OloL2XHK4QJFRLtbhZ9WG0DLt5Q823PbCkGhs Mt3wxx8s9WTFs4FuqHdA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Yh-009034-Cr; Wed, 20 Apr 2022 12:35:47 +0000 Received: from mail-sz.amlogic.com ([211.162.65.117]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nh9Yd-009026-UT; Wed, 20 Apr 2022 12:35:45 +0000 Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Wed, 20 Apr 2022 20:35:41 +0800 Message-ID: Date: Wed, 20 Apr 2022 20:35:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 2/2] dt-bindings: nand: meson: refine Amlogic NAND controller driver Content-Language: en-US To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-3-liang.yang@amlogic.com> <20220420094107.4799f15a@xps13> <20220420141620.4fd68eef@xps13> From: Liang Yang In-Reply-To: <20220420141620.4fd68eef@xps13> X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_053544_052324_97935B95 X-CRM114-Status: GOOD ( 14.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTWlxdWVsLAoKT24gMjAyMi80LzIwIDIwOjE2LCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+IFsg RVhURVJOQUwgRU1BSUwgXQo+IAo+IEhpIExpYW5nLAo+IAo+Pj4+ICttYWludGFpbmVyczoKPj4+ PiArICAtIGxpYW5nLnlhbmdAYW1sb2dpYy5jb20KPj4+PiArCj4+Pj4gK3Byb3BlcnRpZXM6Cj4+ Pj4gKyAgY29tcGF0aWJsZToKPj4+PiArICAgIGVudW06Cj4+Pj4gKyAgICAgIC0gImFtbG9naWMs bWVzb24tZ3hsLW5mYyIKPj4+PiArICAgICAgLSAiYW1sb2dpYyxtZXNvbi1heGctbmZjIgo+Pj4+ ICsKPj4+PiArICByZWc6Cj4+Pj4gKyAgICBtYXhJdGVtczogMgo+Pj4+ICsKPj4+PiArICAnI2Fk ZHJlc3MtY2VsbHMnOgo+Pj4+ICsgICAgY29uc3Q6IDEKPj4+Cj4+PiBOb3Qgc3VyZSB0aGlzIHBy b3BlcnR5IGlzIG5lZWRlZC4KPj4gdGhpcyBpcyBmb3IgdGhlIHN1Ym5vZGUsIHN1Y2ggYXMgbmFu ZEAwLgo+IAo+IFllcyBidXQgaWYgeW91IHJlZmVyIHRvIG5hbmQtY29udHJvbGxlci55YW1sIHlv dSBubyBsb25nZXIgbmVlZCB0aGVzZS4Kb2ssIGkgd2lsbCB0cnkgaXQuCj4gCj4+PiAgICAKPj4+ PiArCj4+Pj4gKyAgJyNzaXplLWNlbGxzJzoKPj4+PiArICAgIGNvbnN0OiAwCj4+Pgo+Pj4gRGl0 dG8uIFBsdXMsIHRoaXMgb25lIGxvb2tzIHdyb25nIGFueXdheS4KPj4gdGhpcyBpcyBmb3IgdGhl IHN1Ym5vZGUsIHN1Y2ggYXMgbmFuZEAwLiBkbyB5b3UgbWVhbiBzLycnLyIiLz8KPiAKPiBTb3Jy eSwgdGhpcyBpcyBub3QgIndyb25nIGFueXdheSIsIG15IGZhdWx0LiBCdXQgc3RpbGwsIHlvdSBk b24ndCBuZWVkCj4gdGhpcyBwcm9wZXJ0eSBmb3IgdGhlIHNhbWUgcmVhc29uIGFzIGFib3ZlLgpv ay4KPiAKPj4+ICAgIAo+Pj4+ICsKPj4+PiArICByZWctbmFtZXM6Cj4+Pj4gKyAgICBpdGVtczoK Pj4+PiArICAgICAgLSBjb25zdDogbmZjCj4+Pj4gKyAgICAgIC0gY29uc3Q6IGVtbWMKPj4+Cj4+ PiBXaHkgZG8geW91IG5lZWQgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwPyBEbyB5b3UgcmVhbGx5IG5l ZWQgdG8gcGVyZm9ybSBhCj4+PiByZWdpc3RlciBhY2Nlc3MgdGhlcmU/Cj4+IHllcywgd2UgaGF2 ZSB0byBhY2Nlc3MgdGhlIGVtbWMgcmVnaXN0ZXIgbWFwLiBiZWNhdXNlIHRoZSBORkMgY2xvY2sg Y29tZXMgZnJvbSBTREVNTUNfQ0xPQ0sgcmVnaXN0ZXIuCj4gCj4gQnV0IGlmIGl0J3MgYSBjbG9j ayB5b3Ugc2hvdWxkIGdldCB0aGUgY2xvY2sgYW5kIGNhbGwKPiBjbGtfcHJlcGFyZV9lbmFibGUo KSwgeW91IGRvbid0IG5lZWQgdG8gcG9rZSBkaXJlY3RseSBpbiB0aGUgcmVnaXN0ZXJzLgo+IERv IHlvdT8KCm5vLCBpdCBkb2Vzbid0LiBpdCBpcyBzcGVjaWFsIGFuZCB0aGUgcmVhc29uIHdoeSBu ZWVkIHRvIGltcGxlbWVudCBhIE1NQyAKc3ViIGNsb2NrIGRyaXZlciBwcmV2aW91c2x5LiBhbHNv IHdlIGRvbid0IGltcGxlbWVudCBpdCBhcyBhIGNsb2NrIApwcm92aWRlciBpbiBkcml2ZXJzL2Ns ay9tZXNvbi8sIGJlY2F1c2UgdGhlIFNERU1NQ19DTE9DSyByZWdpc3RlciBpcyAKaW50ZXJuYWwg aW4gTUNJIGNvbnRyb2xsZXIuCj4gCj4+Pj4gK2V4YW1wbGVzOgo+Pj4+ICsgIC0gfAo+Pj4+ICsg ICAgI2luY2x1ZGUgPGR0LWJpbmRpbmdzL2Nsb2NrL2F4Zy1jbGtjLmg+Cj4+Pj4gKyAgICAjaW5j bHVkZSA8ZHQtYmluZGluZ3MvaW50ZXJydXB0LWNvbnRyb2xsZXIvYXJtLWdpYy5oPgo+Pj4+ICsg ICAgYXBiIHsKPj4+PiArICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cj4+Pj4gKyAgICAgICNz aXplLWNlbGxzID0gPDI+Owo+Pj4KPj4+IE5vdCBzdXJlIHlvdSBuZWVkIHRoaXMgdXBwZXIgbm9k ZSBpbiB0aGUgZXhhbXBsZS4KPj4gdXNlIHRoZSB1cHBlciBub2RlIHRvIGluZGljYXRlIHRoZSAi I2FkZHJlc3MtY2VsbHMiIGFuZCAiI3NpemUtY2VsbHMiLiBpZiBpIGRvIG5vdCBkbyB0aGF0LCBk dF9iaW5kaW5nX2NoZWNrIHdpbGwgcmVwb3J0Ogo+PiAgICAiLi4uLi5yZWc6MDogWzAsIDMwNzIw LCAwLCAyNTZdIGlzIHRvbyBsb25nIiBhbmQKPj4gICAgIi4uLi4ucmVnOjE6IFswLCAyODY3Miwg MCwgMjA0OF0gaXMgdG9vIGxvbmciLgo+IAo+IG9rLCBtYXliZSwgSSdsbCBsZXQgYmluZGluZ3Mg bWFpbnRhaW5lciByZXZpZXcgdGhhdC4KCm9rLiB0aGFua3MuCgo+IAo+Pj4gICAgCj4+Pj4gKyAg ICAgIG5hbmQtY29udHJvbGxlckA3ODAwIHsKPj4+PiArICAgICAgICAjYWRkcmVzcy1jZWxscyA9 IDwxPjsKPj4+PiArICAgICAgICAjc2l6ZS1jZWxscyA9IDwwPjsKPj4+PiArICAgICAgICBjb21w YXRpYmxlID0gImFtbG9naWMsbWVzb24tYXhnLW5mYyI7Cj4+Pj4gKyAgICAgICAgcmVnID0gPDB4 MCAweDc4MDAgMHgwIDB4MTAwPiwKPj4+PiArICAgICAgICAgICAgICA8MHgwIDB4NzAwMCAweDAg MHg4MDA+Owo+Pj4+ICsgICAgICAgIHJlZy1uYW1lcyA9ICJuZmMiLCAiZW1tYyI7Cj4+Pj4gKwo+ Pj4+ICsgICAgICAgIGludGVycnVwdHMgPSA8R0lDX1NQSSAzNCBJUlFfVFlQRV9FREdFX1JJU0lO Rz47Cj4+Pj4gKyAgICAgICAgY2xvY2tzID0gPCZjbGtjIENMS0lEX1NEX0VNTUNfQz4sCj4+Pj4g KyAgICAgICAgICAgICAgICAgPCZjbGtjIENMS0lEX0ZDTEtfRElWMj47Cj4+Pj4gKyAgICAgICAg Y2xvY2stbmFtZXMgPSAiY29yZSIsICJkZXZpY2UiOwo+Pj4+ICsKPj4+PiArICAgICAgfTsKPj4+ PiArICAgIH07Cj4+Pj4gKy4uLgo+IAo+IAo+IFRoYW5rcywKPiBNaXF1w6hsCj4gCj4gLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo=