From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29DAC636C9 for ; Sat, 17 Jul 2021 18:51:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4EA256100C for ; Sat, 17 Jul 2021 18:51:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EA256100C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B4C808D00F4; Sat, 17 Jul 2021 14:51:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AFC118D00EC; Sat, 17 Jul 2021 14:51:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 99C148D00F4; Sat, 17 Jul 2021 14:51:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 77DA08D00EC for ; Sat, 17 Jul 2021 14:51:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 100E12288B for ; Sat, 17 Jul 2021 18:51:45 +0000 (UTC) X-FDA: 78372973770.28.557B036 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf11.hostedemail.com (Postfix) with ESMTP id A28ACF000204 for ; Sat, 17 Jul 2021 18:51:44 +0000 (UTC) Received: by mail-pg1-f180.google.com with SMTP id w15so13827617pgk.13 for ; Sat, 17 Jul 2021 11:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7W9cdpcFBJJS0JLbmMCkBOvi8E5p+r1Z1gKFFynRQDU=; b=rsqMLJgcK6fq8G0MUqltjXw06Aq8/3ZpkYLJPYDFYKyPTBdSrwNwIThmxlkvH7Bld9 axVVt+nmfeUDQClTdycTcyLMAk6PM/rGoDdSEE7E38Zp/F9M8553U90UbubAcl7IOf3i G/V64Jm7ybdDURNn86qt0IInWc0jcZgE/VtVOXUBO8t7lUUmUdUU+XJtiAzmCGkIY+gZ zU+roz0sMtMvtPw7/azofKki4W0rRLdfMjsGzibf1bOpu7d6onnS9IuF8JWb9nLy5Cwc OXXncYWPhs+qBaSNv/jpwtGt2MaRRnvfS4ASvVIPajfDNZ8eXIFBSfSOI0rjetcx1pMu PYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7W9cdpcFBJJS0JLbmMCkBOvi8E5p+r1Z1gKFFynRQDU=; b=QB8kEXTB7yf1Ehp/0WsEcydISf/peNDhVatZJ+r0wtyhKsoYsIHEJ/Qvau/j+2C3yY au31/SQVLRnJ02W/y0XbVqaUgt18jBTT7fEvJIOhBSOhwSrh+3YuKwZX9TV0kQxIbV56 UX7PtZv6q9qewmAN9RCjxAfooth/JnBh7s2j5L1ul/qd3ZO+9xKGqKPsiFQdDlStezfs BT7GtJXLsSgkukO2JyShX3xp2X3l7aUdfWeok2G9KlHjB9/5uNFpbmMk3yZTvjggH89a mhg3vZsBVokoc9YRlvescmVD2xOm78N+aQQYhRe8QoDtnWNJAVychzMbSX+RJMT4uJyJ o23Q== X-Gm-Message-State: AOAM530F7knwUYJ4FJX5ux8c1sam7A5rEwdg3z7fpZgZDu7g7RwDhG3t SQoLZpreBKPA7mHxFqLJOp2m8w== X-Google-Smtp-Source: ABdhPJw9fhrPn1zhN3Vk4bwdofv4T2uk/0ucOIlqOKDQphxFTotdqQySRu8VhaEOk8QPp8CenbEfSA== X-Received: by 2002:aa7:8254:0:b029:2ed:b41:fefc with SMTP id e20-20020aa782540000b02902ed0b41fefcmr16847677pfn.42.1626547903015; Sat, 17 Jul 2021 11:51:43 -0700 (PDT) Received: from [192.168.1.187] ([198.8.77.61]) by smtp.gmail.com with ESMTPSA id bv22sm8386964pjb.21.2021.07.17.11.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jul 2021 11:51:42 -0700 (PDT) Subject: Re: [PATCH] memcg: charge io_uring related objects To: Shakeel Butt , Yutian Yang , Andrew Morton Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , shenwenbo@zju.edu.cn References: <1626519462-24400-1-git-send-email-nglaive@gmail.com> From: Jens Axboe Message-ID: Date: Sat, 17 Jul 2021 12:51:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=rsqMLJgc; spf=pass (imf11.hostedemail.com: domain of axboe@kernel.dk designates 209.85.215.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A28ACF000204 X-Stat-Signature: a965x5yjq58sow5h6rkmim6t8s6j4ott X-HE-Tag: 1626547904-608411 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/17/21 11:03 AM, Shakeel Butt wrote: > + Jens and Andrew A lot of these are probably (mostly) pointless to account, I suspect you'd get 99% of the way there by just doing io_mem_alloc(). But as far as the patch is concerned, looks fine to me. If we're doing all of them, then the patch is incomplete. If you send a v2 (that's for the original author) I'll be happy to get it queude for 5.14. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] memcg: charge io_uring related objects Date: Sat, 17 Jul 2021 12:51:39 -0600 Message-ID: References: <1626519462-24400-1-git-send-email-nglaive@gmail.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7W9cdpcFBJJS0JLbmMCkBOvi8E5p+r1Z1gKFFynRQDU=; b=rsqMLJgcK6fq8G0MUqltjXw06Aq8/3ZpkYLJPYDFYKyPTBdSrwNwIThmxlkvH7Bld9 axVVt+nmfeUDQClTdycTcyLMAk6PM/rGoDdSEE7E38Zp/F9M8553U90UbubAcl7IOf3i G/V64Jm7ybdDURNn86qt0IInWc0jcZgE/VtVOXUBO8t7lUUmUdUU+XJtiAzmCGkIY+gZ zU+roz0sMtMvtPw7/azofKki4W0rRLdfMjsGzibf1bOpu7d6onnS9IuF8JWb9nLy5Cwc OXXncYWPhs+qBaSNv/jpwtGt2MaRRnvfS4ASvVIPajfDNZ8eXIFBSfSOI0rjetcx1pMu PYaA== In-Reply-To: Content-Language: en-US List-ID: Content-Type: text/plain; charset="us-ascii" To: Shakeel Butt , Yutian Yang , Andrew Morton Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Cgroups , Linux MM , shenwenbo-Y5EWUtBUdg4nDS1+zs4M5A@public.gmane.org On 7/17/21 11:03 AM, Shakeel Butt wrote: > + Jens and Andrew A lot of these are probably (mostly) pointless to account, I suspect you'd get 99% of the way there by just doing io_mem_alloc(). But as far as the patch is concerned, looks fine to me. If we're doing all of them, then the patch is incomplete. If you send a v2 (that's for the original author) I'll be happy to get it queude for 5.14. -- Jens Axboe