From: Beat Bolli <dev+git@drbeat.li>
To: Ariadne Conill <ariadne@dereferenced.org>, git@vger.kernel.org
Subject: Re: [PATCH v2 3/3] tests: add test for git log --no-use-mailmap
Date: Thu, 11 Jul 2019 19:32:51 +0200 [thread overview]
Message-ID: <f2cd0072-95de-3e60-d860-a5dd2c58c41a@drbeat.li> (raw)
In-Reply-To: <20190711172626.16480-4-ariadne@dereferenced.org>
On 11.07.19 19:26, Ariadne Conill wrote:
> In order to prove that the --no-use-mailmap option works as expected,
> we add a test for it which runs with -Dlog.mailmap=true to ensure that
s/-D/-c /
This ain't Java :-)
> the option successfully negates the configured default.
>
> Signed-off-by: Ariadne Conill <ariadne@dereferenced.org>
> ---
> t/t4203-mailmap.sh | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/t/t4203-mailmap.sh b/t/t4203-mailmap.sh
> index 43b1522ea2..23a8947bce 100755
> --- a/t/t4203-mailmap.sh
> +++ b/t/t4203-mailmap.sh
> @@ -465,6 +465,14 @@ test_expect_success 'Only grep replaced author with --use-mailmap' '
> git log --use-mailmap --author "<cto@coompany.xx>" >actual &&
> test_must_be_empty actual
> '
> +cat >expect <<\EOF
> +Author: santa <me@company.xx>
> +EOF
> +
> +test_expect_success 'Grep author with --no-use-mailmap + log.mailmap=True' '
> + git -c log.mailmap=True log --no-use-mailmap --author santa | grep Author >actual &&
> + test_cmp expect actual
> +'
>
> # git blame
> cat >expect <<\EOF
>
Cheers,
Beat
next prev parent reply other threads:[~2019-07-11 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 17:26 [PATCH v2 0/3] use mailmap by default in git log Ariadne Conill
2019-07-11 17:26 ` [PATCH v2 1/3] log: use mailmap by default Ariadne Conill
2019-07-11 17:26 ` [PATCH v2 2/3] log: add --no-use-mailmap option to complement --use-mailmap option Ariadne Conill
2019-07-11 18:24 ` Beat Bolli
2019-07-11 18:25 ` Ariadne Conill
2019-07-11 18:27 ` Beat Bolli
2019-07-11 17:26 ` [PATCH v2 3/3] tests: add test for git log --no-use-mailmap Ariadne Conill
2019-07-11 17:32 ` Beat Bolli [this message]
2019-07-11 17:38 ` Ariadne Conill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2cd0072-95de-3e60-d860-a5dd2c58c41a@drbeat.li \
--to=dev+git@drbeat.li \
--cc=ariadne@dereferenced.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.