From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77D9C433E9 for ; Fri, 22 Jan 2021 15:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 765CB23AC9 for ; Fri, 22 Jan 2021 15:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729045AbhAVP3M (ORCPT ); Fri, 22 Jan 2021 10:29:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728697AbhAVP3B (ORCPT ); Fri, 22 Jan 2021 10:29:01 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B576AC061786; Fri, 22 Jan 2021 07:28:20 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id o10so8011695lfl.13; Fri, 22 Jan 2021 07:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ISQKWjgPbcA/Ev2c4Dpj7JuqMDl83n77M+ggmuFw+pg=; b=dmzoTzYkZa7zRgygbr3mVegm7/sSaiMmR4RVw3M0mqAtfAoDB6XXewgJnlYDtkBuam F9bWa423mWu4Wijewx2OnQDBOIZuy9V/4v673kVolbgAankkGZhMZdeR+BMlOdtGICe1 Eksl/DHbz7pG8KNfGc9Fh0o9IjVB3UwI6IECSx7Y1C3p1TH0bnwyGfw1ysNkTgmfnc8C kNpIIrtnmEB/Ww/FDgjE10+JmGaNJawt2KpUfBdXgyrnZK1HnWpg9PJWBO360XYAdR+0 Cknwdaltai7YIbG2ojLtq1UrywWnOnd8c89KoKJBwt4OJlBoUsSmcHeARDvK5K5wDlBU Nl1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ISQKWjgPbcA/Ev2c4Dpj7JuqMDl83n77M+ggmuFw+pg=; b=bwaquGBytYcbDAy1izD3d4P8Rh+6cdyVg1SZ98A8X1hjmMJh5uEK0+C5cElYI3pBkX L/yGPdX4xGShk5QnncnBcz919O/IkhRQX2DFLpdqes3PtB2xb5L03FOYGUilgPcHLwqt CLEoyqLB/gc1wPa64MB1VFDIYKS1dWEWWPtn4DKKtjrq2TCs+yfdaXB9mRPJuL5hZSnr 2FXklmC7D7HmKQ/ay+tUe18uHV6DyrQ0dK6VpnwDk4wwIpYkd9F+ZsugCBJ2gncX4gCk b3DycWOwuyKQ8oiNoum8MRnUlCbykLk8GKAF6nQ7Qw+8ggyI/97ktJgKOnRkcpjIRDxz NDhw== X-Gm-Message-State: AOAM530cRZ2otYHCXOGXxH2w40ze7wVOu9PUjP/JelSpa8au/+DP1s71 QgWhXVYjpUDzT/rTXOanXzk1TZh5LtA= X-Google-Smtp-Source: ABdhPJzwGQlG1MHqbBIRIHds0kbrQeg1FOtQon6lZaFzU702grDxctXDFHfPTYD/1lhQxfZk3d3pqg== X-Received: by 2002:ac2:5e2a:: with SMTP id o10mr93571lfg.481.1611329299125; Fri, 22 Jan 2021 07:28:19 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id a23sm920989lfm.125.2021.01.22.07.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 07:28:18 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar Cc: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Thierry Reding , Jonathan Hunter , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Sibi Sankar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Fri, 22 Jan 2021 18:28:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210122062659.qss3hef4kltfgciu@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 22.01.2021 09:26, Viresh Kumar пишет: > On 22-01-21, 00:36, Dmitry Osipenko wrote: >> 21.01.2021 14:17, Viresh Kumar пишет: >>> dev_pm_opp_set_bw() is getting removed and dev_pm_opp_set_opp() should >>> be used instead. Migrate to the new API. >>> >>> Signed-off-by: Viresh Kumar >>> --- >>> drivers/devfreq/tegra30-devfreq.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c >>> index 117cad7968ab..d2477d7d1f66 100644 >>> --- a/drivers/devfreq/tegra30-devfreq.c >>> +++ b/drivers/devfreq/tegra30-devfreq.c >>> @@ -647,7 +647,7 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq, >>> return PTR_ERR(opp); >>> } >>> >>> - ret = dev_pm_opp_set_bw(dev, opp); >>> + ret = dev_pm_opp_set_opp(dev, opp); >>> dev_pm_opp_put(opp); >>> >>> return ret; >>> >> >> This patch introduces a very serious change that needs to be fixed. >> >> Now dev_pm_opp_set_opp() changes both clock rate and bandwidth, this is >> unacceptable for this driver because it shall not touch the clock rate. >> >> I think dev_pm_opp_set_bw() can't be removed. > > I am wondering here on what would be a better solution, do what you > said or introduce another helper like dev_pm_opp_clear_clk(), which > will make sure the OPP core doesn't play with device's clk. > Either way will work, but maybe keeping the dev_pm_opp_set_bw() is a bit more straightforward variant for now since it will avoid the code's changes and it's probably a bit more obvious variant for the OPP users. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AE6CC433DB for ; Fri, 22 Jan 2021 15:29:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5058223A9A for ; Fri, 22 Jan 2021 15:29:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5058223A9A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sv2eQvB3/ugrViiUNsLZRKueWiPgLkfwDpwWLXPojdw=; b=bDsb3o/bqI4URrMToSPpUeUrC xIw8B+PdeOKBGDndgxsfWuKsdFobyKXkLivG+CZTdnpS2O29ts5Wls9jL6/jnawncRzX8Vn0r9KlD d7D1/49CzWvT45qeV8XZVLwTJqd2X+K4Oge/w9O0UKGRGezVQPnGkEXemYaKEP0ke0fgUqcp0/Dim PZxG4ocnqA67bW0+XJahHQS1hdXiEG4NeAhc/UK2Lbs5P55fdf6/T+FIV0a0IDEOkyua2JdBmc3lW tkbqvQ2tKvymffmcst7+0o7Y95OuI1+EGoGrC/a4BsUC9cobIu8pnsGE0tCxKU+tVQzfswUjCbLDH 97jPz4cqg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2yMJ-0002iF-1j; Fri, 22 Jan 2021 15:28:23 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2yMG-0002ht-Jt for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 15:28:21 +0000 Received: by mail-lf1-x12f.google.com with SMTP id v24so8058761lfr.7 for ; Fri, 22 Jan 2021 07:28:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ISQKWjgPbcA/Ev2c4Dpj7JuqMDl83n77M+ggmuFw+pg=; b=dmzoTzYkZa7zRgygbr3mVegm7/sSaiMmR4RVw3M0mqAtfAoDB6XXewgJnlYDtkBuam F9bWa423mWu4Wijewx2OnQDBOIZuy9V/4v673kVolbgAankkGZhMZdeR+BMlOdtGICe1 Eksl/DHbz7pG8KNfGc9Fh0o9IjVB3UwI6IECSx7Y1C3p1TH0bnwyGfw1ysNkTgmfnc8C kNpIIrtnmEB/Ww/FDgjE10+JmGaNJawt2KpUfBdXgyrnZK1HnWpg9PJWBO360XYAdR+0 Cknwdaltai7YIbG2ojLtq1UrywWnOnd8c89KoKJBwt4OJlBoUsSmcHeARDvK5K5wDlBU Nl1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ISQKWjgPbcA/Ev2c4Dpj7JuqMDl83n77M+ggmuFw+pg=; b=Z2o1w7nWTcr6lWEzfFtdOAu98R4axGNII+c30mk7FQgkgEcnXMuxrdUhgvQ6bJQLJp sYArjykW2uvkWZ7CuX/bSnjkQSch7kF9nBi6S9w10Ke2bR6IHdI8m/trU8PXeGdgwl8O fPqPk6BT0iZG6pHnTfnXEOiS4l9aJYoDLWw7g4gIbK824n0L3u8orTYQ1AMWN9mXudSf ICtcmmKsrZObHAjELhqe7CObwFnn/QS5QCA3c9D9gIMjl2YxSWhhRTYJDgah3P6+K5p2 NW5toAbf4DETHmPyBvZgJEI/rwvV53rHQzo5MksKrLN+joxxhdnIvUP/rL15QkTwM/pU UReA== X-Gm-Message-State: AOAM530iAyYqm5EWrc2x9d6Z8WkBqgEZ5cw0AaM0HIOF8u1J9kJq2nip xjU8ELBj5o4r9o6cz8b/cPA= X-Google-Smtp-Source: ABdhPJzwGQlG1MHqbBIRIHds0kbrQeg1FOtQon6lZaFzU702grDxctXDFHfPTYD/1lhQxfZk3d3pqg== X-Received: by 2002:ac2:5e2a:: with SMTP id o10mr93571lfg.481.1611329299125; Fri, 22 Jan 2021 07:28:19 -0800 (PST) Received: from [192.168.2.145] (109-252-192-57.dynamic.spd-mgts.ru. [109.252.192.57]) by smtp.googlemail.com with ESMTPSA id a23sm920989lfm.125.2021.01.22.07.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 07:28:18 -0800 (PST) Subject: Re: [PATCH 11/13] devfreq: tegra30: Migrate to dev_pm_opp_set_opp() To: Viresh Kumar References: <3345fd49f7987d022f4f61edb6c44f230f7354c4.1611227342.git.viresh.kumar@linaro.org> <71451eb2-46b2-1ea0-efcc-0811568159a4@gmail.com> <20210122062659.qss3hef4kltfgciu@vireshk-i7> From: Dmitry Osipenko Message-ID: Date: Fri, 22 Jan 2021 18:28:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.2 MIME-Version: 1.0 In-Reply-To: <20210122062659.qss3hef4kltfgciu@vireshk-i7> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_102820_685633_0C7E9CB7 X-CRM114-Status: GOOD ( 18.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Vincent Guittot , linux-pm@vger.kernel.org, Stephen Boyd , Rafael Wysocki , linux-kernel@vger.kernel.org, Jonathan Hunter , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , Thierry Reding , Sibi Sankar , linux-tegra@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org MjIuMDEuMjAyMSAwOToyNiwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjItMDEtMjEs IDAwOjM2LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IDIxLjAxLjIwMjEgMTQ6MTcsIFZpcmVz aCBLdW1hciDQv9C40YjQtdGCOgo+Pj4gZGV2X3BtX29wcF9zZXRfYncoKSBpcyBnZXR0aW5nIHJl bW92ZWQgYW5kIGRldl9wbV9vcHBfc2V0X29wcCgpIHNob3VsZAo+Pj4gYmUgdXNlZCBpbnN0ZWFk LiBNaWdyYXRlIHRvIHRoZSBuZXcgQVBJLgo+Pj4KPj4+IFNpZ25lZC1vZmYtYnk6IFZpcmVzaCBL dW1hciA8dmlyZXNoLmt1bWFyQGxpbmFyby5vcmc+Cj4+PiAtLS0KPj4+ICBkcml2ZXJzL2RldmZy ZXEvdGVncmEzMC1kZXZmcmVxLmMgfCAyICstCj4+PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4+Pgo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZGV2ZnJl cS90ZWdyYTMwLWRldmZyZXEuYyBiL2RyaXZlcnMvZGV2ZnJlcS90ZWdyYTMwLWRldmZyZXEuYwo+ Pj4gaW5kZXggMTE3Y2FkNzk2OGFiLi5kMjQ3N2Q3ZDFmNjYgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2 ZXJzL2RldmZyZXEvdGVncmEzMC1kZXZmcmVxLmMKPj4+ICsrKyBiL2RyaXZlcnMvZGV2ZnJlcS90 ZWdyYTMwLWRldmZyZXEuYwo+Pj4gQEAgLTY0Nyw3ICs2NDcsNyBAQCBzdGF0aWMgaW50IHRlZ3Jh X2RldmZyZXFfdGFyZ2V0KHN0cnVjdCBkZXZpY2UgKmRldiwgdW5zaWduZWQgbG9uZyAqZnJlcSwK Pj4+ICAJCXJldHVybiBQVFJfRVJSKG9wcCk7Cj4+PiAgCX0KPj4+ICAKPj4+IC0JcmV0ID0gZGV2 X3BtX29wcF9zZXRfYncoZGV2LCBvcHApOwo+Pj4gKwlyZXQgPSBkZXZfcG1fb3BwX3NldF9vcHAo ZGV2LCBvcHApOwo+Pj4gIAlkZXZfcG1fb3BwX3B1dChvcHApOwo+Pj4gIAo+Pj4gIAlyZXR1cm4g cmV0Owo+Pj4KPj4KPj4gVGhpcyBwYXRjaCBpbnRyb2R1Y2VzIGEgdmVyeSBzZXJpb3VzIGNoYW5n ZSB0aGF0IG5lZWRzIHRvIGJlIGZpeGVkLgo+Pgo+PiBOb3cgZGV2X3BtX29wcF9zZXRfb3BwKCkg Y2hhbmdlcyBib3RoIGNsb2NrIHJhdGUgYW5kIGJhbmR3aWR0aCwgdGhpcyBpcwo+PiB1bmFjY2Vw dGFibGUgZm9yIHRoaXMgZHJpdmVyIGJlY2F1c2UgaXQgc2hhbGwgbm90IHRvdWNoIHRoZSBjbG9j ayByYXRlLgo+Pgo+PiBJIHRoaW5rIGRldl9wbV9vcHBfc2V0X2J3KCkgY2FuJ3QgYmUgcmVtb3Zl ZC4KPiAKPiBJIGFtIHdvbmRlcmluZyBoZXJlIG9uIHdoYXQgd291bGQgYmUgYSBiZXR0ZXIgc29s dXRpb24sIGRvIHdoYXQgeW91Cj4gc2FpZCBvciBpbnRyb2R1Y2UgYW5vdGhlciBoZWxwZXIgbGlr ZSBkZXZfcG1fb3BwX2NsZWFyX2NsaygpLCB3aGljaAo+IHdpbGwgbWFrZSBzdXJlIHRoZSBPUFAg Y29yZSBkb2Vzbid0IHBsYXkgd2l0aCBkZXZpY2UncyBjbGsuCj4gCgpFaXRoZXIgd2F5IHdpbGwg d29yaywgYnV0IG1heWJlIGtlZXBpbmcgdGhlIGRldl9wbV9vcHBfc2V0X2J3KCkgaXMgYSBiaXQK bW9yZSBzdHJhaWdodGZvcndhcmQgdmFyaWFudCBmb3Igbm93IHNpbmNlIGl0IHdpbGwgYXZvaWQg dGhlIGNvZGUncwpjaGFuZ2VzIGFuZCBpdCdzIHByb2JhYmx5IGEgYml0IG1vcmUgb2J2aW91cyB2 YXJpYW50IGZvciB0aGUgT1BQIHVzZXJzLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=