From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF2F1C5DF60 for ; Fri, 8 Nov 2019 10:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA92721D6C for ; Fri, 8 Nov 2019 10:59:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731299AbfKHK7d (ORCPT ); Fri, 8 Nov 2019 05:59:33 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:54980 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730224AbfKHK7c (ORCPT ); Fri, 8 Nov 2019 05:59:32 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iT1zG-00009u-Nh; Fri, 08 Nov 2019 11:59:30 +0100 Message-ID: Subject: Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Kan Yan , Rajkumar Manoharan , Kevin Hayes Date: Fri, 08 Nov 2019 11:59:28 +0100 In-Reply-To: <87a796fxgd.fsf@toke.dk> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> <87a796fxgd.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-11-08 at 11:56 +0100, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > On Wed, 2019-10-23 at 11:59 +0200, Toke Høiland-Jørgensen wrote: > > > > > > +void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local, > > > + struct sta_info *sta, u8 ac, > > > + u16 tx_airtime, bool tx_completed) > > > +{ > > > + spin_lock_bh(&local->active_txq_lock[ac]); > > > + if (tx_completed) { > > > + if (sta) { > > > + if (WARN_ONCE(sta->airtime[ac].aql_tx_pending < tx_airtime, > > > + "TXQ pending airtime underflow: %u, %u", > > > + sta->airtime[ac].aql_tx_pending, tx_airtime)) > > > > Maybe add the STA/AC to the message? > > Can do. Any idea why we might be seeing underflows (as Kan reported)? No, I really have no idea. The shifting looked OK to me, though I didn't review it carefully enough to say I've really looked at all places ... johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT1zK-0005GK-Bn for ath10k@lists.infradead.org; Fri, 08 Nov 2019 10:59:36 +0000 Message-ID: Subject: Re: [PATCH v6 3/4] mac80211: Implement Airtime-based Queue Limit (AQL) From: Johannes Berg Date: Fri, 08 Nov 2019 11:59:28 +0100 In-Reply-To: <87a796fxgd.fsf@toke.dk> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474287.150713.12867638269538730397.stgit@toke.dk> <1a2eb096119c9029e67caf797564d6511c8803a7.camel@sipsolutions.net> <87a796fxgd.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Kan Yan , Rajkumar Manoharan , Kevin Hayes , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau T24gRnJpLCAyMDE5LTExLTA4IGF0IDExOjU2ICswMTAwLCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5z ZW4gd3JvdGU6Cj4gSm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3Jp dGVzOgo+IAo+ID4gT24gV2VkLCAyMDE5LTEwLTIzIGF0IDExOjU5ICswMjAwLCBUb2tlIEjDuGls YW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4gPiA+ICAKPiA+ID4gK3ZvaWQgaWVlZTgwMjExX3N0YV91 cGRhdGVfcGVuZGluZ19haXJ0aW1lKHN0cnVjdCBpZWVlODAyMTFfbG9jYWwgKmxvY2FsLAo+ID4g PiArCQkJCQkgIHN0cnVjdCBzdGFfaW5mbyAqc3RhLCB1OCBhYywKPiA+ID4gKwkJCQkJICB1MTYg dHhfYWlydGltZSwgYm9vbCB0eF9jb21wbGV0ZWQpCj4gPiA+ICt7Cj4gPiA+ICsJc3Bpbl9sb2Nr X2JoKCZsb2NhbC0+YWN0aXZlX3R4cV9sb2NrW2FjXSk7Cj4gPiA+ICsJaWYgKHR4X2NvbXBsZXRl ZCkgewo+ID4gPiArCQlpZiAoc3RhKSB7Cj4gPiA+ICsJCQlpZiAoV0FSTl9PTkNFKHN0YS0+YWly dGltZVthY10uYXFsX3R4X3BlbmRpbmcgPCB0eF9haXJ0aW1lLAo+ID4gPiArCQkJCSAgICAgICJU WFEgcGVuZGluZyBhaXJ0aW1lIHVuZGVyZmxvdzogJXUsICV1IiwKPiA+ID4gKwkJCQkgICAgICBz dGEtPmFpcnRpbWVbYWNdLmFxbF90eF9wZW5kaW5nLCB0eF9haXJ0aW1lKSkKPiA+IAo+ID4gTWF5 YmUgYWRkIHRoZSBTVEEvQUMgdG8gdGhlIG1lc3NhZ2U/Cj4gCj4gQ2FuIGRvLiBBbnkgaWRlYSB3 aHkgd2UgbWlnaHQgYmUgc2VlaW5nIHVuZGVyZmxvd3MgKGFzIEthbiByZXBvcnRlZCk/CgpObywg SSByZWFsbHkgaGF2ZSBubyBpZGVhLiBUaGUgc2hpZnRpbmcgbG9va2VkIE9LIHRvIG1lLCB0aG91 Z2ggSSBkaWRuJ3QKcmV2aWV3IGl0IGNhcmVmdWxseSBlbm91Z2ggdG8gc2F5IEkndmUgcmVhbGx5 IGxvb2tlZCBhdCBhbGwgcGxhY2VzIC4uLgoKam9oYW5uZXMKCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0Bs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vYXRoMTBrCg==