All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: Hemant Kumar <hemantk@codeaurora.org>,
	Paul Davey <paul.davey@alliedtelesis.co.nz>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	hemantk=codeaurora.org@codeaurora.org
Subject: Re: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness
Date: Thu, 15 Jul 2021 17:35:38 -0700	[thread overview]
Message-ID: <f396b676cf96a7b7e5e26edf9f45e9ae@codeaurora.org> (raw)
In-Reply-To: <1625104371.10055.21.camel@codeaurora.org>

Hi Paul,

On 2021-06-30 06:52 PM, Hemant Kumar wrote:
> Hi Paul,
> On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
>> The MHI driver does not work on big endian architectures.  The
>> controller never transitions into mission mode.  This appears to be
>> due
>> to the modem device expecting the various contexts and transfer rings
>> to
>> have fields in little endian order in memory, but the driver
>> constructs
>> them in native endianness.
>> 
>> Fix MHI event, channel and command contexts and TRE handling macros
>> to
>> use explicit conversion to little endian.  Mark fields in relevant
>> structures as little endian to document this requirement.
>> 
>> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
>> ---
>> Removed Tested-by as patch has changed somewhat from v2.
> Bhaumik is going to help testing V2 on x86 platform. Change looks good
> to me. Will ack it once testing is done.
>>  [..]
>> 
> 
> Thanks,
> Hemant

Just following up on this one. I have been seeing problems with my setup 
and
will try to get to this test next week.

Thanks,
Bhaumik
---
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2021-07-16  0:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29  3:53 [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-29  3:53 ` [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string Paul Davey
2021-07-01  1:50   ` Hemant Kumar
2021-07-16  5:35   ` Manivannan Sadhasivam
2021-06-29  3:53 ` [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-07-01  1:52   ` Hemant Kumar
2021-07-16  0:35     ` Bhaumik Bhatt [this message]
2021-07-16  5:43 ` [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f396b676cf96a7b7e5e26edf9f45e9ae@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=hemantk=codeaurora.org@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=paul.davey@alliedtelesis.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.