From mboxrd@z Thu Jan 1 00:00:00 1970 From: Blue Swirl Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c Date: Tue, 30 Mar 2010 20:06:36 +0300 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: joro@8bytes.org, aliguori@us.ibm.com, avi@redhat.com, kvm@vger.kernel.org, qemu-devel@nongnu.org To: Eduard - Gabriel Munteanu Return-path: Received: from mail-pz0-f194.google.com ([209.85.222.194]:35497 "EHLO mail-pz0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752510Ab0C3RGg (ORCPT ); Tue, 30 Mar 2010 13:06:36 -0400 Received: by pzk32 with SMTP id 32so4751553pzk.4 for ; Tue, 30 Mar 2010 10:06:36 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 3/30/10, Eduard - Gabriel Munteanu wrote: > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > AMD IOMMU, which could lead to confusion unless we rename the former. I was also thinking of renaming the file some time ago. The correct name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had several IO-UNITs instead. All Sun4m machines had an IOMMU. But the qdev name of the device is still "iommu" and we can't change that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside in amd_iommu.c? From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nwetk-0000v4-Gz for qemu-devel@nongnu.org; Tue, 30 Mar 2010 13:06:40 -0400 Received: from [140.186.70.92] (port=55254 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwetj-0000uq-8A for qemu-devel@nongnu.org; Tue, 30 Mar 2010 13:06:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nweth-0000pr-Am for qemu-devel@nongnu.org; Tue, 30 Mar 2010 13:06:38 -0400 Received: from mail-pw0-f45.google.com ([209.85.160.45]:54541) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nweth-0000pn-2u for qemu-devel@nongnu.org; Tue, 30 Mar 2010 13:06:37 -0400 Received: by pwi6 with SMTP id 6so378930pwi.4 for ; Tue, 30 Mar 2010 10:06:36 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 30 Mar 2010 20:06:36 +0300 Message-ID: Subject: Re: [Qemu-devel] [RFC PATCH 4/7] sparc: rename hw/iommu.c From: Blue Swirl Content-Type: text/plain; charset=UTF-8 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduard - Gabriel Munteanu Cc: qemu-devel@nongnu.org, joro@8bytes.org, aliguori@us.ibm.com, kvm@vger.kernel.org, avi@redhat.com On 3/30/10, Eduard - Gabriel Munteanu wrote: > hw/iommu.c concerns the SPARC IOMMU. However we intend to implement the > AMD IOMMU, which could lead to confusion unless we rename the former. I was also thinking of renaming the file some time ago. The correct name would be "sun4m_iommu.c". Sun4c (while still Sparc based) had a different architecture (IIRC CPU MMU doubled as IOMMU) and Sun4d had several IO-UNITs instead. All Sun4m machines had an IOMMU. But the qdev name of the device is still "iommu" and we can't change that. So I'm not so sure it's worth renaming. Can't AMD IOMMU reside in amd_iommu.c?