Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time

From: Julien Grall <julien@xen.org>
To: Luca Fancellu <Luca.Fancellu@arm.com>
Cc: Xen developer discussion <xen-devel@lists.xenproject.org>,
	Bertrand Marquis <Bertrand.Marquis@arm.com>,
	Wei Chen <Wei.Chen@arm.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Wei Liu <wl@xen.org>,
	Juergen Gross <jgross@suse.com>,
	Dario Faggioli <dfaggioli@suse.com>
Subject: Re: [PATCH v5 4/6] xen/cpupool: Create different cpupools at boot time
Date: Thu, 7 Apr 2022 15:36:18 +0100	[thread overview]
Message-ID: <f4d76d05-fc42-f417-3704-1b7608954028@xen.org> (raw)
In-Reply-To: <475D681D-9D0C-4302-B1CD-B8BD2E7D95AE@arm.com>

Hi Luca,

On 07/04/2022 10:52, Luca Fancellu wrote:
>>> +void __init btcpupools_dtb_parse(void)
>>> +{
>>> +    const struct dt_device_node *chosen, *node;
>>> +
>>> +    chosen = dt_find_node_by_path("/chosen");
>>> +    if ( !chosen )
>>> +        return;
>> Aside when using ACPI, the chosen node should always be there. So I think we should throw/print an error if chosen is not present.
> 
> When you say error, do you mean like a panic or just a printk XENLOG_ERR and return?

You seem to use panic() below. So I would also use panic() here as this 
shouldn't be expected.

Cheers,

-- 
Julien Grall