All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick DELAUNAY <patrick.delaunay@foss.st.com>
To: Patrice Chotard <patrice.chotard@foss.st.com>, <u-boot@lists.denx.de>
Cc: U-Boot STM32 <uboot-stm32@st-md-mailman.stormreply.com>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Manuel Reis <mluis.reis@gmail.com>,
	Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board
Date: Fri, 3 Sep 2021 10:30:48 +0200	[thread overview]
Message-ID: <f88ba548-d277-dbe7-a29b-59883a895eaa@foss.st.com> (raw)
In-Reply-To: <20210901095143.4143-1-patrice.chotard@foss.st.com>

Hi,

On 9/1/21 11:51 AM, Patrice Chotard wrote:
> DM_GPIO_HOG flag has been replaced by GPIO_HOG flag since a while in
> commit 49b10cb49262 ("gpio: fixes for gpio-hog support").
>
> And furthermore, gpio_hog_probe_all() is already called in board_r.c.
> So gpio_hog_probe() can be removed from stm32mp1.c.
>
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>
>   board/st/stm32mp1/stm32mp1.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/board/st/stm32mp1/stm32mp1.c b/board/st/stm32mp1/stm32mp1.c
> index 032f08d795..b5500399e6 100644
> --- a/board/st/stm32mp1/stm32mp1.c
> +++ b/board/st/stm32mp1/stm32mp1.c
> @@ -649,9 +649,6 @@ int board_init(void)
>   	/* address of boot parameters */
>   	gd->bd->bi_boot_params = STM32_DDR_BASE + 0x100;
>   
> -	if (CONFIG_IS_ENABLED(DM_GPIO_HOG))
> -		gpio_hog_probe_all();
> -
>   	board_key_check();
>   
>   	if (board_is_ev1())


Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>

Thanks
Patrick


      parent reply	other threads:[~2021-09-03  8:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01  9:51 [PATCH 1/2] board: stm32mp1: Remove gpio_hog_probe_all() from board Patrice Chotard
2021-09-01  9:51 ` [PATCH 2/2] board: dh_stm32mp1: " Patrice Chotard
2021-09-03  8:31   ` Patrick DELAUNAY
2021-10-08  6:46     ` Patrice CHOTARD
2021-09-03 13:02   ` Marek Vasut
2021-10-08  6:47     ` Patrice CHOTARD
2021-09-03  8:30 ` Patrick DELAUNAY [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f88ba548-d277-dbe7-a29b-59883a895eaa@foss.st.com \
    --to=patrick.delaunay@foss.st.com \
    --cc=jh80.chung@samsung.com \
    --cc=mluis.reis@gmail.com \
    --cc=patrice.chotard@foss.st.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-stm32@st-md-mailman.stormreply.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.