From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C1A7C433EF for ; Tue, 5 Jul 2022 13:42:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229603AbiGENmq (ORCPT ); Tue, 5 Jul 2022 09:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233245AbiGENmb (ORCPT ); Tue, 5 Jul 2022 09:42:31 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8D282BB08 for ; Tue, 5 Jul 2022 06:06:21 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id y16so20403808lfb.9 for ; Tue, 05 Jul 2022 06:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ioYfpThi9nRqg/GAIvq073p5ZZ7ox+oQ40EYBD9d07g=; b=v05hZ3sTiVWV3MwWmpC2T5XDz1MtkZv1o3pEj6pQYcF7zeW4KUig1Ul0jfhgbR69DB OcrOOzuu5TqnO96WcR3mDTvR1ESoledOIRnzTqTLQ062q6+vTrk/wzrKD5zFNVMdtmhk /kfYPoVMbpV0fDezcBk4JF9/v2/QS2ZZB4CKu8wswVhJlOdMimQrTdI7ySU2eDoEGTWe JUxQp+JzUR1cYZ3Q8k57hbe3HBeV6FFD4OmXi6fByUR3WOfjc8Mfb9fWLwSrNG40RTNH LpWbM6gID07GZTgKTI5XtiEIKGBq16wbXTssI9Ym45rH+Vlk642qDgWNKgmdbV6Qe7PM xViA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ioYfpThi9nRqg/GAIvq073p5ZZ7ox+oQ40EYBD9d07g=; b=Nz2kKtsA44UlPxbEhlh/NSTG6owy/FyOmpEvPAikCWCgJSm/nC9Yz/lrvnab9Umpds 79OcDsL48BTPn9vHC1KeaL3Yg4mW6crON/WT3adeqfkf3gWjbx3xo85koI/t28Fzuhjn 3bFNkZhzh0/3Yprbl1gSbCvgoju3v9RoQCixCqbtb4Esu5/VhKnpvvhGq2c2QRhnkRKS teSNMoG1kFSn81x4bs41daZKJV47Au7Otycl940Y02QhYIAX3DGJBaLeHCodaBNxbAXC bSU0ntJmArXodpHssDf4uWKAPvdRDTjTBrRjlkjSCX+mQJhL34nr3zGwFsKMCpcGfLMe Og5w== X-Gm-Message-State: AJIora9/SO6PbBw7Z3GQJRUiT61EB3Mec9O2oGmqbC/SrEZID7GoRiqY ao/BOkW1ULbWd1TW878hDLI1Dw== X-Google-Smtp-Source: AGRyM1uQbhvJrF9cX/r2cmWaf83M/XE+BQANqUaARiClJfwqr9ID2qAXVFLJ2o6Bgkim191JnT6qyg== X-Received: by 2002:ac2:4bcc:0:b0:481:25b8:51b9 with SMTP id o12-20020ac24bcc000000b0048125b851b9mr21783387lfq.207.1657026380324; Tue, 05 Jul 2022 06:06:20 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id y13-20020a056512044d00b00483a339a4e8sm308795lfk.144.2022.07.05.06.06.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 06:06:19 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2022 16:06:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 09/14] arm64: dts: qcom: sc8280xp: drop UFS PHY clock-cells Content-Language: en-GB To: Johan Hovold , Bjorn Andersson Cc: Andy Gross , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220705114032.22787-1-johan+linaro@kernel.org> <20220705114032.22787-10-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20220705114032.22787-10-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 05/07/2022 14:40, Johan Hovold wrote: > The QMP UFS PHY provides more than one symbol clock and would need an > index to differentiate the clocks, but none of this is described by the > binding currently. > > Drop the incorrect '#clock-cells' property for now. Could you please take a glance whether https://lore.kernel.org/linux-arm-msm/20220620153956.1723269-2-dmitry.baryshkov@linaro.org/ makes a sense to the sc8280xp platform? > > Signed-off-by: Johan Hovold > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 345a19a6e874..ce4df4e814fe 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -1447,7 +1447,6 @@ ufs_mem_phy_lanes: phy@1d87400 { > <0 0x01d87800 0 0x108>, > <0 0x01d87a00 0 0x1e0>; > #phy-cells = <0>; > - #clock-cells = <0>; > }; > }; > > @@ -1517,7 +1516,6 @@ ufs_card_phy_lanes: phy@1da7400 { > <0 0x01da7800 0 0x108>, > <0 0x01da7a00 0 0x1e0>; > #phy-cells = <0>; > - #clock-cells = <0>; > }; > }; > -- With best wishes Dmitry