All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrei Borzenkov <arvidjaar@gmail.com>
To: grub-devel@gnu.org
Subject: Re: [PATCH] btrfs: avoid "used uninitialized" error with GCC7
Date: Tue, 4 Apr 2017 19:27:49 +0300	[thread overview]
Message-ID: <fa4851bf-ff68-32ba-b98d-d15de7842f73@gmail.com> (raw)
In-Reply-To: <CAEaD8JNmPeJKX4RekgjsSnLCpLUSYanQ7S2JB6huCCZhDA9rZw@mail.gmail.com>

03.04.2017 11:59, Vladimir 'phcoder' Serbinenko пишет:
> On Fri, Mar 31, 2017, 06:43 Andrei Borzenkov <arvidjaar@gmail.com> wrote:
> 
>> sblock was local and so considered new variable on every loop
>> iteration.
>>
>> While on it, dynamically allocate buffer to reduce stack usage.
>>
> Looks good. Did you check all instances sizeof, so we don't have sizeof of
> pointer?
> Did you check return paths for free'ing on all of them?
> 

There is one common return path, but I committed light version that just
moves variable out of loop; will commit full version after release.



      reply	other threads:[~2017-04-04 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 16:42 [PATCH] btrfs: avoid "used uninitialized" error with GCC7 Andrei Borzenkov
2017-04-03  8:59 ` Vladimir 'phcoder' Serbinenko
2017-04-04 16:27   ` Andrei Borzenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa4851bf-ff68-32ba-b98d-d15de7842f73@gmail.com \
    --to=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.