From: Dario Faggioli <dfaggioli@suse.com>
To: Jan Beulich <JBeulich@suse.com>,
"andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>
Cc: "julien@xen.org" <julien@xen.org>,
Juergen Gross <JGross@suse.com>, "wl@xen.org" <wl@xen.org>,
"roger.pau@citrix.com" <roger.pau@citrix.com>,
"sstabellini@kernel.org" <sstabellini@kernel.org>,
"marmarek@invisiblethingslab.com"
<marmarek@invisiblethingslab.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"dpsmith@apertussolutions.com" <dpsmith@apertussolutions.com>
Subject: Re: [PATCH 00/65] x86: Support for CET Indirect Branch Tracking
Date: Thu, 2 Dec 2021 10:31:15 +0000 [thread overview]
Message-ID: <fb840a1359dbd2f6599146e65596ae378bd45426.camel@suse.com> (raw)
In-Reply-To: <178aa1cd-b510-7e3a-2074-a2ae261d4975@suse.com>
[-- Attachment #1: Type: text/plain, Size: 3254 bytes --]
On Mon, 2021-11-29 at 15:44 +0100, Jan Beulich wrote:
> On 26.11.2021 13:33, Andrew Cooper wrote:
> >
> > Andrew Cooper (63):
> > x86: Introduce support for CET-IBT
> > x86/hypercall: Annotate fnptr targets
> > xen: Annotate fnptr targets from custom_param()
> > xen: Annotate fnptr targets from __initcall()
> > xen: Annotate fnptr targets from notifier callbacks
> > xen: Annotate fnptr targets from acpi_table_parse()
> > xen: Annotate fnptr targets from continue_hypercall_on_cpu()
> > xen: Annotate fnptr targets from init_timer()
> > xen: Annotate fnptr targets from call_rcu()
> > xen: Annotate fnptr targets from IPIs
> > xen: Annotate fnptr targets from open_softirq()
> > xsm/flask: Annotate fnptr targets in the security server
> > xsm: Annotate fnptr targets
> > xen/sched: Annotate fnptr targets
> > xen/evtchn: Annotate fnptr targets
> > xen/hypfs: Annotate fnptr targets
> > xen/tasklet: Annotate fnptr targets
> > xen/keyhandler: Annotate fnptr targets
> > xen/vpci: Annotate fnptr targets
> > xen/decompress: Annotate fnptr targets
> > xen/iommu: Annotate fnptr targets
> > xen/video: Annotate fnptr targets
> > xen/console: Annotate fnptr targets
> > xen/misc: Annotate fnptr targets
> > x86: Annotate fnptr targets from request_irq()
> > x86/hvm: Annotate fnptr targets from hvm_funcs
> > x86/hvm: Annotate fnptr targets from device emulation
> > x86/emul: Annotate fnptr targets
> > x86/ucode: Annotate fnptr targets
> > x86/power: Annotate fnptr targets
> > x86/apic: Annotate fnptr targets
> > x86/nmi: Annotate fnptr targets
> > x86/mtrr: Annotate fnptr targets
> > x86/idle: Annotate fnptr targets
> > x86/quirks: Annotate fnptr targets
> > x86/hvmsave: Annotate fnptr targets
> > x86/mce: Annotate fnptr targets
> > x86/pmu: Annotate fnptr targets
> > x86/cpu: Annotate fnptr targets
> > x86/guest: Annotate fnptr targets
> > x86/logdirty: Annotate fnptr targets
> > x86/shadow: Annotate fnptr targets
> > x86/hap: Annotate fnptr targets
> > x86/p2m: Annotate fnptr targets
> > x86/irq: Annotate fnptr targets
> > x86/aepi: Annotate fnptr targets
> > x86/psr: Annotate fnptr targets
> > x86/dpci: Annotate fnptr targets
> > x86/pt: Annotate fnptr targets
> > x86/time: Annotate fnptr targets
> > x86/misc: Annotate fnptr targets
> > x86/stack: Annotate fnptr targets
> > x86/bugframe: Annotate fnptr targets
>
> Patches 4-55 as applicable
> Acked-by: Jan Beulich <jbeulich@suse.com>
>
Patch 16, xen/sched: Annotate fnptr targets:
Acked-by: Dario Faggioli <dfaggioli@suse.com>
> preferably with the subjects disambiguated and the minor remarks on
> individual patches taken care of one way or another.
>
Yes, FWIW, I agree with Jan here that even just a quick hint at the
purpose of the annotation is desirable.
Regards
--
Dario Faggioli, Ph.D
http://about.me/dario.faggioli
Virtualization Software Engineer
SUSE Labs, SUSE https://www.suse.com/
-------------------------------------------------------------------
<<This happens because _I_ choose it to happen!>> (Raistlin Majere)
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-02 10:31 UTC|newest]
Thread overview: 129+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 12:33 [PATCH 00/65] x86: Support for CET Indirect Branch Tracking Andrew Cooper
2021-11-26 12:33 ` [PATCH 01/65] x86: Introduce support for CET-IBT Andrew Cooper
2021-11-26 14:10 ` Jan Beulich
2021-11-26 15:21 ` Andrew Cooper
2021-11-29 9:21 ` Jan Beulich
2021-12-10 14:20 ` Andrew Cooper
2021-12-13 7:32 ` Jan Beulich
2021-11-29 9:27 ` Jan Beulich
2021-11-29 10:27 ` Andrew Cooper
2021-11-26 12:33 ` [PATCH 02/65] x86/pv-shim: don't modify hypercall table Andrew Cooper
2021-11-26 12:33 ` [PATCH 03/65] xen/x86: don't use hypercall table for calling compat hypercalls Andrew Cooper
2021-11-26 12:33 ` [PATCH 04/65] x86/hypercall: Annotate fnptr targets Andrew Cooper
2021-11-26 14:21 ` Jan Beulich
2021-11-26 14:28 ` Andrew Cooper
2021-11-29 9:38 ` Jan Beulich
2021-11-29 10:00 ` Jan Beulich
2021-11-26 12:33 ` [PATCH 05/65] xen: Annotate fnptr targets from custom_param() Andrew Cooper
2021-11-26 12:33 ` [PATCH 06/65] xen: Annotate fnptr targets from __initcall() Andrew Cooper
2021-11-26 12:33 ` [PATCH 07/65] xen: Annotate fnptr targets from notifier callbacks Andrew Cooper
2021-11-26 12:33 ` [PATCH 08/65] xen: Annotate fnptr targets from acpi_table_parse() Andrew Cooper
2021-12-06 8:36 ` Jan Beulich
2021-12-10 14:44 ` Andrew Cooper
2021-12-13 7:46 ` Jan Beulich
2021-11-26 12:33 ` [PATCH 09/65] xen: Annotate fnptr targets from continue_hypercall_on_cpu() Andrew Cooper
2021-11-26 12:33 ` [PATCH 10/65] xen: Annotate fnptr targets from init_timer() Andrew Cooper
2021-11-26 12:33 ` [PATCH 11/65] xen: Annotate fnptr targets from call_rcu() Andrew Cooper
2021-11-26 12:33 ` [PATCH 12/65] xen: Annotate fnptr targets from IPIs Andrew Cooper
2021-11-26 12:33 ` [PATCH 13/65] xen: Annotate fnptr targets from open_softirq() Andrew Cooper
2021-11-26 12:33 ` [PATCH 14/65] xsm/flask: Annotate fnptr targets in the security server Andrew Cooper
2021-12-03 10:44 ` Daniel P. Smith
2021-11-26 12:33 ` [PATCH 15/65] xsm: Annotate fnptr targets Andrew Cooper
2021-12-03 10:46 ` Daniel P. Smith
2021-11-26 12:33 ` [PATCH 16/65] xen/sched: " Andrew Cooper
2021-11-26 12:33 ` [PATCH 17/65] xen/evtchn: " Andrew Cooper
2021-11-29 13:51 ` Jan Beulich
2021-11-26 12:33 ` [PATCH 18/65] xen/hypfs: " Andrew Cooper
2021-12-02 11:35 ` Juergen Gross
2021-11-26 12:34 ` [PATCH 19/65] xen/tasklet: " Andrew Cooper
2021-11-29 13:56 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 20/65] xen/keyhandler: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 21/65] xen/vpci: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 22/65] xen/decompress: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 23/65] xen/iommu: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 24/65] xen/video: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 25/65] xen/console: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 26/65] xen/misc: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 27/65] x86: Annotate fnptr targets from request_irq() Andrew Cooper
2021-11-26 12:34 ` [PATCH 28/65] x86/hvm: Annotate fnptr targets from hvm_funcs Andrew Cooper
2021-11-29 14:14 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 29/65] x86/hvm: Annotate fnptr targets from device emulation Andrew Cooper
2021-11-26 12:34 ` [PATCH 30/65] x86/emul: Annotate fnptr targets Andrew Cooper
2021-11-29 14:22 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 31/65] x86/ucode: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 32/65] x86/power: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 33/65] x86/apic: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 34/65] x86/nmi: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 35/65] x86/mtrr: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 36/65] x86/idle: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 37/65] x86/quirks: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 38/65] x86/hvmsave: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 39/65] x86/mce: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 40/65] x86/pmu: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 41/65] x86/cpu: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 42/65] x86/guest: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 43/65] x86/logdirty: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 44/65] x86/shadow: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 45/65] x86/hap: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 46/65] x86/p2m: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 47/65] x86/irq: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 48/65] x86/aepi: " Andrew Cooper
2021-11-29 14:33 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 49/65] x86/psr: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 50/65] x86/dpci: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 51/65] x86/pt: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 52/65] x86/time: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 53/65] x86/misc: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 54/65] x86/stack: " Andrew Cooper
2021-11-29 14:41 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 55/65] x86/bugframe: " Andrew Cooper
2021-11-26 12:34 ` [PATCH 56/65] x86: Use control flow typechecking where possible Andrew Cooper
2021-11-26 12:34 ` [PATCH 57/65] x86/setup: Read CR4 earlier in __start_xen() Andrew Cooper
2021-12-03 12:58 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 58/65] x86/alternatives: Clear CR4.CET when clearing CR0.WP Andrew Cooper
2021-12-03 12:59 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 59/65] x86/traps: Rework write_stub_trampoline() to not hardcode the jmp Andrew Cooper
2021-12-03 13:17 ` Jan Beulich
2021-12-03 13:59 ` Andrew Cooper
2021-12-03 14:03 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 60/65] x86/emul: Update emulation stubs to be CET-IBT compatible Andrew Cooper
2021-11-26 12:34 ` [PATCH 61/65] x86/entry: Make syscall/sysenter entrypoints " Andrew Cooper
2021-11-26 12:34 ` [PATCH 62/65] x86/entry: Make IDT " Andrew Cooper
2021-12-03 13:23 ` Jan Beulich
2021-12-03 14:12 ` Andrew Cooper
2021-12-03 13:32 ` Jan Beulich
2021-12-03 15:30 ` Andrew Cooper
2021-12-06 9:42 ` Jan Beulich
2021-12-06 11:38 ` Andrew Cooper
2021-12-06 12:27 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 63/65] x86/setup: Rework MSR_S_CET handling for CET-IBT Andrew Cooper
2021-12-06 10:49 ` Jan Beulich
2021-12-10 16:19 ` Andrew Cooper
2021-12-10 16:47 ` Jan Beulich
2021-11-26 12:34 ` [PATCH 64/65] x86/efi: Disable CET-IBT around Runtime Services calls Andrew Cooper
2021-11-26 12:34 ` [PATCH 65/65] x86: Enable CET Indirect Branch Tracking Andrew Cooper
2021-12-06 11:24 ` Jan Beulich
2021-11-26 12:48 ` [PATCH 00/65] x86: Support for " Jan Beulich
2021-11-26 13:13 ` Andrew Cooper
2021-11-26 13:21 ` Andrew Cooper
2021-11-26 13:22 ` Jan Beulich
2021-11-26 23:49 ` Andrew Cooper
2021-11-29 9:18 ` Jan Beulich
2021-11-26 16:33 ` [PATCH 59.5/65] x86: Introduce helpers/checks for endbr64 instructions Andrew Cooper
2021-11-26 18:26 ` Marek Marczykowski-Górecki
2021-11-26 18:29 ` Andrew Cooper
2021-12-03 13:59 ` Jan Beulich
2021-12-03 14:10 ` Andrew Cooper
2021-12-06 8:04 ` Jan Beulich
2021-11-26 16:37 ` [PATCH v1.1 60/65] x86/emul: Update emulation stubs to be CET-IBT compatible Andrew Cooper
2021-12-03 13:39 ` Jan Beulich
2021-11-26 16:37 ` [PATCH v1.1 61/65] x86/entry: Make syscall/sysenter entrypoints " Andrew Cooper
2021-12-03 13:48 ` Jan Beulich
2021-11-26 16:38 ` [PATCH v1.1 64/65] x86/efi: Disable CET-IBT around Runtime Services calls Andrew Cooper
2021-12-06 11:06 ` Jan Beulich
2021-12-10 17:16 ` Andrew Cooper
2021-12-13 7:52 ` Jan Beulich
2021-11-29 14:44 ` [PATCH 00/65] x86: Support for CET Indirect Branch Tracking Jan Beulich
2021-11-29 15:09 ` Andrew Cooper
2021-11-29 16:17 ` Jan Beulich
2021-12-02 10:31 ` Dario Faggioli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb840a1359dbd2f6599146e65596ae378bd45426.camel@suse.com \
--to=dfaggioli@suse.com \
--cc=JBeulich@suse.com \
--cc=JGross@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=julien@xen.org \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.