All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Hauke Mehrtens <hauke@hauke-m.de>, davem@davemloft.net
Cc: kuba@kernel.org, netdev@vger.kernel.org,
	martin.blumenstingl@googlemail.com
Subject: Re: [PATCH 2/3] net: lantiq: use netif_tx_napi_add() for TX NAPI
Date: Sun, 16 Aug 2020 11:05:49 -0700	[thread overview]
Message-ID: <fc1c2dfd-5a7c-b9cb-8dff-4c4c5fd737fa@gmail.com> (raw)
In-Reply-To: <20200815183314.404-2-hauke@hauke-m.de>



On 8/15/20 11:33 AM, Hauke Mehrtens wrote:
> netif_tx_napi_add() should be used for NAPI in the TX direction instead
> of the netif_napi_add() function.
> 
> Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver")
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
>  drivers/net/ethernet/lantiq_xrx200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/lantiq_xrx200.c b/drivers/net/ethernet/lantiq_xrx200.c
> index 1feb9fc710e0..f34e4dc8c661 100644
> --- a/drivers/net/ethernet/lantiq_xrx200.c
> +++ b/drivers/net/ethernet/lantiq_xrx200.c
> @@ -502,7 +502,7 @@ static int xrx200_probe(struct platform_device *pdev)
>  
>  	/* setup NAPI */
>  	netif_napi_add(net_dev, &priv->chan_rx.napi, xrx200_poll_rx, 32);
> -	netif_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping, 32);
> +	netif_tx_napi_add(net_dev, &priv->chan_tx.napi, xrx200_tx_housekeeping, 32);
>  
>  	platform_set_drvdata(pdev, priv);
>  
> 


This is not a must, simply a matter of (small) optimization in
the very rare case of busy polling users.

The Fixes: tag here is not necessary.

  reply	other threads:[~2020-08-16 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-15 18:33 [PATCH 1/3] net: lantiq: Wake TX queue again Hauke Mehrtens
2020-08-15 18:33 ` [PATCH 2/3] net: lantiq: use netif_tx_napi_add() for TX NAPI Hauke Mehrtens
2020-08-16 18:05   ` Eric Dumazet [this message]
2020-08-15 18:33 ` [PATCH 3/3] net: lantiq: Use napi_complete_done() Hauke Mehrtens
2020-08-16 18:07   ` Eric Dumazet
2020-08-17 21:17     ` Hauke Mehrtens
2020-08-18  0:33       ` Eric Dumazet
2020-08-18  0:48         ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc1c2dfd-5a7c-b9cb-8dff-4c4c5fd737fa@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hauke@hauke-m.de \
    --cc=kuba@kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.