From: Matheus Kowalczuk Ferst <matheus.ferst@eldorado.org.br>
To: Paolo Bonzini <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH 0/6] Fix support for biarch compilers and cross cflags
Date: Tue, 21 Jun 2022 16:38:03 +0000 [thread overview]
Message-ID: <fd21c891-91c9-1926-00f7-2ca9edadbc02@eldorado.org.br> (raw)
In-Reply-To: <20220621075147.36297-1-pbonzini@redhat.com>
On 21/06/2022 04:51, Paolo Bonzini wrote:
> This series fixes two bugs with configure's cross compilation detection:
>
> - first, --cross-cflags is not obeyed by pc-bios/ compilation
>
> - second, on a ppc64le machine, the host compiler can be used for ppc64
> tests/tcg;
That may be true for the compiler, but the complete toolchain is usually
single endian. For instance, Debian/Ubuntu, Fedora, and FreeBSD lack
libc and crt*.o for the foreign endianness. So we'd be able to build
ppc64-softmmu tests (which are not upstream yet) but not
ppc64-linux-user in ppc64le hosts.
> however, this is not being done because $cpu does not
> match the target. Likewise, on an x86_64 machine the host compiler
> can be used to build both i386 tests/tcg and pc-bios/optionrom, but
> the special casing done by the configure script only covers the latter.
>
> The two are related because, if only the first was fixed, pc-bios/optionrom
> would use either the i386 or the x86_64 cflags depending on which cross
> compiler was found. So patches 2-4 tackle not just the cross CFLAGS
> problem with pc-bios, but also the biarch compiler problem with i386
> and ppc. Patch 5 then covers the other biarch compilers.
>
> The other two patches are just cleanups.
>
> Supersedes: <20220607094031.1227714-1-pbonzini@redhat.com>
>
> Paolo Bonzini (6):
> pc-bios/optionrom: use -m16 unconditionally
> configure, pc-bios/optionrom: pass cross CFLAGS correctly
> configure, pc-bios/s390-ccw: pass cross CFLAGS correctly
> configure, pc-bios/vof: pass cross CFLAGS correctly
> configure: allow more host/target combos to use the host compiler
> configure: write EXTRA_CFLAGS for all sub-Makefiles
>
> configure | 50 ++++++++++++++++++-----------------
> pc-bios/optionrom/Makefile | 15 +----------
> pc-bios/optionrom/code16gcc.h | 3 ---
> pc-bios/s390-ccw/Makefile | 20 +++++++-------
> pc-bios/s390-ccw/netboot.mak | 6 ++---
> pc-bios/vof/Makefile | 8 +++---
> 6 files changed, 43 insertions(+), 59 deletions(-)
> delete mode 100644 pc-bios/optionrom/code16gcc.h
>
> --
> 2.36.1
>
>
Thanks,
Matheus K. Ferst
Instituto de Pesquisas ELDORADO <http://www.eldorado.org.br/>
Analista de Software
Aviso Legal - Disclaimer <https://www.eldorado.org.br/disclaimer.html>
prev parent reply other threads:[~2022-06-21 16:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 7:51 [PATCH 0/6] Fix support for biarch compilers and cross cflags Paolo Bonzini
2022-06-21 7:51 ` [PATCH 1/6] pc-bios/optionrom: use -m16 unconditionally Paolo Bonzini
2022-06-21 14:48 ` Richard Henderson
2022-06-21 7:51 ` [PATCH 2/6] configure, pc-bios/optionrom: pass cross CFLAGS correctly Paolo Bonzini
2022-06-21 14:55 ` Richard Henderson
2022-06-22 9:31 ` Paolo Bonzini
2022-06-21 7:51 ` [PATCH 3/6] configure, pc-bios/s390-ccw: " Paolo Bonzini
2022-06-21 8:26 ` Thomas Huth
2022-06-21 7:51 ` [PATCH 4/6] configure, pc-bios/vof: " Paolo Bonzini
2022-06-21 15:14 ` Richard Henderson
2022-06-21 7:51 ` [PATCH 5/6] configure: allow more host/target combos to use the host compiler Paolo Bonzini
2022-06-21 7:51 ` [PATCH 6/6] configure: write EXTRA_CFLAGS for all sub-Makefiles Paolo Bonzini
2022-06-21 16:38 ` Matheus Kowalczuk Ferst [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd21c891-91c9-1926-00f7-2ca9edadbc02@eldorado.org.br \
--to=matheus.ferst@eldorado.org.br \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.