All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms
Date: Tue, 7 Nov 2017 21:21:03 +0100	[thread overview]
Message-ID: <fd2c8e8f-ebe0-79a7-df05-a4c2bc01ba11@mind.be> (raw)
In-Reply-To: <002cc8ca-ccf5-7610-905a-735e0740d942@micronovasrl.com>



On 07-11-17 19:58, Giulio Benetti wrote:
> This patch is buggy.
> The same for Gary Bisson patch.
> Must put "EGLFS_DEVICE_INTEGRATION = eglfs_mali"
> before:
> 
> include(../common/linux_device_post.conf)
> load(qt_config)
> 
> otherwise qmake ignores it.
> I thought to use sed to append EGLFS_DEVICE_INTEGRATION = eglfs_mali/viv just
> after include(arch.conf).

 Yes, with sed is a good idea. Preferably by renaming qmake.conf to
qmake.conf.in and always using sed to generate the actual qmake.conf file. Add a
line

EGLFS_DEVICE_INTEGRATION = @EGLFS_DEVICE@

at the appropriate place. The sed then either replaces @EGLFS_DEVICE@ with the
proper string, or deletes the line.

 Regards,
 Arnout

> 
> What do you think?
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2017-11-07 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 14:48 [Buildroot] [PATCH 1/1] add qmake.conf fixup for sunxi-mali platforms Giulio Benetti
2017-11-07 18:58 ` Giulio Benetti
2017-11-07 20:21   ` Arnout Vandecappelle [this message]
2017-11-07 20:22     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd2c8e8f-ebe0-79a7-df05-a4c2bc01ba11@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.