From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233A5C433FE for ; Mon, 8 Nov 2021 23:45:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EB83610A5 for ; Mon, 8 Nov 2021 23:45:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240987AbhKHXr6 (ORCPT ); Mon, 8 Nov 2021 18:47:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240834AbhKHXr5 (ORCPT ); Mon, 8 Nov 2021 18:47:57 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB40AC061570; Mon, 8 Nov 2021 15:45:12 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id y7so448650plp.0; Mon, 08 Nov 2021 15:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h3desR1Vsd4jK6UvMi7IedYToe+3uCEnZSZG2vFgpWo=; b=L3Lt3FiC1S8s5dsAC+kr8MjxPtoYink0ysIyDMwcwDHbV9abqbVM9hNSEFTnYeOwd3 7y7+TXzgsl8GmCuSjl/YRp7gZHeZ+0jsYSVzQISEgBEncICCdOx2tZYfk/uhDPnIaLr+ bg/pjYvuVFvXmnCcG8DkWbFAt/wKSyfv1pbL7KWdsXYIyYiBcGebmt2xjILIhV/Pn1HM SG0h1u4YHTFnzcdb/yM9Mzgs3MRohz4q4jW6GGztmSzWuSWRT8VskhpsLST6f4oiGW5c sJ872iholrrLoC/hUw19SfMGMPldjG+WQ+Dklq+01q5CXpNPdhHmCRNvbn3S1hQr9BqO 3QUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3desR1Vsd4jK6UvMi7IedYToe+3uCEnZSZG2vFgpWo=; b=zXb6ArUf6FexPEYHbHHvnaEW51Zr+J8c+fgHkP6norUhIfSS3ytdS34Rlr5dlCENjx 9o1M7W3HoKjYvlZadrz5VWCTFmH+HlXe8LCvmmteTbEvDOZKDOJlA1aXHwWCy04oZSdd PUP2n9ar0FYoHfgT3SOcZe6dy9lf2Ffe7YPTSrShvS+HD/z/b5KerGc3vJF6KvDkkFpD n0E1SYWw2s6K9Oc5f56yyGjpzHdv8zFY79L3dJ4pJoKjR9S2TNB+xBkcq8vn9buRGaMf h7T6RfQxpRqxYdG48sURDYnXMIiUbPYcMTIkm9cihd00/raQYw2DTDX+iQ/JhKGAC+wS 7paQ== X-Gm-Message-State: AOAM531J/9PeFEpgFhU2KVxThLfdcZRD1tf5zvS7ClkFzgMByP97gFjc nUek7g5KkXEgT3BhOAPapTJhepKAQSQ= X-Google-Smtp-Source: ABdhPJy/Zm31TobY8eRU8X9Abcnzs2DumKtx+GyyxtAPrLcyMjsbGKbFRFrhnZ7jwPB8gPxx1+PKqw== X-Received: by 2002:a17:902:6902:b0:13f:c1cd:88f1 with SMTP id j2-20020a170902690200b0013fc1cd88f1mr2732134plk.36.1636415111871; Mon, 08 Nov 2021 15:45:11 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z23sm13038540pgn.14.2021.11.08.15.45.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 15:45:11 -0800 (PST) Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Christophe JAILLET Cc: nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> From: Florian Fainelli Message-ID: Date: Mon, 8 Nov 2021 15:45:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/21 3:30 PM, Krzysztof Wilczyński wrote: > Hello, > > [...] >>>> Jim, Florian and Lorenzo - is this something that would be OK with you, >>>> or you would rather keep things as they were? >>> >>> I would be tempted to leave the code as-is, but if we do we are probably >>> bound to seeing patches like Christophe's in the future to address the >> >> Even if I don't find this report in the Coverity database, it should from >> around April 2018. >> So, if you have not already received several patches for that, I doubt that >> you will receive many in the future. >> >> >> My own feeling is that using a long (and not a long *) as a bitmap, and >> accessing it with &long may look spurious to a reader. >> That said, it works. >> >> So, I let you decide if the patch is of any use. Should I need to tweak or >> resend it, let me know. > > I would be pro taking it, not only to addresses the Coverity complaint, but > also to align the code with other drivers a little bit more. Only if > the driver maintainers have no objection, that is. Driver consistency is a strong argument, fine with me then. -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E12C433F5 for ; Mon, 8 Nov 2021 23:46:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41E5D60E54 for ; Mon, 8 Nov 2021 23:46:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 41E5D60E54 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=13XPrS1aLit7ufs35JV8G+3PcDxE6AKFtLLdc9OEfRo=; b=Z+OXOs0xrNlw2YTCqjvruAIm/V 0QbfZssKg4rvEsJZxM0ai5ahDnSst+K2QhYa2TDDe31sI3aaCwADaIUX1/hM+9atwMqOEE1hKx26Q l6RzPfEjZV+yP6hczc0B4D6BIm5Vl5QQ2zoM3PfU8WMhK4HdpBoyTixNPWXjssrSBAqNeIrADGoLO xmUEBDEFdCb92wg1kEimh9u3ZUuxX2DqBUr2lGZumZxWTvwK9pDNL1jW/l5HoiMHsVwRLA9YIPzJP c7SrBOkOh++RddHochLsgIA3eWB5r1PqN8P65gsoG9tNC6MWV8nczOXbszBat2x77d8FcuOBvErHx cBNvOIbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkEKB-0000kh-TC; Mon, 08 Nov 2021 23:45:16 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkEK8-0000jk-K2; Mon, 08 Nov 2021 23:45:13 +0000 Received: by mail-pl1-x631.google.com with SMTP id u17so17474780plg.9; Mon, 08 Nov 2021 15:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=h3desR1Vsd4jK6UvMi7IedYToe+3uCEnZSZG2vFgpWo=; b=L3Lt3FiC1S8s5dsAC+kr8MjxPtoYink0ysIyDMwcwDHbV9abqbVM9hNSEFTnYeOwd3 7y7+TXzgsl8GmCuSjl/YRp7gZHeZ+0jsYSVzQISEgBEncICCdOx2tZYfk/uhDPnIaLr+ bg/pjYvuVFvXmnCcG8DkWbFAt/wKSyfv1pbL7KWdsXYIyYiBcGebmt2xjILIhV/Pn1HM SG0h1u4YHTFnzcdb/yM9Mzgs3MRohz4q4jW6GGztmSzWuSWRT8VskhpsLST6f4oiGW5c sJ872iholrrLoC/hUw19SfMGMPldjG+WQ+Dklq+01q5CXpNPdhHmCRNvbn3S1hQr9BqO 3QUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=h3desR1Vsd4jK6UvMi7IedYToe+3uCEnZSZG2vFgpWo=; b=tWB+MjsBhwSEwAcmcbjpNevNukEtUDDSSUKC06i1ntOkEJzbqq9c+ASv2wpynQkvKd O4AekTRqWflv7/v5BZGjJsBzUXQo9ZbxP/Ka76JWY+ngeIvYoG3yNEqjRXTIZhOxmKGH B5B1lvZsj3iJhwGubuvNsEfkzTjOeNjfIkZwosGJvivpzyppNs9GxpzlYrq4dDlpLebp 10luAGTZOX6pBLDNmIYRp6ag111WVR/MyzLW061fCT+CrYKiSaq1idyYzGqBIbY4kJZj 4qV+Mi7AaGbN+Vxgjh9ju2DfGP1xe1Si5BYUhFlLsfiJZ+8mgiox3/uiss52T9m9SCT8 oN3g== X-Gm-Message-State: AOAM530GZ7oF8tdYGPpyBy3ER8tKeN2PQuJUwribMsR7a1GLYjV1NBb6 4gxto2YUw1poGzUTf1dWzo2wNR+O0hk= X-Google-Smtp-Source: ABdhPJy/Zm31TobY8eRU8X9Abcnzs2DumKtx+GyyxtAPrLcyMjsbGKbFRFrhnZ7jwPB8gPxx1+PKqw== X-Received: by 2002:a17:902:6902:b0:13f:c1cd:88f1 with SMTP id j2-20020a170902690200b0013fc1cd88f1mr2732134plk.36.1636415111871; Mon, 08 Nov 2021 15:45:11 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id z23sm13038540pgn.14.2021.11.08.15.45.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 15:45:11 -0800 (PST) Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Christophe JAILLET Cc: nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> From: Florian Fainelli Message-ID: Date: Mon, 8 Nov 2021 15:45:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_154512_693483_A98022D1 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMTEvOC8yMSAzOjMwIFBNLCBLcnp5c3p0b2YgV2lsY3p5xYRza2kgd3JvdGU6Cj4gSGVsbG8s Cj4gCj4gWy4uLl0KPj4+PiBKaW0sIEZsb3JpYW4gYW5kIExvcmVuem8gLSBpcyB0aGlzIHNvbWV0 aGluZyB0aGF0IHdvdWxkIGJlIE9LIHdpdGggeW91LAo+Pj4+IG9yIHlvdSB3b3VsZCByYXRoZXIg a2VlcCB0aGluZ3MgYXMgdGhleSB3ZXJlPwo+Pj4KPj4+IEkgd291bGQgYmUgdGVtcHRlZCB0byBs ZWF2ZSB0aGUgY29kZSBhcy1pcywgYnV0IGlmIHdlIGRvIHdlIGFyZSBwcm9iYWJseQo+Pj4gYm91 bmQgdG8gc2VlaW5nIHBhdGNoZXMgbGlrZSBDaHJpc3RvcGhlJ3MgaW4gdGhlIGZ1dHVyZSB0byBh ZGRyZXNzIHRoZQo+Pgo+PiBFdmVuIGlmIEkgZG9uJ3QgZmluZCB0aGlzIHJlcG9ydCBpbiB0aGUg Q292ZXJpdHkgZGF0YWJhc2UsIGl0IHNob3VsZCBmcm9tCj4+IGFyb3VuZCBBcHJpbCAyMDE4Lgo+ PiBTbywgaWYgeW91IGhhdmUgbm90IGFscmVhZHkgcmVjZWl2ZWQgc2V2ZXJhbCBwYXRjaGVzIGZv ciB0aGF0LCBJIGRvdWJ0IHRoYXQKPj4geW91IHdpbGwgcmVjZWl2ZSBtYW55IGluIHRoZSBmdXR1 cmUuCj4+Cj4+Cj4+IE15IG93biBmZWVsaW5nIGlzIHRoYXQgdXNpbmcgYSBsb25nIChhbmQgbm90 IGEgbG9uZyAqKSBhcyBhIGJpdG1hcCwgYW5kCj4+IGFjY2Vzc2luZyBpdCB3aXRoICZsb25nIG1h eSBsb29rIHNwdXJpb3VzIHRvIGEgcmVhZGVyLgo+PiBUaGF0IHNhaWQsIGl0IHdvcmtzLgo+Pgo+ PiBTbywgSSBsZXQgeW91IGRlY2lkZSBpZiB0aGUgcGF0Y2ggaXMgb2YgYW55IHVzZS4gU2hvdWxk IEkgbmVlZCB0byB0d2VhayBvcgo+PiByZXNlbmQgaXQsIGxldCBtZSBrbm93Lgo+IAo+IEkgd291 bGQgYmUgcHJvIHRha2luZyBpdCwgbm90IG9ubHkgdG8gYWRkcmVzc2VzIHRoZSBDb3Zlcml0eSBj b21wbGFpbnQsIGJ1dAo+IGFsc28gdG8gYWxpZ24gdGhlIGNvZGUgd2l0aCBvdGhlciBkcml2ZXJz IGEgbGl0dGxlIGJpdCBtb3JlLiAgT25seSBpZgo+IHRoZSBkcml2ZXIgbWFpbnRhaW5lcnMgaGF2 ZSBubyBvYmplY3Rpb24sIHRoYXQgaXMuCgpEcml2ZXIgY29uc2lzdGVuY3kgaXMgYSBzdHJvbmcg YXJndW1lbnQsIGZpbmUgd2l0aCBtZSB0aGVuLgotLSAKRmxvcmlhbgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=