All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: mlevitsk@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org,
	mst@redhat.com
Subject: Re: [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep
Date: Thu, 11 Nov 2021 20:29:20 +0100	[thread overview]
Message-ID: <fd920779-cff2-6eec-5c0b-686b3e29cc9f@redhat.com> (raw)
In-Reply-To: <878rxuiplm.fsf@linaro.org>

On 11/11/21 18:08, Alex Bennée wrote:
>> +
>> +    /*
>> +     * In replay mode all events written into the log should be replayed.
>> +     * That is why NOIRQ flag is removed in this mode.
> I guess if we were being complete we could say something like:
> 
>    In replay mode all events will come from the log and can't be
>    suppressed otherwise we would break determinism. However as those
>    events are tied to the number of executed instructions we won't see
>    them occurring every time we single step.
> 

Ok, I can integrate this improved comment.

Paolo



  reply	other threads:[~2021-11-11 19:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-11 11:05 [PATCH 0/5] Update linux-headers + NOIRQ support for KVM gdbstub Paolo Bonzini
2021-11-11 11:06 ` [PATCH 1/5] virtio-gpu: do not byteswap padding Paolo Bonzini
2021-11-11 11:28   ` Cornelia Huck
2021-11-11 11:32   ` Philippe Mathieu-Daudé
2021-11-11 16:58   ` Michael S. Tsirkin
2021-11-11 17:06   ` Alex Bennée
2021-11-11 11:06 ` [PATCH 2/5] linux-headers: update to 5.16-rc1 Paolo Bonzini
2021-11-11 11:29   ` Cornelia Huck
2021-11-11 17:07   ` Alex Bennée
2021-11-11 11:06 ` [PATCH 3/5] gdbstub: reject unsupported flags in handle_set_qemu_sstep Paolo Bonzini
2021-11-11 11:38   ` Philippe Mathieu-Daudé
2021-11-11 17:16     ` Paolo Bonzini
2021-11-11 17:08   ` Alex Bennée
2021-11-11 19:29     ` Paolo Bonzini [this message]
2021-11-11 11:06 ` [PATCH 4/5] gdbstub, kvm: let KVM report supported singlestep flags Paolo Bonzini
2021-11-11 17:14   ` Alex Bennée
2021-11-11 11:06 ` [PATCH 5/5] kvm: add support for KVM_GUESTDBG_BLOCKIRQ Paolo Bonzini
2021-11-11 16:31   ` Philippe Mathieu-Daudé
2021-11-11 17:17   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fd920779-cff2-6eec-5c0b-686b3e29cc9f@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cohuck@redhat.com \
    --cc=mlevitsk@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.