All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josef Bacik <josef@toxicpanda.com>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Cc: Naohiro Aota <naohiro.aota@wdc.com>
Subject: Re: [PATCH 1/2] fstests: add missing checks of fallocate feature
Date: Tue, 2 Mar 2021 14:00:57 -0500	[thread overview]
Message-ID: <fe0829c9-b719-a155-2404-a43640d8df70@toxicpanda.com> (raw)
In-Reply-To: <20210302091305.27828-2-johannes.thumshirn@wdc.com>

On 3/2/21 4:13 AM, Johannes Thumshirn wrote:
> From: Naohiro Aota <naohiro.aota@wdc.com>
> 
> Many test cases use xfs_io -c 'falloc' but forgot to add
> _require_xfs_io_command "falloc". This will fail the test case if we run
> the test case on a file system without fallcoate support e.g. F2FS ZZ
> 
> While we believe that normal fallocate(mode = 0) is always supported on
> Linux, it is not true. Fallocate is disabled in several implementations of
> zoned block support for file systems because the pre-allocated region will
> break the sequential writing rule.
> 
> Currently, several test cases unconditionally call fallocate(). Let's add
> _require_xfs_io_command "falloc" to properly check the feature is supported
> by a testing file system.
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

  reply	other threads:[~2021-03-03  2:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-02  9:13 [PATCH 0/2] fstests: two preperation patches for zoned device support Johannes Thumshirn
2021-03-02  9:13 ` [PATCH 1/2] fstests: add missing checks of fallocate feature Johannes Thumshirn
2021-03-02 19:00   ` Josef Bacik [this message]
2021-03-03  6:01   ` Naohiro Aota
2021-03-03  8:04     ` Johannes Thumshirn
2021-03-02  9:13 ` [PATCH 2/2] btrfs: require discard functionality from scratch device Johannes Thumshirn
2021-03-02 19:01   ` Josef Bacik
2021-03-03  5:58 ` [PATCH 0/2] fstests: two preperation patches for zoned device support Naohiro Aota
2021-03-03  8:04   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe0829c9-b719-a155-2404-a43640d8df70@toxicpanda.com \
    --to=josef@toxicpanda.com \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=naohiro.aota@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.