All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@kaod.org>
To: Iris Chen <irischenlj@gmail.com>
Cc: <irischenlj@fb.com>, <peter@pjd.dev>, <pdel@fb.com>,
	<qemu-devel@nongnu.org>, <qemu-arm@nongnu.org>,
	<patrick@stwcx.xyz>, <alistair@alistair23.me>, <kwolf@redhat.com>,
	<hreitz@redhat.com>, <peter.maydell@linaro.org>,
	<andrew@aj.id.au>, <joel@jms.id.au>, <thuth@redhat.com>,
	<lvivier@redhat.com>, <pbonzini@redhat.com>,
	<qemu-block@nongnu.org>, <dz4list@gmail.com>,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [RFC 0/1] SPI support in QEMU TPM
Date: Wed, 3 Aug 2022 10:32:51 +0200	[thread overview]
Message-ID: <ff945e61-b647-c982-9af6-1c4a86650aac@kaod.org> (raw)
In-Reply-To: <20220803023241.63739-1-irischenlj@gmail.com>

[ Adding Stefan, TPM maintainer ]

On 8/3/22 04:32, Iris Chen wrote:
> From: Iris Chen <irischenlj@fb.com>
> 
> Hey everyone,
> 
> Thanks for all your comments on the SPI GPIO model. I am working through them.
> 
> As for adding support for SPI-based TPMs in QEMU, this RFC patch adds SPI
> support in the QEMU TPM implementation via tpm_tis_spi.c.
> 
> The QEMU tree already has support for two connection methods to the TPM:
> mmio (isa for x86, sysbus for arm) and “spapr”. This patch adds a new SPI
> bus implementation for the TPM. Specifically, this SPI bus implementation
> connects to the Yosemite-v3.5 model using the SPI-GPIO model sent earlier
> last week. I have already tested these implementations locally together
> and can verify that the Linux kernel can successfully probe the TPM device
> on Yosemite-v3.5 and we can run the TPM command line tools to interact with it.
> 
> Please let me know what you think about this!
> 
> Thanks,
> Iris
> 
> Iris Chen (1):
>    hw: tpmtisspi: add SPI support to QEMU TPM implementation
> 
>   configs/devices/arm-softmmu/default.mak |   1 +
>   hw/arm/Kconfig                          |   5 +
>   hw/tpm/Kconfig                          |   5 +
>   hw/tpm/meson.build                      |   1 +
>   hw/tpm/tpm_tis_spi.c                    | 311 ++++++++++++++++++++++++
>   include/sysemu/tpm.h                    |   3 +
>   6 files changed, 326 insertions(+)
>   create mode 100644 hw/tpm/tpm_tis_spi.c
> 
> --
> 2.30.2



      parent reply	other threads:[~2022-08-03  8:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03  2:32 [RFC 0/1] SPI support in QEMU TPM Iris Chen
2022-08-03  2:32 ` [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation Iris Chen
2022-08-03  8:52   ` Cédric Le Goater
2022-08-03 17:30     ` Peter Delevoryas
2022-08-04 18:07       ` Dan Zhang
2022-08-04 23:21         ` Peter Delevoryas
2022-08-05  5:05           ` Dan Zhang
2022-08-10 13:57     ` Stefan Berger
2022-08-10 14:38     ` Stefan Berger
2023-12-13 14:39   ` Guenter Roeck
2023-12-15  2:43     ` Iris Chen
2022-08-03  8:32 ` Cédric Le Goater [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ff945e61-b647-c982-9af6-1c4a86650aac@kaod.org \
    --to=clg@kaod.org \
    --cc=alistair@alistair23.me \
    --cc=andrew@aj.id.au \
    --cc=dz4list@gmail.com \
    --cc=hreitz@redhat.com \
    --cc=irischenlj@fb.com \
    --cc=irischenlj@gmail.com \
    --cc=joel@jms.id.au \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=patrick@stwcx.xyz \
    --cc=pbonzini@redhat.com \
    --cc=pdel@fb.com \
    --cc=peter.maydell@linaro.org \
    --cc=peter@pjd.dev \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.ibm.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.