All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Peter Huewe <peterhuewe@gmx.de>,
	Marcel Selhorst <tpmdd@selhorst.net>,
	apronin@google.com, tpmdd-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.
Date: Wed, 22 Feb 2017 12:16:08 +0100	[thread overview]
Message-ID: <ffdfb321-6c9b-06fe-1a90-04da5457b47d@collabora.com> (raw)
In-Reply-To: <20170221162948.GD25818@lunn.ch>

Hi Andrew,

Removing Bryan Freed from the loop as seems his email is not valid anymore. I already CC'ied Andrey which is doing the TPM bit in chromeos kernel.

On 21/02/17 17:29, Andrew Lunn wrote:
> On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote:
>> From: Bryan Freed <bfreed@chromium.org>
>>
>> When the I2C Infineon part is attached to an I2C adapter that imposes
>> a size limitation, large requests will fail -EINVAL.
>> Retry them with size backoff without re-issuing the 0x05 command
>> as this appears to occasionally put the TPM in a bad state.
> 
> Hi Enric
> 
> Rather than trying small and smaller transfers, would it not be better
> to get the i2c core to expose the quirk info about transfer limits?
> 

Sounds a good idea to me, I guess the quirk info can be accessed with

  tpm_dev.client->adapter->quirks->max_read_len

so I think we don't need to touch the i2c core. I'll propose a second version of the patch.

Thanks,
  Enric


>    Andrew
> 

  reply	other threads:[~2017-02-22 11:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 14:44 [PATCH 1/2] tpm: Apply an adapterlimit for retransmission Enric Balletbo i Serra
2017-02-21 14:45 ` [PATCH 2/2] tpm: Do not assume an i2c adapter preserves the msg len Enric Balletbo i Serra
2017-02-21 16:29 ` [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission Andrew Lunn
2017-02-22 11:16   ` Enric Balletbo i Serra [this message]
2017-02-22 14:01     ` Andrew Lunn
2017-02-27 18:48       ` Enric Balletbo Serra
2017-02-27 19:12         ` Wolfram Sang
2017-02-27 19:12           ` Wolfram Sang
2017-02-27 21:30           ` [tpmdd-devel] " Enric Balletbo Serra
2017-02-27 21:30             ` Enric Balletbo Serra
2017-03-02 13:15           ` [tpmdd-devel] " Peter Huewe
2017-03-02 13:15             ` Peter Huewe
2017-03-02 14:05             ` [tpmdd-devel] " Wolfram Sang
2017-03-02 14:10             ` Wolfram Sang
2017-02-22 12:39   ` Peter Huewe
2017-02-22 12:39     ` Peter Huewe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffdfb321-6c9b-06fe-1a90-04da5457b47d@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=andrew@lunn.ch \
    --cc=apronin@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=tpmdd-devel@lists.sourceforge.net \
    --cc=tpmdd@selhorst.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.