Re: [PATCH] riscv: cpu-hotplug: clear cpu from numa map when teardown

From: Palmer Dabbelt <palmer@dabbelt.com>
To: kernelfans@gmail.com
Cc: linux-riscv@lists.infradead.org, kernelfans@gmail.com,
	Paul Walmsley <paul.walmsley@sifive.com>,
	aou@eecs.berkeley.edu, jszhang@kernel.org
Subject: Re: [PATCH] riscv: cpu-hotplug: clear cpu from numa map when teardown
Date: Tue, 08 Feb 2022 17:13:21 -0800 (PST)	[thread overview]
Message-ID: <mhng-9439ea0d-b7ab-48ed-a359-702383ad6321@palmer-ri-x1c9> (raw)
In-Reply-To: <20220123121352.13199-1-kernelfans@gmail.com>

On Sun, 23 Jan 2022 04:13:52 PST (-0800), kernelfans@gmail.com wrote:
> There is numa_add_cpu() when cpus online, accordingly, there should be
> numa_remove_cpu() when cpus offline.
>
> Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: Jisheng Zhang <jszhang@kernel.org>
> To: linux-riscv@lists.infradead.org
> ---
>  arch/riscv/kernel/cpu-hotplug.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/kernel/cpu-hotplug.c b/arch/riscv/kernel/cpu-hotplug.c
> index be7f05b542bb..78d156a359ef 100644
> --- a/arch/riscv/kernel/cpu-hotplug.c
> +++ b/arch/riscv/kernel/cpu-hotplug.c
> @@ -40,6 +40,7 @@ int __cpu_disable(void)
>  		return ret;
>
>  	remove_cpu_topology(cpu);
> +	numa_remove_cpu(cpu);
>  	set_cpu_online(cpu, false);
>  	irq_migrate_all_off_this_cpu();

Thanks, this is on fixes.  I don't really have any NUMA-related test 
setups, but if someone has a QEMU-based config that's meaningful then 
I'm happy to add it.

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv