From: Tay Ray Chuan <rctay89@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] remote-curl: ensure that URLs do not have a trailing slash
Date: Wed, 7 Apr 2010 23:57:28 +0800 [thread overview]
Message-ID: <p2ube6fef0d1004070857j874c2b60z6a4794d472b0ee8a@mail.gmail.com> (raw)
In-Reply-To: <7viq83e1pd.fsf@alter.siamese.dyndns.org>
Hi,
On Wed, Apr 7, 2010 at 11:12 PM, Junio C Hamano <gitster@pobox.com> wrote:
> The code does not look like it is making sure things do not have a
> trailing slash. For example, if svc has trailing slash, either %s/%s or
> strbuf_addf() would have the last character of svc in rpc->service_url.
>
> You are fixing something else.
>
> The new code avoids duplicated slashes in the middle if "url" can but does
> not necessarily end with a slash. Is that what you are trying to fix?
the commit message is misleading, yes. I'll have another go at it.
> I
> wonder if it makes more sense to make sure "url" always ends with a slash
> at the calling sites where it is obtained from either the end user or from
> the running environment...
Good idea.
--
Cheers,
Ray Chuan
next prev parent reply other threads:[~2010-04-07 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 14:51 [PATCH] remote-curl: ensure that URLs do not have a trailing slash Tay Ray Chuan
2010-04-07 15:12 ` Junio C Hamano
2010-04-07 15:57 ` Tay Ray Chuan [this message]
2010-04-07 15:58 ` [PATCH v2 1/2] http: make end_url_with_slash() public Tay Ray Chuan
2010-04-07 16:01 ` [PATCH v2 resend " Tay Ray Chuan
2010-04-07 16:01 ` [PATCH v2 resend 2/2] remote-curl: ensure that URLs have a trailing slash Tay Ray Chuan
2010-04-07 23:15 ` Junio C Hamano
2010-04-08 2:15 ` [PATCH v3 1/3] t5541-http-push: add test for URLs with " Tay Ray Chuan
2010-04-08 2:15 ` [PATCH v3 2/3] http: make end_url_with_slash() public Tay Ray Chuan
2010-04-08 2:15 ` [PATCH v3 3/3] remote-curl: ensure that URLs have a trailing slash Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p2ube6fef0d1004070857j874c2b60z6a4794d472b0ee8a@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.