From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A84DC433ED for ; Wed, 21 Apr 2021 16:13:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DC956144E for ; Wed, 21 Apr 2021 16:13:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238513AbhDUQOE (ORCPT ); Wed, 21 Apr 2021 12:14:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:53634 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235591AbhDUQOB (ORCPT ); Wed, 21 Apr 2021 12:14:01 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7F285B50E; Wed, 21 Apr 2021 16:13:27 +0000 (UTC) Date: Wed, 21 Apr 2021 18:13:27 +0200 Message-ID: From: Takashi Iwai To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Wenwen Wang Subject: Re: [PATCH 080/190] Revert "ALSA: usx2y: fix a double free bug" In-Reply-To: <20210421130105.1226686-81-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-81-gregkh@linuxfoundation.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 21 Apr 2021 14:59:15 +0200, Greg Kroah-Hartman wrote: > > This reverts commit cbb88db76a1536e02e93e5bd37ebbfbb6c4043a9. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. > > Cc: Wenwen Wang > Cc: Takashi Iwai > Signed-off-by: Greg Kroah-Hartman I examined the change again, and confirmed that this code change itself is correct, so it's not necessary to revert. OTOH, it's just a tip of iceberg in this driver, and maybe it's better to cover all in a better way. So it's fine to revert this, either. thanks, Takashi > --- > sound/usb/usx2y/usbusx2y.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/usb/usx2y/usbusx2y.c b/sound/usb/usx2y/usbusx2y.c > index 3cd28d24f0a7..bb188245b0e2 100644 > --- a/sound/usb/usx2y/usbusx2y.c > +++ b/sound/usb/usx2y/usbusx2y.c > @@ -279,8 +279,10 @@ int usX2Y_In04_init(struct usX2Ydev *usX2Y) > if (! (usX2Y->In04urb = usb_alloc_urb(0, GFP_KERNEL))) > return -ENOMEM; > > - if (! (usX2Y->In04Buf = kmalloc(21, GFP_KERNEL))) > + if (! (usX2Y->In04Buf = kmalloc(21, GFP_KERNEL))) { > + usb_free_urb(usX2Y->In04urb); > return -ENOMEM; > + } > > init_waitqueue_head(&usX2Y->In04WaitQueue); > usb_fill_int_urb(usX2Y->In04urb, usX2Y->dev, usb_rcvintpipe(usX2Y->dev, 0x4), > -- > 2.31.1 >