All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hui Wang <hui.wang@canonical.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ALSA: hda - Don't trigger jackpoll_work in azx_resume
Date: Tue, 19 Mar 2019 06:56:24 +0100	[thread overview]
Message-ID: <s5hd0mnxv93.wl-tiwai@suse.de> (raw)
In-Reply-To: <20190319012844.6543-1-hui.wang@canonical.com>

On Tue, 19 Mar 2019 02:28:43 +0100,
Hui Wang wrote:
> 
> The commit 3baffc4a84d7 (ALSA: hda/intel: Refactoring PM code) changed
> the behaviour of azx_resume(), it triggers the jackpoll_work after
> applying this commit.
> 
> This change introduced a new issue, all codecs are runtime active
> after S3, and will not call runtime_suspend() automatically.
> 
> The root cause is the jackpoll_work calls snd_hda_power_up/down_pm,
> and it calls up_pm before snd_hdac_enter_pm is called, while calls
> the down_pm in the middle of enter_pm and leave_pm is called. This
> makes the dev->power.usage_count unbalanced after S3.
> 
> To fix it, let azx_resume() don't trigger jackpoll_work as before
> it did.
> 
> Fixes:  3baffc4a84d7 (ALSA: hda/intel: Refactoring PM code)
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Applied, thanks.


Takashi

      parent reply	other threads:[~2019-03-19  5:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  1:28 [PATCH 1/2] ALSA: hda - Don't trigger jackpoll_work in azx_resume Hui Wang
2019-03-19  1:28 ` [PATCH 2/2] ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec Hui Wang
2019-03-19  5:56   ` Takashi Iwai
2019-03-19  5:56 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hd0mnxv93.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hui.wang@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.