From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933169AbeEWNy7 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 23 May 2018 09:54:59 -0400
Received: from mx2.suse.de ([195.135.220.15]:59401 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932900AbeEWNy4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 23 May 2018 09:54:56 -0400
Date: Wed, 23 May 2018 15:54:54 +0200
Message-ID: <s5hmuwqpjdd.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Guenter Roeck" <groeck@google.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>, <alsa-devel@alsa-project.org>,
        "Guenter Roeck" <groeck@chromium.org>,
        "Chintan Patel" <chintan.m.patel@intel.com>,
        "Mark Brown" <broonie@kernel.org>, "Jaroslav Kysela" <perex@perex.cz>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files
In-Reply-To: <20180522165842.233949-1-groeck@google.com>
References: <20180522165842.233949-1-groeck@google.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 22 May 2018 18:58:42 +0200,
Guenter Roeck wrote:
> 
> +struct skl_dfw_v4_module_caps {
> +	u32 set_params:2;
> +	u32 rsvd:30;
> +	u32 param_id;
> +	u32 caps_size;
> +	u32 caps[HDA_SST_CFG_MAX];
> +};

Missing __packed attribute?

And I'm wondering whether we should move these definitions to uapi
headers.


thanks,

Takashi

From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards
	compatibility with v4 topology files
Date: Wed, 23 May 2018 15:54:54 +0200
Message-ID: <s5hmuwqpjdd.wl-tiwai@suse.de>
References: <20180522165842.233949-1-groeck@google.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id D1560267265
 for <alsa-devel@alsa-project.org>; Wed, 23 May 2018 15:54:57 +0200 (CEST)
In-Reply-To: <20180522165842.233949-1-groeck@google.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Guenter Roeck <groeck@google.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Chintan Patel <chintan.m.patel@intel.com>, Guenter Roeck <groeck@chromium.org>
List-Id: alsa-devel@alsa-project.org

On Tue, 22 May 2018 18:58:42 +0200,
Guenter Roeck wrote:
> 
> +struct skl_dfw_v4_module_caps {
> +	u32 set_params:2;
> +	u32 rsvd:30;
> +	u32 param_id;
> +	u32 caps_size;
> +	u32 caps[HDA_SST_CFG_MAX];
> +};

Missing __packed attribute?

And I'm wondering whether we should move these definitions to uapi
headers.


thanks,

Takashi