From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932431AbZJAIhE (ORCPT ); Thu, 1 Oct 2009 04:37:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932414AbZJAIg6 (ORCPT ); Thu, 1 Oct 2009 04:36:58 -0400 Received: from cantor.suse.de ([195.135.220.2]:38684 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbZJAIg4 (ORCPT ); Thu, 1 Oct 2009 04:36:56 -0400 Date: Thu, 01 Oct 2009 10:36:59 +0200 Message-ID: From: Takashi Iwai To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: linux-kernel@vger.kernel.org, Sam Ravnborg , Andrew Morton , Jaroslav Kysela , alsa-devel@alsa-project.org Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove In-Reply-To: <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 1 Oct 2009 10:28:10 +0200, Uwe Kleine-König wrote: > > The function hal2_remove is defined using __exit, so don't use __devexit_p > but __exit_p to wrap it. I think it's the other way round. We should replace __exit with __devexit. Ditto for sound/mips/sgio2audio.c. thanks, Takashi > > Signed-off-by: Uwe Kleine-König > Cc: Takashi Iwai > Cc: Jaroslav Kysela > Cc: alsa-devel@alsa-project.org > Cc: linux-kernel@vger.kernel.org > --- > sound/mips/hal2.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sound/mips/hal2.c b/sound/mips/hal2.c > index c52691c..72523a7 100644 > --- a/sound/mips/hal2.c > +++ b/sound/mips/hal2.c > @@ -926,7 +926,7 @@ static int __exit hal2_remove(struct platform_device *pdev) > > static struct platform_driver hal2_driver = { > .probe = hal2_probe, > - .remove = __devexit_p(hal2_remove), > + .remove = __exit_p(hal2_remove), > .driver = { > .name = "sgihal2", > .owner = THIS_MODULE, > -- > 1.6.4.3 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 06/34] don't use __devexit_p to wrap hal2_remove Date: Thu, 01 Oct 2009 10:36:59 +0200 Message-ID: References: <20091001082607.GA2181@pengutronix.de> <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (cantor.suse.de [195.135.220.2]) by alsa0.perex.cz (Postfix) with ESMTP id 0F0961038F6 for ; Thu, 1 Oct 2009 10:37:00 +0200 (CEST) In-Reply-To: <1254385718-14254-6-git-send-email-u.kleine-koenig@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= Cc: Andrew Morton , Sam Ravnborg , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org QXQgVGh1LCAgMSBPY3QgMjAwOSAxMDoyODoxMCArMDIwMCwKVXdlIEtsZWluZS1Lw7ZuaWcgd3Jv dGU6Cj4gCj4gVGhlIGZ1bmN0aW9uIGhhbDJfcmVtb3ZlIGlzIGRlZmluZWQgdXNpbmcgX19leGl0 LCBzbyBkb24ndCB1c2UgX19kZXZleGl0X3AKPiBidXQgX19leGl0X3AgdG8gd3JhcCBpdC4KCkkg dGhpbmsgaXQncyB0aGUgb3RoZXIgd2F5IHJvdW5kLiAgV2Ugc2hvdWxkIHJlcGxhY2UgX19leGl0 IHdpdGggX19kZXZleGl0LgpEaXR0byBmb3Igc291bmQvbWlwcy9zZ2lvMmF1ZGlvLmMuCgoKdGhh bmtzLAoKVGFrYXNoaQoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5r bGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRlPgo+IENjOiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1 c2UuZGU+Cj4gQ2M6IEphcm9zbGF2IEt5c2VsYSA8cGVyZXhAcGVyZXguY3o+Cj4gQ2M6IGFsc2Et ZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwo+IENjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3Jn Cj4gLS0tCj4gIHNvdW5kL21pcHMvaGFsMi5jIHwgICAgMiArLQo+ICAxIGZpbGVzIGNoYW5nZWQs IDEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvc291bmQv bWlwcy9oYWwyLmMgYi9zb3VuZC9taXBzL2hhbDIuYwo+IGluZGV4IGM1MjY5MWMuLjcyNTIzYTcg MTAwNjQ0Cj4gLS0tIGEvc291bmQvbWlwcy9oYWwyLmMKPiArKysgYi9zb3VuZC9taXBzL2hhbDIu Ywo+IEBAIC05MjYsNyArOTI2LDcgQEAgc3RhdGljIGludCBfX2V4aXQgaGFsMl9yZW1vdmUoc3Ry dWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCj4gIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1f ZHJpdmVyIGhhbDJfZHJpdmVyID0gewo+ICAJLnByb2JlCT0gaGFsMl9wcm9iZSwKPiAtCS5yZW1v dmUJPSBfX2RldmV4aXRfcChoYWwyX3JlbW92ZSksCj4gKwkucmVtb3ZlCT0gX19leGl0X3AoaGFs Ml9yZW1vdmUpLAo+ICAJLmRyaXZlciA9IHsKPiAgCQkubmFtZQk9ICJzZ2loYWwyIiwKPiAgCQku b3duZXIJPSBUSElTX01PRFVMRSwKPiAtLSAKPiAxLjYuNC4zCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFs c2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3Jn L21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo=