From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F91C433E0 for ; Wed, 10 Mar 2021 16:38:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9003764FCA for ; Wed, 10 Mar 2021 16:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232347AbhCJQho (ORCPT ); Wed, 10 Mar 2021 11:37:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:35854 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229467AbhCJQh1 (ORCPT ); Wed, 10 Mar 2021 11:37:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 01531ABD7; Wed, 10 Mar 2021 16:37:26 +0000 (UTC) Date: Wed, 10 Mar 2021 17:37:25 +0100 Message-ID: From: Takashi Iwai To: Mark Brown Cc: Pierre-Louis Bossart , alsa-devel@alsa-project.org, Kai Vehmanen , Liam Girdwood , linux-kernel@vger.kernel.org, Takashi Iwai , Ranjani Sridharan , linux-tegra@vger.kernel.org, Jon Hunter , Bard liao Subject: Re: [PATCH V2] ASoC: soc-core: Prevent warning if no DMI table is present In-Reply-To: <20210310161814.GA28564@sirena.org.uk> References: <20210303115526.419458-1-jonathanh@nvidia.com> <91480f92-a3f5-e71f-acdc-ea74488ab0a1@linux.intel.com> <20210310133534.GD4746@sirena.org.uk> <6a2352e6-f2b7-def1-de58-52fbeb7846e5@linux.intel.com> <20210310161814.GA28564@sirena.org.uk> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Wed, 10 Mar 2021 17:18:14 +0100, Mark Brown wrote: > > On Wed, Mar 10, 2021 at 09:44:07AM -0600, Pierre-Louis Bossart wrote: > > On 3/10/21 7:35 AM, Mark Brown wrote: > > > > Just change it to a system level check for ACPI, checking for OF would > > > leave problems for board files or any other alternative firmware > > > interfaces. > > > did you mean if (!IS_ENABLED(CONFIG_ACPI)) ? > > Is there a runtime check? Well, basically both DMI and ACPI are completely different things, so I don't think it's right to check the availability of ACPI as a signal of the availability of DMI. Takashi