From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751933AbdDBTSY (ORCPT ); Sun, 2 Apr 2017 15:18:24 -0400 Received: from terminus.zytor.com ([65.50.211.136]:42979 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdDBTSV (ORCPT ); Sun, 2 Apr 2017 15:18:21 -0400 Date: Sun, 2 Apr 2017 12:12:01 -0700 From: tip-bot for Ravi Bangoria Message-ID: Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, ravi.bangoria@linux.vnet.ibm.com, alexis.berlemont@gmail.com, acme@redhat.com, peterz@infradead.org, tglx@linutronix.de, hemant@linux.vnet.ibm.com, mingo@kernel.org, mpe@ellerman.id.au, hpa@zytor.com, naveen.n.rao@linux.vnet.ibm.com Reply-To: tglx@linutronix.de, peterz@infradead.org, alexis.berlemont@gmail.com, acme@redhat.com, hemant@linux.vnet.ibm.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org, ravi.bangoria@linux.vnet.ibm.com, alexander.shishkin@linux.intel.com, naveen.n.rao@linux.vnet.ibm.com, mpe@ellerman.id.au, mingo@kernel.org, hpa@zytor.com In-Reply-To: <20170328094754.3156-2-ravi.bangoria@linux.vnet.ibm.com> References: <20170328094754.3156-2-ravi.bangoria@linux.vnet.ibm.com> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf/sdt/x86: Add renaming logic for (missing) 8 bit registers Git-Commit-ID: 2d01ecc580405169ecd6e3880617bc61cf482fdd X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 2d01ecc580405169ecd6e3880617bc61cf482fdd Gitweb: http://git.kernel.org/tip/2d01ecc580405169ecd6e3880617bc61cf482fdd Author: Ravi Bangoria AuthorDate: Tue, 28 Mar 2017 15:17:52 +0530 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 28 Mar 2017 12:24:56 -0300 perf/sdt/x86: Add renaming logic for (missing) 8 bit registers I found couple of events using al, bl, cl and dl registers for argument. These are not directly accepted by uprobe_events and thus needs to be mapped to ax, bx, cx and dx respectively. Few ex, /usr/bin/qemu-system-s390x css_adapter_interrupt: 1@%bl css_chpid_add: 1@%cl 1@%sil 1@%dl dma_bdrv_io: 8@%rbx 8@%rbp -8@%r14 1@%al /usr/bin/postgres buffer__read__done: ... -1@-bash -1@%al buffer__read__start: ... -1@%al I don't find any sdt events using ah, bh,... registers. But I also don't see any reason to not use them, so there might be rare events using these registers, and if so, perf should have a renaming logic for them too. Signed-off-by: Ravi Bangoria Acked-by: Masami Hiramatsu Cc: Alexander Shishkin Cc: Alexis Berlemont Cc: Hemant Kumar Cc: Michael Ellerman Cc: Naveen N. Rao Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/20170328094754.3156-2-ravi.bangoria@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/x86/util/perf_regs.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/perf/arch/x86/util/perf_regs.c b/tools/perf/arch/x86/util/perf_regs.c index d8a8dcf..fa1fd19 100644 --- a/tools/perf/arch/x86/util/perf_regs.c +++ b/tools/perf/arch/x86/util/perf_regs.c @@ -40,12 +40,20 @@ struct sdt_name_reg { static const struct sdt_name_reg sdt_reg_renamings[] = { SDT_NAME_REG(eax, ax), SDT_NAME_REG(rax, ax), + SDT_NAME_REG(al, ax), + SDT_NAME_REG(ah, ax), SDT_NAME_REG(ebx, bx), SDT_NAME_REG(rbx, bx), + SDT_NAME_REG(bl, bx), + SDT_NAME_REG(bh, bx), SDT_NAME_REG(ecx, cx), SDT_NAME_REG(rcx, cx), + SDT_NAME_REG(cl, cx), + SDT_NAME_REG(ch, cx), SDT_NAME_REG(edx, dx), SDT_NAME_REG(rdx, dx), + SDT_NAME_REG(dl, dx), + SDT_NAME_REG(dh, dx), SDT_NAME_REG(esi, si), SDT_NAME_REG(rsi, si), SDT_NAME_REG(sil, si),