Re: [PATCH 1/5] t1507: add additional tests for @{upstream}

From: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>, git@vger.kernel.org
Subject: Re: [PATCH 1/5] t1507: add additional tests for @{upstream}
Date: Wed, 11 Apr 2012 19:59:23 +0200	[thread overview]
Message-ID: <vpqk41m40as.fsf@bauges.imag.fr> (raw)
In-Reply-To: <7vfwcakvfw.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 11 Apr 2012 10:52:19 -0700")

Junio C Hamano <gitster@pobox.com> writes:

> We may want to update the error message for "@{u}" when the current one is
> not tracked, instead of saying ''.  Perhaps
>
> 	error: No upstream branch found for the current branch.
>
> or something?
>
> Likewise for the detached HEAD case.

This is indeed the point of the patch serie, and I like how it first
shows how bad the error messages can be, and then illustrate the fix
with patch hunks in the newly added testcases in further patches.

But the commit message for this patch could probably be improved: we
usually do not give a list of _what_ is done, since the code already
says that, but we insist on _why_ it is done.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/