From: Alberto Garcia <berto@igalia.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation
Date: Thu, 13 Apr 2017 16:15:57 +0200 [thread overview]
Message-ID: <w51k26ov1eq.fsf@maestria.local.igalia.com> (raw)
In-Reply-To: <20170413135155.GD5095@noname.redhat.com>
On Thu 13 Apr 2017 03:51:55 PM CEST, Kevin Wolf wrote:
>> This invariant is already broken by the very design of the qcow2
>> format, subclusters don't really add anything new there. For any
>> given cluster size you can write 4k in every odd cluster, then do the
>> same in every even cluster, and you'll get an equally fragmented
>> image.
>
> Because this scenario has appeared repeatedly in this thread: Can we
> please use a more realistic one that shows an actual problem? Because
> with 8k or more for the cluster size you don't get any qcow2
> fragmentation with 4k even/odd writes (which is a pathological case
> anyway), and the file systems are clever enough to cope with it, too.
>
> Just to confirm this experimentally, I ran this short script:
>
> ----------------------------------------------------------------
> #!/bin/bash
> ./qemu-img create -f qcow2 /tmp/test.qcow2 64M
>
> echo even blocks
> for i in $(seq 0 32767); do echo "write $((i * 8))k 4k"; done | ./qemu-io /tmp/test.qcow2 > /dev/null
> echo odd blocks
> for i in $(seq 0 32767); do echo "write $((i * 8 + 4))k 4k"; done | ./qemu-io /tmp/test.qcow2 > /dev/null
>
> ./qemu-img map /tmp/test.qcow2
> filefrag -v /tmp/test.qcow2
> ----------------------------------------------------------------
But that's because while you're writing on every other 4k block the
cluster size is 64k, so you're effectively allocating clusters in
sequential order. That's why you get this:
> Offset Length Mapped to File
> 0 0x4000000 0x50000 /tmp/test.qcow2
You would need to either have 4k clusters, or space writes even more.
Here's a simpler example, mkfs.ext4 on an empty drive gets you something
like this:
----------------------------------------------------------------
Offset Length Mapped to File
[...]
0x1040000 0x10000 0x150000 test.qcow2
0x1050000 0x50000 0x100000 test.qcow2
0x10a0000 0x10000 0x190000 test.qcow2
0x10b0000 0x30000 0x160000 test.qcow2
0x10e0000 0x10000 0x200000 test.qcow2
0x10f0000 0x30000 0x1a0000 test.qcow2
0x1120000 0x10000 0x210000 test.qcow2
0x1130000 0x30000 0x1d0000 test.qcow2
0x1160000 0x10000 0x280000 test.qcow2
0x1170000 0x30000 0x220000 test.qcow2
[...]
----------------------------------------------------------------
Now, I haven't measured the effect of this on I/O performance, but
Denis's point seems in principle valid to me.
Berto
next prev parent reply other threads:[~2017-04-13 14:16 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-06 15:01 [Qemu-devel] [RFC] Proposed qcow2 extension: subcluster allocation Alberto Garcia
2017-04-06 16:40 ` Eric Blake
2017-04-07 8:49 ` Alberto Garcia
2017-04-07 12:41 ` Kevin Wolf
2017-04-07 14:24 ` Alberto Garcia
2017-04-21 21:09 ` [Qemu-devel] proposed qcow2 extension: cluster reservations [was: " Eric Blake
2017-04-22 17:56 ` Max Reitz
2017-04-24 11:45 ` Kevin Wolf
2017-04-24 12:46 ` Alberto Garcia
2017-04-07 12:20 ` [Qemu-devel] " Stefan Hajnoczi
2017-04-07 12:24 ` Alberto Garcia
2017-04-07 13:01 ` Kevin Wolf
2017-04-10 15:32 ` Stefan Hajnoczi
2017-04-07 17:10 ` Max Reitz
2017-04-10 8:42 ` Kevin Wolf
2017-04-10 15:03 ` Max Reitz
2017-04-11 12:56 ` Alberto Garcia
2017-04-11 14:04 ` Max Reitz
2017-04-11 14:31 ` Alberto Garcia
2017-04-11 14:45 ` [Qemu-devel] [Qemu-block] " Eric Blake
2017-04-12 12:41 ` Alberto Garcia
2017-04-12 14:10 ` Max Reitz
2017-04-13 8:05 ` Alberto Garcia
2017-04-13 9:02 ` Kevin Wolf
2017-04-13 9:05 ` Alberto Garcia
2017-04-11 14:49 ` [Qemu-devel] " Kevin Wolf
2017-04-11 14:58 ` Eric Blake
2017-04-11 14:59 ` Max Reitz
2017-04-11 15:08 ` Eric Blake
2017-04-11 15:18 ` Max Reitz
2017-04-11 15:29 ` Kevin Wolf
2017-04-11 15:29 ` Max Reitz
2017-04-11 15:30 ` Eric Blake
2017-04-11 15:34 ` Max Reitz
2017-04-12 12:47 ` Alberto Garcia
2017-04-12 16:54 ` Denis V. Lunev
2017-04-13 11:58 ` Alberto Garcia
2017-04-13 12:44 ` Denis V. Lunev
2017-04-13 13:05 ` Kevin Wolf
2017-04-13 13:09 ` Denis V. Lunev
2017-04-13 13:36 ` Alberto Garcia
2017-04-13 14:06 ` Denis V. Lunev
2017-04-13 13:21 ` Alberto Garcia
2017-04-13 13:30 ` Denis V. Lunev
2017-04-13 13:59 ` Kevin Wolf
2017-04-13 15:04 ` Alberto Garcia
2017-04-13 15:17 ` Denis V. Lunev
2017-04-18 11:52 ` Alberto Garcia
2017-04-18 17:27 ` Denis V. Lunev
2017-04-13 13:51 ` Kevin Wolf
2017-04-13 14:15 ` Alberto Garcia [this message]
2017-04-13 14:27 ` Kevin Wolf
2017-04-13 16:42 ` [Qemu-devel] [Qemu-block] " Roman Kagan
2017-04-13 14:42 ` [Qemu-devel] " Denis V. Lunev
2017-04-12 17:55 ` Denis V. Lunev
2017-04-12 18:20 ` Eric Blake
2017-04-12 19:02 ` Denis V. Lunev
2017-04-13 9:44 ` Kevin Wolf
2017-04-13 10:19 ` Denis V. Lunev
2017-04-14 1:06 ` [Qemu-devel] [Qemu-block] " John Snow
2017-04-14 4:17 ` Denis V. Lunev
2017-04-18 11:22 ` Kevin Wolf
2017-04-18 17:30 ` Denis V. Lunev
2017-04-14 7:40 ` Roman Kagan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w51k26ov1eq.fsf@maestria.local.igalia.com \
--to=berto@igalia.com \
--cc=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.