From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Moyer Subject: Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru Date: Tue, 10 Nov 2015 16:45:16 -0500 Message-ID: References: <2792786733bc18d561ca352d7a642b3989a370fa.1446684001.git.jerry.hoemann@hpe.com> <20151110213613.GC47666@tevye.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41331 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbbKJVpS (ORCPT ); Tue, 10 Nov 2015 16:45:18 -0500 In-Reply-To: <20151110213613.GC47666@tevye.fc.hp.com> (Jerry Hoemann's message of "Tue, 10 Nov 2015 14:36:13 -0700") Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Jerry.Hoemann@hpe.com Cc: ross.zwisler@linux.intel.com, rjw@rjwysocki.net, lenb@kernel.org, dan.j.williams@intel.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org Jerry Hoemann writes: > On Tue, Nov 10, 2015 at 11:24:47AM -0500, Jeff Moyer wrote: >> Jerry Hoemann writes: >> >> > @@ -633,10 +718,11 @@ static int match_dimm(struct device *dev, void *data) >> > >> > static long nvdimm_ioctl(struct file *file, unsigned int cmd, unsigned long arg) >> > { >> > - int rc = -ENXIO, read_only; >> > + int rc = -ENXIO, ro; >> > struct nvdimm_bus *nvdimm_bus; >> > + unsigned int type = _IOC_TYPE(cmd); >> > >> > - read_only = (O_RDWR != (file->f_flags & O_ACCMODE)); >> > + ro = (O_RDWR != (file->f_flags & O_ACCMODE)); >> >> I'm still reviewing the rest of this, but this is bugging me. The >> existing check for read_only looks pretty fishy to me. O_WRONLY is a >> thing (even though it's probably not a supportable mode for this ioctl). >> Why not just check for O_RDONLY? > > > Good question. I'll look into changing for version 2. > I suspect you would like something more like: > > ro = ((file->f_flags & O_ACCMODE) == O_RDONLY); Yeah. I'd make that a separate patch, and put it first in the series since it's a cleanup than can be applied to older kernels if necessary. Thanks, Jeff