From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Christian Neukirchen <chneukirchen@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: git commit -p with file arguments
Date: Fri, 09 Sep 2016 11:03:20 -0700 [thread overview]
Message-ID: <xmqq8tv1c5nb.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+P7+xoN+q_Kst=qXG_HRznxbN7cbyi5uZe15zq1c16EifeK1Q@mail.gmail.com> (Jacob Keller's message of "Fri, 9 Sep 2016 09:57:44 -0700")
Jacob Keller <jacob.keller@gmail.com> writes:
> It wants to commit bar too because you already added bar before. It works like:
>
> "git add bar && git add -p foo && git commit" does it not?
>
> I fail to see why "git commit -p <path>" would unstage the bar you
> already added? Or am I missing some assumption here?
Yes.
"git commit -p <pathspec>" were added originally for lazy people who
do not want to type "git add -p <pathspec> && git commit", which
matches your expectation. If you already added "bar" that is
outside of the <pathspec> given to "add -p", the final "git commit"
step would record the latest contents of "bar" in it.
For obvious reasons, "git commit -p <pathspec>" cannot be a
short-hand to "git add -p <pathspec> && git commit <pathspec>", so
the current behaviour was the best they could do for those who aded
"commit -p", I guess.
next prev parent reply other threads:[~2016-09-09 18:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 21:08 git commit -p with file arguments Christian Neukirchen
2016-09-09 10:54 ` Duy Nguyen
2016-10-05 10:26 ` Duy Nguyen
2016-10-05 11:38 ` Christian Neukirchen
2016-10-05 17:16 ` Junio C Hamano
2016-09-09 16:57 ` Jacob Keller
2016-09-09 17:05 ` Christian Neukirchen
2016-09-09 18:03 ` Junio C Hamano [this message]
2016-09-09 20:39 ` Jakub Narębski
2016-09-09 20:52 ` Christian Neukirchen
2016-09-10 9:52 ` Jakub Narębski
2016-09-11 21:50 ` Junio C Hamano
2016-09-11 22:05 ` Jacob Keller
2016-09-12 1:57 ` Junio C Hamano
2016-09-12 4:56 ` Jacob Keller
2016-09-12 21:14 ` Jakub Narębski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8tv1c5nb.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=chneukirchen@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.