All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Mostyn Bramley-Moore <mostyn@antipode.se>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Documentation: improve git ls-files -s manpage entry
Date: Fri, 31 Mar 2017 19:21:32 -0700	[thread overview]
Message-ID: <xmqqpogwx3yr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170331194708.22437-1-mostyn@antipode.se> (Mostyn Bramley-Moore's message of "Fri, 31 Mar 2017 21:47:08 +0200")

Mostyn Bramley-Moore <mostyn@antipode.se> writes:

> List the fields in order of appearance in the command output.
>
> Signed-off-by: Mostyn Bramley-Moore <mostyn@antipode.se>
> ---
>  Documentation/git-ls-files.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/git-ls-files.txt b/Documentation/git-ls-files.txt
> index 1cab703..a9149fc 100644
> --- a/Documentation/git-ls-files.txt
> +++ b/Documentation/git-ls-files.txt
> @@ -57,7 +57,8 @@ OPTIONS
>  
>  -s::
>  --stage::
> -	Show staged contents' object name, mode bits and stage number in the output.
> +	Show staged contents' mode bits, hash, stage number as well as the
> +	object name in the output.

This is not an improvement, as the word "hash" is merely a
colloquial way to say what is officially known as "object name".

If the patch were only to swap "mode bits" and "object name" without
doing anything else, it may have been an improvement, though.  It is
implied that the path the output line talks about is shown, and that
is why we do not say "mode bits, object name, stage number and the
pathname".

>  
>  --directory::
>  	If a whole directory is classified as "other", show just its

  reply	other threads:[~2017-04-01  2:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-31 19:47 [PATCH] Documentation: improve git ls-files -s manpage entry Mostyn Bramley-Moore
2017-04-01  2:21 ` Junio C Hamano [this message]
2017-04-01  7:08   ` [PATCH v2] " Mostyn Bramley-Moore
2017-04-01 18:16     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpogwx3yr.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mostyn@antipode.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.