From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v2 2/7] ASoC: codec: lpass-rx-macro: add support for lpass rx macro
Date: Mon, 8 Feb 2021 16:17:02 +0000 [thread overview]
Message-ID: <1397a895-c205-ae1a-5319-28cfacaa4ecb@linaro.org> (raw)
In-Reply-To: <20210208160830.GI8645@sirena.org.uk>
On 08/02/2021 16:08, Mark Brown wrote:
>> + SOC_SINGLE_EXT("RX_Softclip Enable", SND_SOC_NOPM, 0, 1, 0,
>> + rx_macro_soft_clip_enable_get,
>> + rx_macro_soft_clip_enable_put),
>> + SOC_SINGLE_EXT("AUX_HPF Enable", SND_SOC_NOPM, 0, 1, 0,
>> + rx_macro_aux_hpf_mode_get,
>> + rx_macro_aux_hpf_mode_put),
> These are simple on/off controls so should end in Switch AFAICT.
Yes it makes sense!
> Otherwise this looks good.
Thanks, will fix this and send a new version!
--srini
next prev parent reply other threads:[~2021-02-08 16:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 14:17 [PATCH v2 0/7] ASoC: codecs: add support for LPASS Codec TX and RX macros Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 1/7] ASoC: qcom: dt-bindings: add bindings for lpass rx macro codec Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 2/7] ASoC: codec: lpass-rx-macro: add support for lpass rx macro Srinivas Kandagatla
2021-02-08 16:08 ` Mark Brown
2021-02-08 16:17 ` Srinivas Kandagatla [this message]
2021-02-08 14:17 ` [PATCH v2 3/7] ASoC: codec: lpass-rx-macro: add dapm widgets and route Srinivas Kandagatla
2021-02-09 6:34 ` kernel test robot
2021-02-08 14:17 ` [PATCH v2 4/7] ASoC: codec: lpass-rx-macro: add iir widgets Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 5/7] ASoC: qcom: dt-bindings: add bindings for lpass tx macro codec Srinivas Kandagatla
2021-02-08 14:17 ` [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro Srinivas Kandagatla
2021-02-10 6:36 ` kernel test robot
2021-02-08 14:17 ` [PATCH v2 7/7] ASoC: codec: lpass-tx-macro: add dapm widgets and route Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397a895-c205-ae1a-5319-28cfacaa4ecb@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).