From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DA4CCA9EA0 for ; Mon, 28 Oct 2019 08:22:10 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C96C20B7C for ; Mon, 28 Oct 2019 08:22:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="PnQvitTg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C96C20B7C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=chris-wilson.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AA15C1EE2; Mon, 28 Oct 2019 09:21:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AA15C1EE2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572250927; bh=/VqOqynsgUn0VF2Lxl/YxRaS9nX8JCndVMcNahbrSmI=; h=To:From:In-Reply-To:References:Date:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=PnQvitTgrvbm8i4orrqiXYvfZc6ILJ9zG60yVUT5krB2RyEcIYmY6OgsiYAzp9f6h etBViQULd8janyab1f/Qbg0vZgOSwOXmW8P3/ZKHXjysWQq0p93JTg2URxx11r6bAM MkswuFIY43sKCxJbPHnzbkfRPQDamzgX7pFqT8ZI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 41C45F80361; Mon, 28 Oct 2019 09:21:17 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 619C6F803D6; Mon, 28 Oct 2019 09:21:15 +0100 (CET) Received: from fireflyinternet.com (mail.fireflyinternet.com [109.228.58.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6975F8011D for ; Mon, 28 Oct 2019 09:21:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6975F8011D X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Received: from localhost (unverified [78.156.65.138]) by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 18989422-1500050 for multiple; Mon, 28 Oct 2019 08:21:09 +0000 MIME-Version: 1.0 To: Takashi Iwai , alsa-devel@alsa-project.org From: Chris Wilson In-Reply-To: <20191028081056.22010-1-tiwai@suse.de> References: <20191028081056.22010-1-tiwai@suse.de> Message-ID: <157225086749.26808.5121664839140883561@skylake-alporthouse-com> User-Agent: alot/0.6 Date: Mon, 28 Oct 2019 08:21:07 +0000 Cc: Jonas Witschel Subject: Re: [alsa-devel] [PATCH] Revert "ALSA: hda: Flush interrupts on disabling" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Quoting Takashi Iwai (2019-10-28 08:10:56) > This reverts commit caa8422d01e983782548648e125fd617cadcec3f. > > It turned out that this commit caused a regression at shutdown / > reboot, as the synchronize_irq() calls seems blocking the whole > shutdown. Also another part of the change about shuffling the call > order looks suspicious; the azx_stop_chip() call disables the CORB / > RIRB while the others may still need the CORB/RIRB update. > > Since the original commit itself was a cargo-fix, let's revert the > whole patch. You will want to include a link to the bug you may be reintroducing so you have that information for easy reference later. Also do you know if you fixed the bug in any other way, because our CI hasn't reported that GPF since the patch landed. -Chris _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel