From: Mark Brown <broonie@kernel.org>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"Mukunda, Vijendar" <Vijendar.Mukunda@amd.com>,
"RAVULAPATI,
VISHNU VARDHAN RAO" <Vishnuvardhanrao.Ravulapati@amd.com>,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts
Date: Tue, 1 Oct 2019 18:29:41 +0100 [thread overview]
Message-ID: <20191001172941.GC4786@sirena.co.uk> (raw)
In-Reply-To: <BN6PR12MB18093C8EDE60811B3D917DEAF79D0@BN6PR12MB1809.namprd12.prod.outlook.com>
[-- Attachment #1.1: Type: text/plain, Size: 612 bytes --]
On Tue, Oct 01, 2019 at 05:23:43PM +0000, Deucher, Alexander wrote:
> > ACP-PCI controller driver does not depends msi interrupts.
> > So removed msi related pci functions which have no use and does not impact
> > on existing functionality.
> In general, however, aren't MSIs preferred to legacy interrupts?
As I understand it. Or at the very least I'm not aware of any situation
where they're harmful. It'd be good to have a clear explanation of why
we're removing the support.
> Doesn't the driver have to opt into MSI support? As such, won't
> removing this code effectively disable MSI support?
Yes.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-01 17:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 0:58 [alsa-devel] [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 2/7] ASoC: amd: Registering device endpoints using MFD framework Ravulapati Vishnu vardhan rao
2019-10-01 6:45 ` Lee Jones
2019-10-01 10:00 ` vishnu
2019-10-01 12:00 ` Lee Jones
2019-10-01 18:53 ` Deucher, Alexander
2019-10-02 12:37 ` Lee Jones
2019-10-02 13:11 ` Deucher, Alexander
2019-10-02 13:35 ` Lee Jones
2019-10-10 13:08 ` RAVULAPATI, VISHNU VARDHAN RAO
2019-10-14 7:03 ` Lee Jones
2019-10-17 9:26 ` vishnu
2019-10-01 0:58 ` [alsa-devel] [PATCH 3/7] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 4/7] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 5/7] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 6/7] ASoC: AMD: handle ACP3x i2s-sp watermark interrupt Ravulapati Vishnu vardhan rao
2019-10-01 0:58 ` [alsa-devel] [PATCH 7/7] ASoc: amd: Added ACP3x system resume and runtime pm ops Ravulapati Vishnu vardhan rao
2019-10-01 17:23 ` [alsa-devel] [PATCH 1/7] ASoC: amd: No need PCI-MSI interrupts Deucher, Alexander
2019-10-01 17:29 ` Mark Brown [this message]
2019-10-10 10:40 ` vishnu
2019-10-17 9:33 ` vishnu
2019-10-17 11:12 ` Mark Brown
2019-10-17 13:56 ` Deucher, Alexander
2019-10-17 9:31 ` vishnu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001172941.GC4786@sirena.co.uk \
--to=broonie@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).