From: Mark Brown <broonie@kernel.org>
To: David Rhodes <david.rhodes@cirrus.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
ckeepax@opensource.cirrus.com, lgirdwood@gmail.com,
Li Xu <li.xu@cirrus.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: wm_adsp: Expose mixer control API
Date: Mon, 4 Nov 2019 12:58:31 +0000 [thread overview]
Message-ID: <20191104125831.GD5238@sirena.co.uk> (raw)
In-Reply-To: <1572550603-21560-1-git-send-email-david.rhodes@cirrus.com>
[-- Attachment #1.1: Type: text/plain, Size: 1417 bytes --]
On Thu, Oct 31, 2019 at 02:36:43PM -0500, David Rhodes wrote:
> From: Li Xu <li.xu@cirrus.com>
> Expose mixer control API for reading and writing.
> The exposed API can be used by codec driver for
> interacting with mixer control in kernel space.
> This allows codec driver to implement more involved
> interactions with DSP firmware, such as Fast Use
> Case Switching.
It would be helpful if somewhere in the changelog you more explicitly
said that this was an in-kernel API, it isn't very clear what the API
you're adding is supposed to be.
The formatting here is also a bit weird, the lines are very short.
> +/*
> + * Find wm_coeff_ctl with input name as its subname
> + * If not found, return NULL
> + */
> +static struct wm_coeff_ctl *wm_adsp_get_ctl(struct wm_adsp *dsp,
> + const char *name)
It is not clear why we only look things up by subname. What's wrong
with the rest of the name?
> +int wm_adsp_write_ctl(struct wm_adsp *dsp, const char *name, const void *buf,
> + size_t len)
> +{
> + struct wm_coeff_ctl *ctl;
> +
> + ctl = wm_adsp_get_ctl(dsp, name);
> + if (!ctl)
> + return -EINVAL;
> +
> + if (len > ctl->len)
> + return -EINVAL;
> +
> + return wm_coeff_write_control(ctl, buf, len);
> +}
> +EXPORT_SYMBOL_GPL(wm_adsp_write_ctl);
There should be a snd_ctl_notify() somewhere in the write path to tell
userspace that the value changed.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-04 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 19:36 [alsa-devel] [PATCH] ASoC: wm_adsp: Expose mixer control API David Rhodes
2019-11-04 9:47 ` Charles Keepax
2019-11-04 12:58 ` Mark Brown [this message]
2019-11-06 23:04 ` [alsa-devel] [EXTERNAL] " Rhodes, David
2019-11-15 19:54 [alsa-devel] [PATCH v2] " David Rhodes
2019-11-15 19:54 ` [alsa-devel] [PATCH] " David Rhodes
2019-11-18 13:46 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104125831.GD5238@sirena.co.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.rhodes@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=li.xu@cirrus.com \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).