From: kbuild test robot <lkp@intel.com>
To: Andrew Gabbasov <andrew_gabbasov@mentor.com>
Cc: Timo Wischer <twischer@de.adit-jv.com>,
alsa-devel@alsa-project.org,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
kbuild-all@lists.01.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH v2 7/8] ALSA: aloop: Support selection of snd_timer instead of jiffies
Date: Wed, 6 Nov 2019 08:43:31 +0800 [thread overview]
Message-ID: <201911060802.dn1I6c8f%lkp@intel.com> (raw)
In-Reply-To: <20191105143218.5948-8-andrew_gabbasov@mentor.com>
[-- Attachment #1: Type: text/plain, Size: 3184 bytes --]
Hi Andrew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.4-rc6 next-20191105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Andrew-Gabbasov/ALSA-aloop-Support-sound-timer-as-clock-source-instead-of-jiffies/20191106-073459
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
sound/drivers/aloop.c: In function 'loopback_parse_timer_id':
>> sound/drivers/aloop.c:1063:8: error: 'snd_cards' undeclared (first use in this function); did you mean 'snd_card'?
if (snd_cards[card] &&
^~~~~~~~~
snd_card
sound/drivers/aloop.c:1063:8: note: each undeclared identifier is reported only once for each function it appears in
vim +1063 sound/drivers/aloop.c
1039
1040 static int loopback_parse_timer_id(const char * const str,
1041 struct snd_timer_id *tid)
1042 {
1043 /* [<pref>:](<card name>|<card idx>)[{.,}<dev idx>[{.,}<subdev idx>]] */
1044 const char * const sep_dev = ".,";
1045 const char * const sep_pref = ":";
1046 const char *name = str;
1047 char save, *sep;
1048 int card = 0, device = 0, subdevice = 0;
1049 int err;
1050
1051 sep = strpbrk(str, sep_pref);
1052 if (sep)
1053 name = sep + 1;
1054 sep = strpbrk(name, sep_dev);
1055 if (sep) {
1056 save = *sep;
1057 *sep = '\0';
1058 }
1059 err = kstrtoint(name, 0, &card);
1060 if (err == -EINVAL) {
1061 /* Must be the name, not number */
1062 for (card = 0; card < snd_ecards_limit; card++) {
> 1063 if (snd_cards[card] &&
1064 !strcmp(snd_cards[card]->id, name)) {
1065 err = 0;
1066 break;
1067 }
1068 }
1069 }
1070 if (!err && sep) {
1071 char save2, *sep2;
1072 sep2 = strpbrk(sep + 1, sep_dev);
1073 if (sep2) {
1074 save2 = *sep2;
1075 *sep2 = '\0';
1076 }
1077 err = kstrtoint(sep + 1, 0, &device);
1078 if (!err && sep2) {
1079 err = kstrtoint(sep2 + 1, 0, &subdevice);
1080 }
1081 if (sep2)
1082 *sep2 = save2;
1083 }
1084 if (!err && tid) {
1085 tid->card = card;
1086 tid->device = device;
1087 tid->subdevice = subdevice;
1088 }
1089 if (sep)
1090 *sep = save;
1091 return err;
1092 }
1093
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52246 bytes --]
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-06 0:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 14:32 [alsa-devel] [PATCH v2 0/8] ALSA: aloop: Support sound timer as clock source instead of jiffies Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 1/8] ALSA: aloop: Describe units of variables Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 2/8] ALSA: aloop: loopback_timer_start: Support return of error code Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 3/8] ALSA: aloop: loopback_timer_stop: " Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 4/8] ALSA: aloop: Use callback functions for timer specific implementations Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 5/8] ALSA: aloop: Rename all jiffies timer specific functions Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 6/8] ALSA: aloop: Move CABLE_VALID_BOTH to the top of file Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 7/8] ALSA: aloop: Support selection of snd_timer instead of jiffies Andrew Gabbasov
2019-11-05 14:32 ` [alsa-devel] [PATCH v2 8/8] ALSA: aloop: Support runtime change of snd_timer via info interface Andrew Gabbasov
2019-11-07 8:06 ` Takashi Iwai
2019-11-07 10:40 ` Gabbasov, Andrew
2019-11-07 10:50 ` Takashi Iwai
2019-11-06 0:43 ` kbuild test robot [this message]
2019-11-06 21:25 ` [alsa-devel] [PATCH v2 7/8] ALSA: aloop: Support selection of snd_timer instead of jiffies kbuild test robot
2019-11-07 8:05 ` Takashi Iwai
2019-11-08 18:09 ` Andrew Gabbasov
2019-11-11 11:17 ` Andrew Gabbasov
2019-11-06 15:51 ` [alsa-devel] [PATCH v2 3/8] ALSA: aloop: loopback_timer_stop: Support return of error code Takashi Iwai
2019-11-06 17:45 ` Andrew Gabbasov
2019-11-06 15:50 ` [alsa-devel] [PATCH v2 2/8] ALSA: aloop: loopback_timer_start: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911060802.dn1I6c8f%lkp@intel.com \
--to=lkp@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew_gabbasov@mentor.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=twischer@de.adit-jv.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).