From: Rob Herring <robh@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kuninori.morimoto.gx@renesas.com, linus.walleij@linaro.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
broonie@kernel.org
Subject: Re: [alsa-devel] [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio
Date: Mon, 18 Nov 2019 15:32:56 -0600 [thread overview]
Message-ID: <20191118213256.GA27262@bogus> (raw)
In-Reply-To: <20191113124734.27984-2-peter.ujfalusi@ti.com>
On Wed, Nov 13, 2019 at 02:47:33PM +0200, Peter Ujfalusi wrote:
> On boards where the RST line is not pulled up, but it is connected to a
> GPIO line this property must present in order to be able to enable the
> codec.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Documentation/devicetree/bindings/sound/ti,pcm3168a.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt b/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> index 5d9cb84c661d..f30aebc7603a 100644
> --- a/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> +++ b/Documentation/devicetree/bindings/sound/ti,pcm3168a.txt
> @@ -25,6 +25,12 @@ Required properties:
>
> For required properties on SPI/I2C, consult SPI/I2C device tree documentation
>
> +Optional properties:
> +
> + - rst-gpios : Optional RST gpio line for the codec
> + RST = low: device power-down
> + RST = high: device is enabled
'reset-gpios' is the standard naming for reset lines.
> +
> Examples:
>
> i2c0: i2c0@0 {
> @@ -34,6 +40,7 @@ i2c0: i2c0@0 {
> pcm3168a: audio-codec@44 {
> compatible = "ti,pcm3168a";
> reg = <0x44>;
> + rst-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
> clocks = <&clk_core CLK_AUDIO>;
> clock-names = "scki";
> VDD1-supply = <&supply3v3>;
> --
> Peter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-18 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 12:47 [alsa-devel] [PATCH 0/2] ASoC: pcm3168a: Poor man's RST gpio handling Peter Ujfalusi
2019-11-13 12:47 ` [alsa-devel] [PATCH 1/2] bindings: sound: pcm3168a: Document optional RST gpio Peter Ujfalusi
2019-11-18 13:08 ` Mark Brown
2019-11-18 14:46 ` Peter Ujfalusi
2019-11-18 16:01 ` Mark Brown
2019-11-18 13:09 ` [alsa-devel] Applied "ASoC: pcm3168a: Document optional RST gpio" to the asoc tree Mark Brown
2019-11-18 21:32 ` Rob Herring [this message]
2019-11-13 12:47 ` [alsa-devel] [PATCH 2/2] ASoC: pcm3168a: Add support for optional RST gpio handling Peter Ujfalusi
2019-11-18 13:09 ` [alsa-devel] Applied "ASoC: pcm3168a: Add support for optional RST gpio handling" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118213256.GA27262@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).