From: Pavel Dobias <dobias@2n.cz>
To: <alsa-devel@alsa-project.org>
Cc: broonie@kernel.org, ladis@linux-mips.org, Pavel Dobias <dobias@2n.cz>
Subject: [PATCH v2 0/2] ASoC: max9867: keep ADCs and DACs always on
Date: Fri, 22 May 2020 16:29:55 +0200 [thread overview]
Message-ID: <20200522142957.18364-1-dobias@2n.cz> (raw)
In-Reply-To: <20200520130131.GG4823@sirena.org.uk>
On 20. 05. 20 15:01, Mark Brown wrote:
> On Wed, May 20, 2020 at 09:19:02AM +0200, Pavel Dobias wrote:
>> Codec requires enabling of left and right ADCs in the same I2C write
>> operation which isn't fullfilled when controlled from DAPM and
>> causes unexpected behaviour of codec. The similar applies to DACs.
>> Enable ADCs and DACs once at startup and never switch them off
>> to solve the issue.
> It will be normally when the two channels are updated simultaneously
> though that doesn't stop the user doing something to update them
> separately. In any case this would be better handled through moving the
> power control to either supply widgets or event callbacks rather than
> just giving up on power control entirely.
I found out that the codec requires toggling shutdown bit on each change
of the power management register (stated in the datasheet). I tried
that and it worked, even updating the two channels separately worked,
but toggling the shutdown bit causes a loud speaker crackling which
can't be suppressed by muting the DACs. It seems to me that
the best choice is to avoid changing the power management register
during the codec's operation to suppress speaker crackling.
Pavel Dobias (2):
ASoC: max9867: add digital microphone controls
ASoC: max9867: keep ADCs and DACs always on
sound/soc/codecs/max9867.c | 45 ++++++++++++++++++++++++++++----------
sound/soc/codecs/max9867.h | 1 -
2 files changed, 33 insertions(+), 13 deletions(-)
--
2.20.1
next prev parent reply other threads:[~2020-05-22 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 7:18 [PATCH 1/6] ASoC: max9867: fix ADC level control Pavel Dobias
2020-05-20 7:19 ` [PATCH 2/6] ASoC: max9867: don't use regmap defaults Pavel Dobias
2020-05-20 7:19 ` [PATCH 3/6] ASoC: max9867: add filter controls Pavel Dobias
2020-05-20 7:19 ` [PATCH 4/6] ASoC: max9867: keep ADCs and DACs always on Pavel Dobias
2020-05-20 13:01 ` Mark Brown
2020-05-22 14:29 ` Pavel Dobias [this message]
2020-05-22 14:29 ` [PATCH v2 1/2] ASoC: max9867: add digital microphone controls Pavel Dobias
2020-05-22 14:29 ` [PATCH v2 2/2] ASoC: max9867: keep ADCs and DACs always on Pavel Dobias
2020-05-22 19:00 ` [PATCH v2 0/2] " Mark Brown
2020-05-20 7:19 ` [PATCH 5/6] ASoC: max9867: add mono playback switch Pavel Dobias
2020-05-20 7:19 ` [PATCH 6/6] ASoC: max9867: add digital microphone controls Pavel Dobias
2020-05-20 17:17 ` [PATCH 1/6] ASoC: max9867: fix ADC level control Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522142957.18364-1-dobias@2n.cz \
--to=dobias@2n.cz \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ladis@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).